Added OSF file support. Added ability to pause lidar capture if from file. Updated Preferences->"test odometry" button to support lidar only or both.

corelib/include/rtabmap/core/lidar/LidarOuster.h

@@ -38,22 +38,14 @@ public:
 	static bool available();
 public:
 	LidarOuster(
-		const std::string& sensorHostname,
+		const std::string& ipOrHostnameOrPcapOrOsf,
+		const std::string& dataDestinationOrJson = "",
 		int lidarMode = 0,
 		int timestampMode = 0,
-		const std::string& dataDestination = 0,
 		bool useReflectivityForIntensityChannel = true,
 		bool publishIMU = false,
 		float frameRate = 0.0f,
 		Transform localTransform = Transform::getIdentity());
-
-	LidarOuster(
-			const std::string& pcapFile,
-			const std::string& jsonFile,
-			bool useReflectivityForIntensityChannel = true,
-			bool publishIMU = false,
-			float frameRate = 0.0f,
-			Transform localTransform = Transform::getIdentity());
 	virtual ~LidarOuster();
 
 	SensorData takeScan(SensorCaptureInfo * info = 0) {return takeData(info);}
@@ -68,10 +60,8 @@ private:
 	OusterCaptureThread * ousterCaptureThread_;
 	bool imuPublished_;
 	bool useReflectivityForIntensityChannel_;
-	std::string pcapFile_;
+	std::string ipOrHostnameOrPcapOrOsf_;
-	std::string jsonFile_;
+	std::string dataDestinationOrJson_;
-	std::string sensorHostname_;
-	std::string dataDestination_;
 	int lidarMode_;
 	int timestampMode_;
 

corelib/src/CMakeLists.txt

@@ -398,6 +398,7 @@ IF(OusterSDK_FOUND)
 		${LIBRARIES}
 		OusterSDK::ouster_client
 		OusterSDK::ouster_pcap
+		OusterSDK::ouster_osf
 	)
 ENDIF(OusterSDK_FOUND)
 

corelib/src/lidar/LidarOuster.cpp

@@ -29,13 +29,20 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include <rtabmap/utilite/UStl.h>
 #include <rtabmap/core/IMUFilter.h>
 #include <rtabmap/utilite/UTimer.h>
+#include <rtabmap/utilite/UFile.h>
 
+#define RTABMAP_OUSTER
 #ifdef RTABMAP_OUSTER
 #include "ouster/client.h"
 #include "ouster/os_pcap.h"
 #include "ouster/types.h"
 #include "ouster/impl/build.h"
 #include "ouster/lidar_scan.h"
+#include "ouster/osf/reader.h"
+#include "ouster/osf/stream_lidar_scan.h"
+#include "ouster/osf/meta_lidar_sensor.h"
+#include "ouster/osf/meta_extrinsics.h"
+#include "ouster/osf/meta_streaming_info.h"
 #endif
 
 namespace rtabmap {
@@ -55,7 +62,7 @@ class OusterCaptureThread : public UThread {
 			intensityChannel_(useReflectivityForIntensityChannel?
 				ouster::sensor::ChanField::REFLECTIVITY:
 				ouster::sensor::ChanField::SIGNAL),
-		sleepTimeMs_(0)
+			endOfFileReached_(false)
 	{
 		UDEBUG("");
 		init(imuPublished);
@@ -72,18 +79,28 @@ class OusterCaptureThread : public UThread {
 			intensityChannel_(useReflectivityForIntensityChannel?
 				ouster::sensor::ChanField::REFLECTIVITY:
 				ouster::sensor::ChanField::SIGNAL),
-			sleepTimeMs_(100)
+			endOfFileReached_(false)
 	{
 		UDEBUG("");
-		std::string lidarMode = ouster::sensor::to_string(info_.config.lidar_mode.value_or(ouster::sensor::lidar_mode::MODE_UNSPEC));
+		init(imuPublished);
-		std::list<std::string> lidarModeSplit = uSplit(lidarMode, 'x');
+	}
-		if(lidarModeSplit.size() == 2) {
-			int rate = uStr2Int(*lidarModeSplit.rbegin());
-			UASSERT(rate > 0);
-			sleepTimeMs_ = 1000/rate;
-			UINFO("Setting frame rate to %d Hz (lidar mode = %s) wil sleep %ld ms after each frame", rate, lidarMode.c_str(), sleepTimeMs_);
-		}
 
+	OusterCaptureThread(
+		std::shared_ptr<ouster::osf::Reader> & osfReader,
+		const ouster::sensor::sensor_info & info,
+		bool imuPublished,
+		bool useReflectivityForIntensityChannel) :
+			scanBatcher_(info),
+			pf_(ouster::sensor::get_format(info)),
+			osfReader_(osfReader),
+			osfIter_(osfReader_->messages().begin()),
+			info_(info),
+			intensityChannel_(useReflectivityForIntensityChannel?
+				ouster::sensor::ChanField::REFLECTIVITY:
+				ouster::sensor::ChanField::SIGNAL),
+			endOfFileReached_(false)
+	{
+		UDEBUG("");
 		init(imuPublished);
 	}
 
@@ -99,61 +116,76 @@ class OusterCaptureThread : public UThread {
 
 	bool getScan(LaserScan & output, double & stamp)
 	{
-		if(this->isRunning())
+		if(clientHandle_.get() == 0)
 		{
-			if(!scanReady_.acquire(1, 5000))
+			// We are reading from file, call mainLoop till a scan is received or end of stream
+			while(scanReady_.value() == 0 && !endOfFileReached_)
+				this->mainLoop();
+		}
+	
+		if(!endOfFileReached_ && !scanReady_.acquire(1, 5000))
+		{
+			UERROR("Not received any frames since 5 seconds, try to restart the camera again.");
+		}
+		else if(!endOfFileReached_ || this->isRunning())
+		{
+			ouster::LidarScan scan;
 			{
-				UERROR("Not received any frames since 5 seconds, try to restart the camera again.");
+				UScopeMutex s(scanMutex_);
+				scan = lastScan_;
+				lastScan_ = ouster::LidarScan();
 			}
-			else if(this->isRunning())
-			{
-				ouster::LidarScan scan;
-				{
-					UScopeMutex s(scanMutex_);
-					scan = lastScan_;
-					lastScan_ = ouster::LidarScan();
-				}
 
-				UASSERT(scan.has_field(ouster::sensor::ChanField::RANGE));
+			UASSERT(scan.has_field(ouster::sensor::ChanField::RANGE));
-				UASSERT(scan.has_field(intensityChannel_));
+			UASSERT(scan.has_field(intensityChannel_));
 
-				ouster::LidarScan::Points cloud = ouster::cartesian(scan, lut_);
+			ouster::LidarScan::Points cloud = ouster::cartesian(scan, lut_);
 
-				// Convert to our LaserScan format XYZIT
+			// Convert to our LaserScan format XYZIT
-				output = LaserScan(cv::Mat(cv::Size(scan.w,scan.h), CV_32FC(5)), LaserScan::kXYZIT, 0, 0, 0, 0, 0, lidarSensorT_);
+			output = LaserScan(cv::Mat(cv::Size(scan.w,scan.h), CV_32FC(5)), LaserScan::kXYZIT, 0, 0, 0, 0, 0, lidarSensorT_);
+			auto timestamp = scan.timestamp();
+			auto scan_ts = timestamp[scan.w-1]; // stamp with last reading
 
-				auto timestamp = scan.timestamp();
+			//UWARN("Prepare scan %f -> %f", double(timestamp[0])/10e8, double(timestamp[scan.w-1])/10e8);
-				auto scan_ts = timestamp[scan.w-1]; // stamp with last reading
+			auto intensityOffset = output.getIntensityOffset();
-
+			auto timeOffset = output.getTimeOffset();
-				//UWARN("Prepare scan %f -> %f", double(timestamp[0])/10e8, double(timestamp[scan.w-1])/10e8);
+			float bad_point = std::numeric_limits<float>::quiet_NaN ();
-
+			ouster::FieldType intensityType = scan.field_type(intensityChannel_==ouster::sensor::ChanField::REFLECTIVITY?"REFLECTIVITY":"SIGNAL");
-				auto intensityOffset = output.getIntensityOffset();
+			for (size_t u = 0; u < scan.h; u++) {
-				auto timeOffset = output.getTimeOffset();
+				for (size_t v = 0; v < scan.w; v++) {
-
+					auto ts = scan_ts-timestamp[v];
-				float bad_point = std::numeric_limits<float>::quiet_NaN ();
+					auto index = u*scan.w+v;
-				auto intensity = scan.field<uint32_t>(intensityChannel_);
+					if(cloud(index, 0) != 0.0)
-				for (size_t u = 0; u < scan.h; u++) {
+					{
-					for (size_t v = 0; v < scan.w; v++) {
+						output.field(index, 0) = cloud(index, 0);
-						auto ts = scan_ts-timestamp[v];
+						output.field(index, 1) = cloud(index, 1);
-						auto index = u*scan.w+v;
+						output.field(index, 2) = cloud(index, 2);
-						if(cloud(index, 0) != 0.0)
-						{
-							output.field(index, 0) = cloud(index, 0);
-							output.field(index, 1) = cloud(index, 1);
-							output.field(index, 2) = cloud(index, 2);
-						}
-						else
-						{
-							output.field(index, 0) = output.field(index, 1) = output.field(index, 2) = bad_point;
-						}
-						output.field(index, intensityOffset) = intensity.data()[index];
-						output.field(index, timeOffset) = -float(ts)/10e8;
 					}
+					else
+					{
+						output.field(index, 0) = output.field(index, 1) = output.field(index, 2) = bad_point;
+					}
+					if(intensityType.element_type == ouster::sensor::ChanFieldType::UINT32)
+					{
+						output.field(index, intensityOffset) = scan.field<uint32_t>(intensityChannel_).data()[index];
+					}
+					else if(intensityType.element_type == ouster::sensor::ChanFieldType::UINT16)
+					{
+						output.field(index, intensityOffset) = scan.field<uint16_t>(intensityChannel_).data()[index];
+					}
+					else if(intensityType.element_type == ouster::sensor::ChanFieldType::UINT8)
+					{
+						output.field(index, intensityOffset) = scan.field<uint8_t>(intensityChannel_).data()[index];
+					}
+					else
+					{
+						UFATAL("Intensity format %d not supported!", intensityType.element_type);
+					}
+					output.field(index, timeOffset) = -float(ts)/10e8;
 				}
-
-				stamp = double(scan_ts)/10e8;
-				return true;
 			}
+			stamp = double(scan_ts)/10e8;
+			return true;
 		}
 		return false;
 	}
@@ -230,7 +262,6 @@ private:
 	void init(bool imuPublished)
 	{
 		imuFilter_ = 0;
-		lastSleepStamp_ = UTimer::now();
 		
 		UINFO("imuPublished=%d", imuPublished?1:0);
 		size_t w = info_.format.columns_per_frame;
@@ -318,7 +349,7 @@ private:
 			if(!ouster::sensor_utils::next_packet_info(*pcapHandle_, packet_info))
 			{
 				UWARN("No more data");
-				this->kill();
+				endOfFileReached_ = true;
 				return;
 			}
 
@@ -341,6 +372,33 @@ private:
 				}
 			}
 		}
+		else if(osfReader_.get())
+		{
+			// read next message from OSF in timestamp order
+			if(osfIter_ == osfReader_->messages().end())
+			{
+				UWARN("No more data");
+				endOfFileReached_ = true;
+				return;
+			}
+			if(osfIter_->is<ouster::osf::LidarScanStream>())
+			{
+				// Decoding LidarScan messages
+				auto ls = osfIter_->decode_msg<ouster::osf::LidarScanStream>();
+				{
+					UScopeMutex s(scanMutex_);
+					bool notify = lastScan_.w == 0;
+					lastScan_ = *ls;
+					if(lastScan_.w != 0 && notify)
+					{
+						scanReady_.release();
+					}
+				}
+			}
+			//else if(m.is<ouster::osf::LidarImuStream>()) // Seems not implemented in ouster-sdk
+
+			++osfIter_;
+		}
 		else {
 			UFATAL("");
 		}
@@ -361,13 +419,6 @@ private:
 							scanReady_.release();
 						}
 					}
-					if(sleepTimeMs_>0) {
-						unsigned int deltaMs = int((UTimer::now() - lastSleepStamp_)*1000);
-						if(deltaMs < sleepTimeMs_) {
-							uSleep(sleepTimeMs_-deltaMs);
-						}
-						lastSleepStamp_ = UTimer::now();
-					}
                 }
             }
 		}
@@ -423,6 +474,8 @@ private:
 	ouster::sensor::ImuPacket imuPacket_;
 	std::shared_ptr<ouster::sensor::client> clientHandle_;
 	std::shared_ptr<ouster::sensor_utils::playback_handle> pcapHandle_;
+	std::shared_ptr<ouster::osf::Reader> osfReader_;
+	ouster::osf::MessagesStreamingIter osfIter_;
 	ouster::sensor::sensor_info info_;
 	ouster::sensor::cf_type intensityChannel_;
 	ouster::XYZLut lut_;
@@ -430,16 +483,15 @@ private:
 	Transform imuLocalTransform_;
 	IMUFilter * imuFilter_;
 	std::map<double, IMU> imuBuffer_;
-	unsigned int sleepTimeMs_;
+	bool endOfFileReached_;
-	double lastSleepStamp_;
 };
 #endif
 
 LidarOuster::LidarOuster(
-		const std::string& sensorHostname,
+		const std::string& ipOrHostnameOrPcapOrOsf,
+		const std::string& dataDestinationOrJson,
 		int lidarMode,
 		int timestampMode,
-		const std::string& dataDestination,
 		bool useReflectivityForIntensityChannel,
 		bool publishIMU,
 		float frameRate,
@@ -448,35 +500,18 @@ LidarOuster::LidarOuster(
 	ousterCaptureThread_(0),
 	imuPublished_(publishIMU),
 	useReflectivityForIntensityChannel_(useReflectivityForIntensityChannel),
-	sensorHostname_(sensorHostname),
+	ipOrHostnameOrPcapOrOsf_(ipOrHostnameOrPcapOrOsf),
-	dataDestination_(dataDestination),
+	dataDestinationOrJson_(dataDestinationOrJson),
 	lidarMode_(lidarMode),
 	timestampMode_(timestampMode)
 {
-	UASSERT(!sensorHostname_.empty());
+	UASSERT(!ipOrHostnameOrPcapOrOsf.empty());
-	UDEBUG("Using sensor hostname \"%s\" and destination (optional) \"%s\"", sensorHostname_.c_str(), dataDestination_.c_str());
 #ifdef RTABMAP_OUSTER
 	UASSERT(lidarMode>=ouster::sensor::lidar_mode::MODE_UNSPEC && lidarMode<=ouster::sensor::lidar_mode::MODE_4096x5);
 	UASSERT(timestampMode>=ouster::sensor::timestamp_mode::TIME_FROM_UNSPEC && timestampMode<=ouster::sensor::timestamp_mode::TIME_FROM_PTP_1588);
 #endif
 }
-LidarOuster::LidarOuster(
+
-		const std::string& pcapFile,
-		const std::string& jsonFile,
-		bool useReflectivityForIntensityChannel,
-		bool publishIMU,
-		float frameRate,
-		Transform localTransform) :
-	Lidar(frameRate, localTransform),
-	ousterCaptureThread_(0),
-	imuPublished_(publishIMU),
-	useReflectivityForIntensityChannel_(useReflectivityForIntensityChannel),
-	pcapFile_(pcapFile),
-	jsonFile_(jsonFile)
-{
-	UASSERT(!pcapFile.empty());
-	UDEBUG("Using PCAP file \"%s\" and JSON file \"%s\"", pcapFile.c_str(), jsonFile.c_str());
-}
 LidarOuster::~LidarOuster()
 {
 #ifdef RTABMAP_OUSTER
@@ -513,19 +548,74 @@ bool LidarOuster::init(const std::string &, const std::string &)
 	delete ousterCaptureThread_;
 	ousterCaptureThread_ = 0;
 
+	bool readingFromFile = false;
 	ouster::sensor::sensor_info info;
-
+	std::string ext = uToLowerCase(UFile::getExtension(ipOrHostnameOrPcapOrOsf_));
-	if(!sensorHostname_.empty())
+	if(ext == "pcap")
 	{
+		UINFO("Using PCAP file \"%s\" and JSON file \"%s\"", ipOrHostnameOrPcapOrOsf_.c_str(), dataDestinationOrJson_.c_str());
+		if(dataDestinationOrJson_.empty())
+		{
+			UERROR("A JSON path should be provided when a PCAP path is used.");
+			return false;
+		}
+
 		UDEBUG("");
+		auto pcapHandle = ouster::sensor_utils::replay_initialize(ipOrHostnameOrPcapOrOsf_);
+		if(!pcapHandle) {
+			UERROR("Failed to open pcap file \"%s\"!", ipOrHostnameOrPcapOrOsf_.c_str());
+			return false;
+		}
+    	info = ouster::sensor::metadata_from_json(dataDestinationOrJson_);
+
+		ousterCaptureThread_ = new OusterCaptureThread(
+			pcapHandle,
+			info,
+			imuPublished_,
+			useReflectivityForIntensityChannel_);
+		readingFromFile = true;
+	}
+	else if(ext == "osf")
+	{
+		UINFO("Using OSF file \"%s\"", ipOrHostnameOrPcapOrOsf_.c_str());
+		if(imuPublished_)
+		{
+			UWARN("Imu publishing it not supported for OSF files.");
+			imuPublished_ = false;
+		}
+		try {
+			std::shared_ptr<ouster::osf::Reader> osfReader(new ouster::osf::Reader(ipOrHostnameOrPcapOrOsf_));
+			auto sensors = osfReader->meta_store().find<ouster::osf::LidarSensor>();
+			std::cout << "sensors: " << sensors.size() << std::endl;
+
+			// Use first sensor and get its sensor_info
+			info = sensors.begin()->second->info();
+
+			ousterCaptureThread_ = new OusterCaptureThread(
+				osfReader,
+				info,
+				imuPublished_,
+				useReflectivityForIntensityChannel_);
+			
+			readingFromFile = true;
+		}
+		catch(std::exception & e) {
+			return false;
+		}
+	}
+	else // ip / hostname
+	{
+		UINFO("Using sensor hostname \"%s\" and destination (optional) \"%s\"",
+			ipOrHostnameOrPcapOrOsf_.c_str(), dataDestinationOrJson_.c_str());
 		auto clientHandle = ouster::sensor::init_client(
-			sensorHostname_, 
+			ipOrHostnameOrPcapOrOsf_, 
-			dataDestination_,
+			dataDestinationOrJson_,
 			(ouster::sensor::lidar_mode)lidarMode_,
 			(ouster::sensor::timestamp_mode)timestampMode_);
 		
 		if(!clientHandle) {
-			UERROR("Failed to connect to sensor! Verify that the Ouster can be reached on the network at this address \"%s\".", sensorHostname_.c_str());
+			UERROR("Failed to connect to sensor! Verify that the Ouster can be reached on the network at this address \"%s\".",
+				ipOrHostnameOrPcapOrOsf_.c_str());
 			return false;
 		}
 		
@@ -536,29 +626,11 @@ bool LidarOuster::init(const std::string &, const std::string &)
 		// Raw metadata can be parsed into a `sensor_info` struct
 		info = ouster::sensor::sensor_info(metadata);
 
-		ousterCaptureThread_ = new OusterCaptureThread(clientHandle, info, imuPublished_, useReflectivityForIntensityChannel_);
+		ousterCaptureThread_ = new OusterCaptureThread(
-	}
+			clientHandle,
-	else if(!pcapFile_.empty())
+			info,
-	{
+			imuPublished_,
-		if(jsonFile_.empty())
+			useReflectivityForIntensityChannel_);
-		{
-			UERROR("A JSON path should be provided when a PCAP path is used.");
-			return false;
-		}
-		UDEBUG("");
-		auto pcapHandle = ouster::sensor_utils::replay_initialize(pcapFile_);
-		if(!pcapHandle) {
-			UERROR("Failed to open pcap file \"%s\"!", pcapFile_.c_str());
-			return false;
-		}
-    	info = ouster::sensor::metadata_from_json(jsonFile_);
-
-		ousterCaptureThread_ = new OusterCaptureThread(pcapHandle, info, imuPublished_, useReflectivityForIntensityChannel_);
-	}
-	else // OSF?
-	{
-		UERROR("Not implemented");
-		return false;
 	}
 	
 	UINFO("Firmware version: %s", info.fw_rev.c_str());
@@ -567,7 +639,25 @@ bool LidarOuster::init(const std::string &, const std::string &)
 	UINFO("Scan dimensions:  %ld x %ld", info.format.columns_per_frame, info.format.pixels_per_column);
 	//UINFO("Column window:    [%d,%d]", info.column_window.first, info.column_window.second);
 
-	ousterCaptureThread_->start();
+	if(!readingFromFile)
+	{
+		ousterCaptureThread_->start();
+	}
+	else if(this->getFrameRate() == 0.0f)
+	{ 
+		std::string lidarMode = ouster::sensor::to_string(info.config.lidar_mode.value_or(ouster::sensor::lidar_mode::MODE_UNSPEC));
+		std::list<std::string> lidarModeSplit = uSplit(lidarMode, 'x');
+		if(lidarModeSplit.size() == 2) {
+			int rate = uStr2Int(*lidarModeSplit.rbegin());
+			UASSERT(rate > 0);
+			this->setFrameRate(rate);
+			UINFO("Setting frame rate to %d Hz (lidar mode = %s)", rate, lidarMode.c_str());
+		}
+		else
+		{
+			UERROR("Unknown lidar mode \"%s\", framerate is kept to 0.", lidarMode.c_str());
+		}
+	}
 
 	return true;
 #else

examples/LidarMapping/main.cpp

@@ -36,6 +36,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "rtabmap/utilite/UEventsManager.h"
 #include "rtabmap/utilite/UStl.h"
 #include "rtabmap/utilite/UDirectory.h"
+#include "rtabmap/utilite/UFile.h"
 #include <QApplication>
 #include <stdio.h>
 #include <pcl/io/pcd_io.h>
@@ -103,10 +104,11 @@ int main(int argc, char * argv[])
 			printf("Not supported driver %d!\n", driver);
 			showUsage();
 		}
-		if(uStrContains(uToLowerCase(argv[i]), "pcap"))
+		std::string ext = UFile::getExtension(uToLowerCase(argv[i]));
+		if(ext == "pcap" || ext == "osf")
 		{
 			pcapFile = argv[i++];
-			if(driver == 1)
+			if(driver == 1 && ext == "pcap")
 			{
 				if(i<argc) {
 					jsonFile=argv[i];
@@ -119,7 +121,7 @@ int main(int argc, char * argv[])
 		}
 		else if(i<argc-1) {
 			ip = argv[i++];
-			if(driver == 0 && i<argc) {
+			if(i<argc) {
 				port = uStr2Int(argv[i]);
 			}
 			else {

guilib/src/OdometryViewer.cpp

@@ -185,6 +185,8 @@ void OdometryViewer::processData(const rtabmap::OdometryEvent & odom)
 	bool lost = false;
 	bool lostStateChanged = false;
 
+	imageView_->setVisible(!odom.data().imageRaw().empty() || !odom.data().depthOrRightRaw().empty());
+
 	if(odom.pose().isNull())
 	{
 		UDEBUG("odom lost"); // use last pose
@@ -211,7 +213,7 @@ void OdometryViewer::processData(const rtabmap::OdometryEvent & odom)
 		cloudView_->setBackgroundColor(Qt::black);
 	}
 
-	timeLabel_->setText(QString("%1 s").arg(odom.info().timeEstimation));
+	timeLabel_->setText(QString("%1 s").arg(odom.info().timeEstimation));
 
 	if(cloudShown_->isChecked() &&
 		!odom.data().imageRaw().empty() &&
@@ -219,8 +221,8 @@ void OdometryViewer::processData(const rtabmap::OdometryEvent & odom)
 		(odom.data().stereoCameraModels().size() || odom.data().cameraModels().size()))
 	{
 		UDEBUG("New pose = %s, quality=%d", odom.pose().prettyPrint().c_str(), quality);
-
+
-		if(!odom.data().depthRaw().empty())
+		if(!odom.data().depthRaw().empty())
 		{
 			if(odom.data().imageRaw().cols % decimationSpin_->value() == 0 &&
 			   odom.data().imageRaw().rows % decimationSpin_->value() == 0)
@@ -238,14 +240,14 @@ void OdometryViewer::processData(const rtabmap::OdometryEvent & odom)
 			}
 		}
 		else
-		{
+		{
-			validDecimationValue_ = decimationSpin_->value();
+			validDecimationValue_ = decimationSpin_->value();
 		}
 
 		// visualization: buffering the clouds
 		// Create the new cloud
 		pcl::PointCloud<pcl::PointXYZRGB>::Ptr cloud;
-		pcl::IndicesPtr validIndices(new std::vector<int>);
+		pcl::IndicesPtr validIndices(new std::vector<int>);
 		cloud = util3d::cloudRGBFromSensorData(
 				odom.data(),
 				validDecimationValue_,
@@ -257,7 +259,7 @@ void OdometryViewer::processData(const rtabmap::OdometryEvent & odom)
 		if(voxelSpin_->value())
 		{
 			cloud = util3d::voxelize(cloud, validIndices, voxelSpin_->value());
-		}
+		}
 
 		if(cloud->size())
 		{
@@ -489,6 +491,7 @@ void OdometryViewer::processData(const rtabmap::OdometryEvent & odom)
 
 	imageView_->update();
 	cloudView_->update();
+	cloudView_->refreshView();
 	QApplication::processEvents();
 	processingData_ = false;
 }

guilib/src/PreferencesDialog.cpp

@@ -4810,10 +4810,14 @@ void PreferencesDialog::selectOusterPcapPath()
 	{
 		dir = getWorkingDirectory();
 	}
-	QString path = QFileDialog::getOpenFileName(this, tr("Select file"), dir, tr("Ouster recording (*.pcap)"));
+	QString path = QFileDialog::getOpenFileName(this, tr("Select file"), dir, tr("Ouster recording (*.pcap *.osf)"));
 	if (!path.isEmpty())
 	{
 		_ui->lineEdit_ouster_pcap_path->setText(path);
+		if(QFileInfo(path).suffix() == "pcap")
+		{
+			selectOusterJsonPath();
+		}
 	}
 }
 
@@ -7115,10 +7119,12 @@ Lidar * PreferencesDialog::createLidar()
 		{
 			if(!_ui->lineEdit_ouster_pcap_path->text().isEmpty())
 			{
-				// PCAP mode
+				// PCAP/OSF mode
 				lidar = new LidarOuster(
 						_ui->lineEdit_ouster_pcap_path->text().toStdString(),
 						_ui->lineEdit_ouster_json_path->text().toStdString(),
+						0, // lidar mode ignored
+						0, // timestamp mode ignored
 						_ui->checkBox_ouster_reflectivity->isChecked(),
 						_ui->checkBox_ouster_imu->isChecked(),
 						this->getGeneralInputRate(),
@@ -7130,9 +7136,9 @@ Lidar * PreferencesDialog::createLidar()
 
 				lidar = new LidarOuster(
 						_ui->lineEdit_ouster_ip_hostname->text().toStdString(),
+						"", // data destination ignored
 						_ui->comboBox_ouster_lidar_mode->currentIndex(),
 						_ui->comboBox_ouster_timestamp->currentIndex(),
-						"", // data destination
 						_ui->checkBox_ouster_reflectivity->isChecked(),
 						_ui->checkBox_ouster_imu->isChecked(),
 						this->getGeneralInputRate(),
@@ -7297,8 +7303,9 @@ void PreferencesDialog::setSLAMMode(bool enabled)
 
 void PreferencesDialog::testOdometry()
 {
-	Camera * camera = this->createCamera();
+	Camera * camera = this->getSourceDriver()!=-1?this->createCamera():0;
-	if(!camera)
+	Lidar * lidar = this->getLidarSourceDriver()!=-1?this->createLidar():0;
+	if(!camera && !lidar)
 	{
 		return;
 	}
@@ -7356,18 +7363,30 @@ void PreferencesDialog::testOdometry()
 	odomViewer->resize(1280, 480+QPushButton().minimumHeight());
 	odomViewer->registerToEventsManager();
 
-	SensorCaptureThread cameraThread(camera, this->getAllParameters()); // take ownership of camera
+	SensorCaptureThread  * cameraThread;
-	cameraThread.setMirroringEnabled(isSourceMirroring());
+	if(lidar && camera)
-	cameraThread.setColorOnly(_ui->checkbox_rgbd_colorOnly->isChecked());
+	{
-	cameraThread.setImageDecimation(_ui->spinBox_source_imageDecimation->value());
+		cameraThread = new SensorCaptureThread(lidar, camera, this->getAllParameters()); // take ownership of lidar and camera
-	cameraThread.setHistogramMethod(_ui->comboBox_source_histogramMethod->currentIndex());
+	}
+	else if(camera)
+	{
+		cameraThread = new SensorCaptureThread(camera, this->getAllParameters()); // take ownership of camera
+	}
+	else // lidar 
+	{
+		cameraThread = new SensorCaptureThread(lidar, this->getAllParameters()); // take ownership of lidar
+	}
+	cameraThread->setMirroringEnabled(isSourceMirroring());
+	cameraThread->setColorOnly(_ui->checkbox_rgbd_colorOnly->isChecked());
+	cameraThread->setImageDecimation(_ui->spinBox_source_imageDecimation->value());
+	cameraThread->setHistogramMethod(_ui->comboBox_source_histogramMethod->currentIndex());
 	if(_ui->checkbox_source_feature_detection->isChecked())
 	{
-		cameraThread.enableFeatureDetection(this->getAllParameters());
+		cameraThread->enableFeatureDetection(this->getAllParameters());
 	}
-	cameraThread.setStereoToDepth(_ui->checkbox_stereo_depthGenerated->isChecked());
+	cameraThread->setStereoToDepth(_ui->checkbox_stereo_depthGenerated->isChecked());
-	cameraThread.setStereoExposureCompensation(_ui->checkBox_stereo_exposureCompensation->isChecked());
+	cameraThread->setStereoExposureCompensation(_ui->checkBox_stereo_exposureCompensation->isChecked());
-	cameraThread.setScanParameters(
+	cameraThread->setScanParameters(
 			_ui->checkBox_source_scanFromDepth->isChecked(),
 			_ui->spinBox_source_scanDownsampleStep->value(),
 			_ui->doubleSpinBox_source_scanRangeMin->value(),
@@ -7379,23 +7398,23 @@ void PreferencesDialog::testOdometry()
 			_ui->checkBox_source_scanDeskewing->isChecked());
 	if(_ui->comboBox_imuFilter_strategy->currentIndex()>0 && dynamic_cast<DBReader*>(camera) == 0)
 	{
-		cameraThread.enableIMUFiltering(_ui->comboBox_imuFilter_strategy->currentIndex()-1, this->getAllParameters(), _ui->checkBox_imuFilter_baseFrameConversion->isChecked());
+		cameraThread->enableIMUFiltering(_ui->comboBox_imuFilter_strategy->currentIndex()-1, this->getAllParameters(), _ui->checkBox_imuFilter_baseFrameConversion->isChecked());
 	}
 	if(isDepthFilteringAvailable())
 	{
 		if(_ui->groupBox_bilateral->isChecked())
 		{
-			cameraThread.enableBilateralFiltering(
+			cameraThread->enableBilateralFiltering(
 					_ui->doubleSpinBox_bilateral_sigmaS->value(),
 					_ui->doubleSpinBox_bilateral_sigmaR->value());
 		}
 		if(!_ui->lineEdit_source_distortionModel->text().isEmpty())
 		{
-			cameraThread.setDistortionModel(_ui->lineEdit_source_distortionModel->text().toStdString());
+			cameraThread->setDistortionModel(_ui->lineEdit_source_distortionModel->text().toStdString());
 		}
 	}
 
-	UEventsManager::createPipe(&cameraThread, &odomThread, "SensorEvent");
+	UEventsManager::createPipe(cameraThread, &odomThread, "SensorEvent");
 	if(imuThread)
 	{
 		UEventsManager::createPipe(imuThread, &odomThread, "IMUEvent");
@@ -7404,7 +7423,7 @@ void PreferencesDialog::testOdometry()
 	UEventsManager::createPipe(odomViewer, &odomThread, "OdometryResetEvent");
 
 	odomThread.start();
-	cameraThread.start();
+	cameraThread->start();
 
 	if(imuThread)
 	{
@@ -7419,8 +7438,9 @@ void PreferencesDialog::testOdometry()
 		imuThread->join(true);
 		delete imuThread;
 	}
-	cameraThread.join(true);
+	cameraThread->join(true);
 	odomThread.join(true);
+	delete cameraThread;
 }
 
 void PreferencesDialog::testCamera()

guilib/src/ui/preferencesDialog.ui

@@ -63,9 +63,9 @@
           <property name="geometry">
            <rect>
             <x>0</x>
-            <y>0</y>
+            <y>-3879</y>
             <width>713</width>
-            <height>4720</height>
+            <height>4737</height>
            </rect>
           </property>
           <layout class="QVBoxLayout" name="verticalLayout_16">
@@ -95,7 +95,7 @@
                 <enum>QFrame::Raised</enum>
                </property>
                <property name="currentIndex">
-                <number>0</number>
+                <number>5</number>
                </property>
                <widget class="QWidget" name="page_22">
                 <layout class="QVBoxLayout" name="verticalLayout_29" stretch="0,0">
@@ -9188,7 +9188,7 @@ when using the file type, logs are saved in LogRtabmap.txt (located in the worki
                               <item row="4" column="2">
                                <widget class="QLabel" name="label_759">
                                 <property name="text">
-                                 <string>Path to a *.PCAP file. IP is ignored if PCAP file is used. A JSON file should be provided, see below.</string>
+                                 <string>Path to a *.PCAP or *.OSF file. IP is ignored if PCAP/OSF file is used. A JSON file should be provided if PCAP is used, see below.</string>
                                 </property>
                                 <property name="wordWrap">
                                  <bool>true</bool>