Files
rtabmap/corelib/test/test_registration.cpp
matlabbe ee49beaf4f Adding doc and tests (#1492)
* added doc and tests for util2d.h

* updated cmake-ros ci

* Added util3d.h doc and tests

* util3d_transforms.h: Added doc and tests

* util3d_filtering.h: started doc and test

* util3d_filtering.h: more tests and doc

* Added more doc/tests

* finished util3d_filtering doc and tests

* added test for util2d::depthBleedingFiltering

* Added util3d_registration tests

* Added util3d_features.h doc/tests

* added doc/tests for util3d_correspondences.h

* added doc/gtest for util3d_mapping.h (missing hpp functions)

* finished testing util3d_mapping.hpp

* Added util3d_motion_estimation.h tests (2D->3D done)

* finished util3d_motion_estimation.h tests

* minimal util3d_surface.h

* Added Transform and VisualWord tests

* Added doc for CameraModel and StereoCameraModel

* Added more logs in ros ci

* Passing tests on fical

* improved all devcontainer

* added devcontainer kilted, fixed source setup.bash, removed ldconfig in ros-cmake workflow

* cleanup

* source ros

* Added utilite tests

* Added testing to appveyor, github actions cancellable on re-commit on same branch

* appveyor testing without all targets

* appveyor: specifying ALL_BUILD target

* Fixed Util2dTest.NMSImageBoundsRespected test

* Fixing PCL Indices error on old pcl

* Added VWDictionary tests and doc. Fixed LSH not working (fix from https://github.com/flann-lib/flann/pull/472

* fixing some appveyor CI errors, added test to check dictionary serialization against all type

* Added StereoDense, StereoBM and StereoSGBM doc and tests

* Added Stereo tests

* Added CameraModel and StereoCameraModel tests

* Added doc and test for Statistics

* Added doc/tests for Signature

* Added doc/test for SensorEvent, added doc for SensorCaptureInfo

* Added doc to SensorData

* Added SensorData tests

* Added SensorCapture and SensorCaptureThread doc and tests

* fixed sensordata test

* updated SSC test and doc

* Added doc and tests for BayesFilter class

* Enabled testing on mac, updated windows testing like on linux

* added test_link

* fixed unresolved on windows

* fixed ThreadHandle error on macos ci

* Added GPS and GeodeticCoords tests

* Added tests for compression

* Added Odometry tests (base class only)

* Added DBDriver tests

* Added coverage report

* uniformized test names

* fixing concurancy and coverage ci

* dont built tools, examples and app for coverage build

* fixed report tool rebuilt without qt compilation error

* updated coverage option

* updated coverage config

* added doc CI job

* fixing windows and mac ci errors

* Added DBDriverSqlite3 tests

* Added IMU tests

* Added Graph tests

* fixing flaky macos test

* Added IMUThread and IMUFilter tests

* Added Landmarks tests

* Added LASWriter tests

* fixing seed flaky test

* fixing flaky macos timing tests

* Added LocalGrid tests

* Added LocalGridMaker tests

* fixing ci errors

* Added GlobalMap tests

* Added doc for EnvSensor

* Added Features2D tests

* Added Registration tests

* Added RegistrationVis tests

* Added doc for Rtabmap and Memory classes

* Added Memory and Rtabmap tests

* making some tests less flaky

* lcov 1.14 support

* updated compatible tool arguments

* Added integration tests (RGB-D, Stereo, Lidar2d, Lidar3d)

* More octomap checks

* Refactored how/when python interpretor is created to simplify library usage

* Added python tests

* fixed some flaky tests

* suppressed some third party related warnings

* fixed ceres tests

* more flaky fixes

* Fixing tests without libpointmatcher

* Added RANSAC rejection filter to PCL ICP

* fixing multi platform flakiness

* Added test to detect regression

* Fixing windows pcl link error

* fixed some macos flakiness

* bigger 2D2D registration error on opencv 4.6.0

* flakiness

* fixing flaky tests on windows and mac

* flaky thread test on slow mac VM

* windows slow test

* fixing more ci erros

* fxing temp dir on windows

* Added Optimizer tests and discovered some bugs (fixed)

* fixing flaky tests in mac and windows

* Added Optimizer doc

* Added GTSAM BA, updated Ceres to use g2o ba parameters. Renamed g2o's ba related parameters to Optimizer group and used by both gtsam and ceres.

* fixing build without gtsam

* fixing home dir

* fixing python ci isssues

* Added multicam ba tests

* Added Ceres multicam BA support

* Aligned BundleAdjustment parameters with Optimizer/Strategy to avoid confusion in the code

* Added BA integration test

* Added robust graph optimization integration test

* Added loop3it test

* Added stereo20Hz test

* Added smartfactor gtsam

* Fixed bugged check and warn if python didn't return any descriptors

* Fixing gtsam version build issues

* fixing tilt on windows ci

* loosing ceres integration test for ci

* mac ci flakiness

* updating missing param in gui

* updating test bound for mac

* added appearance-based tests, set min gftt quality to quality level

* testing more stuff

* improving features2d tests

* ci flakiness

* fixing flaky ci

* ci fixes

* flaky fixes

* Added RegistrationIcp tests

* Added icp integration test with real-worl corridor like env

* intermediate nodes

* fixing enum

* Updated test to catch #1714

* Fixed 2d corridor failing on pcl

* flaky pnp test

* flaky brisk test

* Set rtabmap_integration test as long

* updating loop closure test

* flaky ci tests

* TEsting roundtrip g2o/toro save/load

* loosing test bound

* fixed cuda capable checks

* flaky tests

* Debugging test hanging

* more debugging stuff

* updating limit

* windows: disabled cuda on ci to avoid incompatible driver issue. Fixing a bad test mem allocation

* trying fixing cuda hanging issue

* fixing ci flakyness

* flaky tests

* Updated BOW flaky tests by checking min precision/recall instead of recall@100precision. Fixed signature test

* CameraModel::load() test initRectificationMap param

* test dbdriver load dictionary idsOnly

* Memory: test keepLinkedInDb param

* added dummyDictionary tests

* test intermediate nodes count

* Added MarkerDetector tests

* reverted breaking change of UMutex and USemaphore

* Features2d: fixed compiltion warnings with clang about override

* clang warnings

* fixing test build with pcl 1.8

* g2o and gtsam build errors on android

* opencv5 test fixes

* disabled testing for ios and android builds

* normalized endline characters for easier diff

* added LF CRLF rule

* bump 0.23.10. fixing doc version

* Publish rtabmap website doc from ci

* fixing MSCVC build error

* macos icp flaky test

* fixing ceres macos test bound

* ficing more flaky tests

* fixing opencv5 related test errors. Also fixed an actual bug in ENU_WGS84ToGeocentric_WGS84()

* added comment about mrpt change

* removed rosdoc2 (will add it for rtabmap_ros later)

* fixing website style

* updated download links

* locally deployable website with api

* sweep doxygen issues

* improved/revised doxygen main pages

* removed examples empty page

* Updated doxygen style

* more concise doxygen groups

* added api link on main readme

* fixing utilite test error

* fixing CommonFilteringGroundNormalsUp test

* updated precisionRecall test bounds for Freak and brief descriptors

* fixing scale check in ba tests

* disabled tests on windows cuda build (missing dlls amd runner cannot test cuda anyway)

* ceres: missing suitesparse dep in windows ci

* adjusting recall thr for fast/freak

* ficing more flaky tests

* fixing flaky tests

* disabled coverage in ros ci

* Enable integration tests for ros ci jobs

* loosing up some threshold for failing tests

* trigger cache

* fixing test data in ros ci. Updated flaky test for mac

* slaking some test limit

* Fixed rtabmap-detectMoreLoopClosures inverted output value

* loosing up sift recall on mac

* optimizer re-ordered distribution for reproducible results (mac g2o)

* macos dump test crash log

* combining all tests to save time on shared library reload. Also fixed Logs with missing arguments.

* Added ENABLE_FORMAT_ERRORS cmake option

* do test only one time

* fixed all format warnings

* format security android build errors

* less verbose tests

* updated ImuUThread test

* fixed a log

* Fixed libpointmatcher 2d normals eigen issue

* Fixing libpointmatcher conversion issues

* fixing libpointmatcher test on windows ci

* cleanup comments, relax some test thr

* disabled sequoia-intel ci build (too flaky, would need extensive testing directly on that machine)
2026-08-06 13:32:20 -07:00

267 lines
7.8 KiB
C++

#include <gtest/gtest.h>
#include <rtabmap/core/Registration.h>
#include <rtabmap/core/Parameters.h>
#include <opencv2/core.hpp>
using namespace rtabmap;
namespace {
class MockRegistration : public Registration
{
public:
explicit MockRegistration(const ParametersMap & parameters = ParametersMap(), Registration * child = 0) :
Registration(parameters, child)
{
}
mutable int implCallCount = 0;
mutable std::vector<Transform> guessHistory;
Transform resultTransform = Transform::getIdentity();
bool failRegistration = false;
bool imageRequiredFlag = false;
bool scanRequiredFlag = false;
bool userDataRequiredFlag = false;
bool canUseGuessFlag = false;
int minVisualValue = 0;
float minGeometryValue = 0.f;
protected:
Transform computeTransformationImpl(
Signature & /*from*/,
Signature & /*to*/,
Transform guess,
RegistrationInfo & /*info*/) const override
{
++implCallCount;
guessHistory.push_back(guess);
if(failRegistration)
{
return Transform();
}
return resultTransform;
}
bool isImageRequiredImpl() const override { return imageRequiredFlag; }
bool isScanRequiredImpl() const override { return scanRequiredFlag; }
bool isUserDataRequiredImpl() const override { return userDataRequiredFlag; }
bool canUseGuessImpl() const override { return canUseGuessFlag; }
int getMinVisualCorrespondencesImpl() const override { return minVisualValue; }
float getMinGeometryCorrespondencesRatioImpl() const override { return minGeometryValue; }
};
static ParametersMap registrationTestParams()
{
ParametersMap params;
params.insert(ParametersPair(Parameters::kRegRepeatOnce(), "false"));
params.insert(ParametersPair(Parameters::kRegForce3DoF(), "false"));
return params;
}
} // namespace
TEST(RegistrationTest, ConstructorParsesParameters)
{
ParametersMap params;
params[Parameters::kRegRepeatOnce()] = "true";
params[Parameters::kRegForce3DoF()] = "true";
MockRegistration reg(params);
EXPECT_TRUE(reg.repeatOnce());
EXPECT_TRUE(reg.force3DoF());
}
TEST(RegistrationTest, ParseParametersUpdatesFlags)
{
MockRegistration reg(registrationTestParams());
EXPECT_FALSE(reg.repeatOnce());
EXPECT_FALSE(reg.force3DoF());
ParametersMap update;
update[Parameters::kRegRepeatOnce()] = "true";
reg.parseParameters(update);
EXPECT_TRUE(reg.repeatOnce());
EXPECT_FALSE(reg.force3DoF());
}
TEST(RegistrationTest, RequirementFlagsCombineWithChild)
{
MockRegistration * child = new MockRegistration();
child->scanRequiredFlag = true;
MockRegistration parent(registrationTestParams(), child);
EXPECT_FALSE(parent.isImageRequired());
EXPECT_TRUE(parent.isScanRequired());
EXPECT_FALSE(parent.isUserDataRequired());
}
TEST(RegistrationTest, MinCorrespondencesTakeMaximumWithChild)
{
MockRegistration * child = new MockRegistration();
child->minVisualValue = 10;
child->minGeometryValue = 0.5f;
MockRegistration parent(registrationTestParams(), child);
parent.minVisualValue = 5;
parent.minGeometryValue = 0.2f;
EXPECT_EQ(parent.getMinVisualCorrespondences(), 10);
EXPECT_FLOAT_EQ(parent.getMinGeometryCorrespondencesRatio(), 0.5f);
}
TEST(RegistrationTest, CanUseGuessCombinesWithChild)
{
MockRegistration * child = new MockRegistration();
child->canUseGuessFlag = true;
MockRegistration parent(registrationTestParams(), child);
EXPECT_FALSE(parent.canUseGuessFlag);
EXPECT_TRUE(parent.canUseGuess());
}
TEST(RegistrationTest, SetChildRegistrationTakesOwnership)
{
MockRegistration parent(registrationTestParams());
MockRegistration * firstChild = new MockRegistration();
firstChild->minVisualValue = 3;
parent.setChildRegistration(firstChild);
MockRegistration * secondChild = new MockRegistration();
secondChild->minVisualValue = 8;
parent.setChildRegistration(secondChild);
EXPECT_EQ(parent.getMinVisualCorrespondences(), 8);
}
TEST(RegistrationTest, ComputeTransformationCallsImpl)
{
MockRegistration reg(registrationTestParams());
reg.resultTransform = Transform(1.f, 0.f, 0.f, 0.f, 0.f, 0.f);
const Signature from;
const Signature to;
const Transform result = reg.computeTransformation(from, to);
EXPECT_EQ(reg.implCallCount, 1);
EXPECT_FALSE(result.isNull());
EXPECT_NEAR(result.x(), 1.f, 1e-6f);
}
TEST(RegistrationTest, ComputeTransformationChainsChild)
{
MockRegistration * child = new MockRegistration(registrationTestParams());
child->resultTransform = Transform(2.f, 0.f, 0.f, 0.f, 0.f, 0.f);
MockRegistration parent(registrationTestParams(), child);
parent.resultTransform = Transform(1.f, 0.f, 0.f, 0.f, 0.f, 0.f);
const Signature from;
const Signature to;
const Transform result = parent.computeTransformation(from, to);
EXPECT_EQ(parent.implCallCount, 1);
EXPECT_EQ(child->implCallCount, 1);
EXPECT_FALSE(result.isNull());
EXPECT_NEAR(result.x(), 2.f, 1e-6f);
EXPECT_EQ(child->guessHistory.size(), 1u);
EXPECT_NEAR(child->guessHistory[0].x(), 1.f, 1e-6f);
}
TEST(RegistrationTest, ComputeTransformationParentFailsUsesGuessForChild)
{
MockRegistration * child = new MockRegistration(registrationTestParams());
child->resultTransform = Transform(2.f, 0.f, 0.f, 0.f, 0.f, 0.f);
MockRegistration parent(registrationTestParams(), child);
parent.failRegistration = true;
const Signature from;
const Signature to;
const Transform guess(0.5f, 0.f, 0.f, 0.f, 0.f, 0.f);
const Transform result = parent.computeTransformation(from, to, guess);
EXPECT_EQ(parent.implCallCount, 1);
EXPECT_EQ(child->implCallCount, 1);
EXPECT_FALSE(result.isNull());
EXPECT_NEAR(result.x(), 2.f, 1e-6f);
EXPECT_NEAR(child->guessHistory[0].x(), 0.5f, 1e-6f);
}
TEST(RegistrationTest, RepeatOnceRefinesWithFirstResultAsGuess)
{
ParametersMap params = registrationTestParams();
params[Parameters::kRegRepeatOnce()] = "true";
MockRegistration reg(params);
EXPECT_TRUE(reg.repeatOnce());
reg.canUseGuessFlag = true;
reg.resultTransform = Transform(1.f, 0.f, 0.f, 0.f, 0.f, 0.f);
const Signature from;
const Signature to;
Transform nullGuess;
EXPECT_TRUE(nullGuess.isNull());
const Transform result = reg.computeTransformation(from, to, nullGuess);
EXPECT_EQ(reg.implCallCount, 2);
EXPECT_FALSE(result.isNull());
ASSERT_EQ(reg.guessHistory.size(), 2u);
EXPECT_TRUE(reg.guessHistory[0].isNull());
EXPECT_NEAR(reg.guessHistory[1].x(), 1.f, 1e-6f);
}
TEST(RegistrationTest, Force3DoFConstrainsGuessAndResult)
{
ParametersMap params = registrationTestParams();
params[Parameters::kRegForce3DoF()] = "true";
MockRegistration reg(params);
EXPECT_TRUE(reg.force3DoF());
reg.resultTransform = Transform(1.f, 0.f, 2.f, 0.1f, 0.2f, 0.3f);
const Signature from;
const Signature to;
const Transform guess(0.f, 0.f, 5.f, 0.5f, 0.5f, 0.5f);
const Transform result = reg.computeTransformation(from, to, guess);
ASSERT_EQ(reg.guessHistory.size(), 1u);
EXPECT_TRUE(reg.guessHistory[0].is3DoF());
EXPECT_NEAR(reg.guessHistory[0].z(), 0.f, 1e-6f);
EXPECT_TRUE(result.is3DoF());
EXPECT_NEAR(result.z(), 0.f, 1e-6f);
}
TEST(RegistrationTest, CovarianceEpsilonAppliedWhenEmpty)
{
MockRegistration reg(registrationTestParams());
reg.resultTransform = Transform::getIdentity();
const Signature from;
const Signature to;
RegistrationInfo info;
const Transform result = reg.computeTransformation(from, to, Transform::getIdentity(), &info);
EXPECT_FALSE(result.isNull());
ASSERT_FALSE(info.covariance.empty());
EXPECT_EQ(info.covariance.rows, 6);
EXPECT_EQ(info.covariance.cols, 6);
EXPECT_GE(info.covariance.at<double>(0, 0), Registration::COVARIANCE_LINEAR_EPSILON);
EXPECT_GE(info.covariance.at<double>(3, 3), Registration::COVARIANCE_ANGULAR_EPSILON);
EXPECT_GE(info.totalTime, 0.0);
}
TEST(RegistrationTest, ComputeTransformationFromSensorData)
{
MockRegistration reg(registrationTestParams());
reg.resultTransform = Transform(1.f, 0.f, 0.f, 0.f, 0.f, 0.f);
const SensorData from;
const SensorData to;
const Transform result = reg.computeTransformation(from, to);
EXPECT_EQ(reg.implCallCount, 1);
EXPECT_FALSE(result.isNull());
EXPECT_NEAR(result.x(), 1.f, 1e-6f);
}