mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
136 lines
3.6 KiB
TypeScript
136 lines
3.6 KiB
TypeScript
import path from "node:path"
|
|
import { app, BrowserWindow, screen } from "electron"
|
|
|
|
let mainWindow: BrowserWindow | null = null
|
|
|
|
// URL of the app server the main window loads
|
|
let appUrl: string | null = null
|
|
|
|
/**
|
|
* Get the icon path based on platform
|
|
* Note: electron-builder converts icon.png during packaging,
|
|
* but at runtime we use PNG directly - Electron handles it
|
|
*/
|
|
function getIconPath(): string | undefined {
|
|
// macOS doesn't need explicit icon - it's embedded in the app bundle
|
|
if (process.platform === "darwin" && app.isPackaged) {
|
|
return undefined
|
|
}
|
|
|
|
const iconName = "icon.png"
|
|
|
|
if (app.isPackaged) {
|
|
return path.join(process.resourcesPath, iconName)
|
|
}
|
|
|
|
// Development: use icon.png from resources
|
|
return path.join(__dirname, "../../resources/icon.png")
|
|
}
|
|
|
|
/**
|
|
* Create the main application window
|
|
*/
|
|
export function createWindow(serverUrl: string): BrowserWindow {
|
|
appUrl = serverUrl
|
|
const { width, height } = screen.getPrimaryDisplay().workAreaSize
|
|
|
|
mainWindow = new BrowserWindow({
|
|
width: Math.min(1400, Math.floor(width * 0.9)),
|
|
height: Math.min(900, Math.floor(height * 0.9)),
|
|
minWidth: 800,
|
|
minHeight: 600,
|
|
title: "Next AI Draw.io",
|
|
icon: getIconPath(),
|
|
show: false, // Don't show until ready
|
|
webPreferences: {
|
|
preload: path.join(__dirname, "../preload/index.js"),
|
|
contextIsolation: true,
|
|
nodeIntegration: false,
|
|
sandbox: true,
|
|
webSecurity: true,
|
|
},
|
|
})
|
|
|
|
// Load the Next.js application
|
|
mainWindow.loadURL(serverUrl)
|
|
|
|
// Show window when ready to prevent flashing
|
|
mainWindow.once("ready-to-show", () => {
|
|
mainWindow?.show()
|
|
})
|
|
|
|
// Open DevTools in development
|
|
if (!app.isPackaged) {
|
|
mainWindow.webContents.openDevTools()
|
|
}
|
|
|
|
// Override the draw.io iframe's beforeunload handler so the window can
|
|
// close after the user edits text in a shape (fixes #815). Diagrams are
|
|
// already persisted via autosave, so the prompt is unnecessary.
|
|
mainWindow.webContents.on("will-prevent-unload", (event) => {
|
|
event.preventDefault()
|
|
})
|
|
|
|
mainWindow.on("closed", () => {
|
|
mainWindow = null
|
|
})
|
|
|
|
// Handle page title updates
|
|
mainWindow.webContents.on("page-title-updated", (event, title) => {
|
|
if (
|
|
title &&
|
|
!title.includes("localhost") &&
|
|
!title.includes("127.0.0.1")
|
|
) {
|
|
mainWindow?.setTitle(title)
|
|
} else {
|
|
event.preventDefault()
|
|
}
|
|
})
|
|
|
|
return mainWindow
|
|
}
|
|
|
|
/**
|
|
* Get the main window instance
|
|
*/
|
|
export function getMainWindow(): BrowserWindow | null {
|
|
return mainWindow
|
|
}
|
|
|
|
/**
|
|
* Get the app server URL the main window loads
|
|
*/
|
|
export function getAppUrl(): string | null {
|
|
return appUrl
|
|
}
|
|
|
|
/**
|
|
* Point the main window at the restarted app server (it can come up on a
|
|
* different port). On the same port the page is told so it can fetch the
|
|
* server's models again; it is not reloaded, which would drop unsent
|
|
* attachments.
|
|
*/
|
|
export function setAppUrl(url: string): void {
|
|
if (url === appUrl) {
|
|
mainWindow?.webContents.send("server-restarted")
|
|
return
|
|
}
|
|
appUrl = url
|
|
mainWindow?.loadURL(url)
|
|
}
|
|
|
|
/**
|
|
* Check if a URL belongs to the app server (same origin)
|
|
*/
|
|
export function isAppUrl(url: string | undefined): boolean {
|
|
if (!url || !appUrl) {
|
|
return false
|
|
}
|
|
try {
|
|
return new URL(url).origin === new URL(appUrl).origin
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|