mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
210 lines
6.8 KiB
TypeScript
210 lines
6.8 KiB
TypeScript
import { existsSync, readFileSync, writeFileSync } from "node:fs"
|
|
import net from "node:net"
|
|
import path from "node:path"
|
|
import { app } from "electron"
|
|
|
|
/**
|
|
* Port configuration
|
|
* Using fixed ports to preserve localStorage across restarts
|
|
* (localStorage is origin-specific, so changing ports loses all saved data)
|
|
*/
|
|
const PORT_CONFIG = {
|
|
// Legacy production port — tried first to preserve localStorage for existing users
|
|
legacyProduction: 61337,
|
|
// New production port below the ephemeral range (49152-65535)
|
|
// to avoid conflicts with Windows Hyper-V / ephemeral port reservations
|
|
production: 13370,
|
|
// Maximum attempts to find an available port (fallback)
|
|
maxAttempts: 100,
|
|
}
|
|
|
|
/**
|
|
* Currently allocated port (cached after first allocation)
|
|
*/
|
|
let allocatedPort: number | null = null
|
|
|
|
/**
|
|
* Whether chats are saved under http://127.0.0.1:<port>: Electron keeps
|
|
* each origin's IndexedDB in its own folder
|
|
*/
|
|
function hasStoredData(port: number): boolean {
|
|
return existsSync(
|
|
path.join(
|
|
app.getPath("userData"),
|
|
"IndexedDB",
|
|
`http_127.0.0.1_${port}.indexeddb.leveldb`,
|
|
),
|
|
)
|
|
}
|
|
|
|
// The two fixed production ports, the only ones whose origin (and so its
|
|
// chats and settings) is the same at every launch
|
|
const HOME_PORTS = [PORT_CONFIG.legacyProduction, PORT_CONFIG.production]
|
|
|
|
const chatPortFile = () => path.join(app.getPath("userData"), "chat-port.json")
|
|
|
|
/** The fixed port where a chat was last saved, if known */
|
|
function readChatPort(): number | null {
|
|
try {
|
|
const { port } = JSON.parse(readFileSync(chatPortFile(), "utf-8"))
|
|
return HOME_PORTS.includes(port) ? port : null
|
|
} catch {
|
|
return null
|
|
}
|
|
}
|
|
|
|
function writeChatPort(port: number): void {
|
|
try {
|
|
writeFileSync(chatPortFile(), JSON.stringify({ port }))
|
|
} catch (error) {
|
|
console.warn("Could not save the chat port:", error)
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The page saved a chat: open on this port next time. Chats of the two
|
|
* ports cannot be shown together (each origin has its own storage), so the
|
|
* app opens where the user last worked. A launch that had to use the other
|
|
* port and saved nothing does not move it.
|
|
*/
|
|
export function rememberChatPort(): void {
|
|
const port = allocatedPort
|
|
if (!app.isPackaged || port === null || !HOME_PORTS.includes(port)) return
|
|
if (readChatPort() !== port) writeChatPort(port)
|
|
}
|
|
|
|
/**
|
|
* The page loaded without any chats. Before any chat was saved under this
|
|
* version (no file yet), the user's chats may be on the other fixed port,
|
|
* where an older version opened: try it first next time.
|
|
*/
|
|
export function noteNoChats(): void {
|
|
const port = allocatedPort
|
|
if (!app.isPackaged || port === null || !HOME_PORTS.includes(port)) return
|
|
if (existsSync(chatPortFile())) return
|
|
const other = HOME_PORTS.find((p) => p !== port)
|
|
if (other !== undefined && hasStoredData(other)) writeChatPort(other)
|
|
}
|
|
|
|
/**
|
|
* Check if a specific port is available
|
|
*/
|
|
export function isPortAvailable(port: number): Promise<boolean> {
|
|
return new Promise((resolve) => {
|
|
const server = net.createServer()
|
|
server.once("error", (err: NodeJS.ErrnoException) => {
|
|
console.warn(`Port ${port} unavailable: ${err.code}`)
|
|
resolve(false)
|
|
})
|
|
server.once("listening", () => {
|
|
server.close()
|
|
resolve(true)
|
|
})
|
|
server.listen(port, "127.0.0.1")
|
|
})
|
|
}
|
|
|
|
/**
|
|
* Find an available port
|
|
* - Uses the legacy port (61337), then 13370, to preserve localStorage;
|
|
* 13370 first when only it has saved chats
|
|
* - Falls back to sequential ports if preferred port is unavailable
|
|
* - Last resort: lets the OS assign a port (port 0)
|
|
*
|
|
* @param reuseExisting If true, try to reuse the previously allocated port
|
|
* @returns Promise<number> The available port
|
|
*/
|
|
export async function findAvailablePort(reuseExisting = true): Promise<number> {
|
|
const preferredPort = PORT_CONFIG.production
|
|
|
|
// Try to reuse cached port if requested and available
|
|
if (reuseExisting && allocatedPort !== null) {
|
|
const available = await isPortAvailable(allocatedPort)
|
|
if (available) {
|
|
return allocatedPort
|
|
}
|
|
console.warn(
|
|
`Previously allocated port ${allocatedPort} is no longer available`,
|
|
)
|
|
allocatedPort = null
|
|
}
|
|
|
|
// First the port where a chat was last saved. Without one, the legacy
|
|
// port first to preserve existing users' data, unless only the new port
|
|
// has data: their app started on 13370 while Windows reserved 61337,
|
|
// and 61337 being free now would hide it
|
|
const chatPort = readChatPort()
|
|
const candidates =
|
|
chatPort !== null
|
|
? [chatPort, ...HOME_PORTS.filter((p) => p !== chatPort)]
|
|
: hasStoredData(PORT_CONFIG.production) &&
|
|
!hasStoredData(PORT_CONFIG.legacyProduction)
|
|
? [PORT_CONFIG.production, PORT_CONFIG.legacyProduction]
|
|
: [PORT_CONFIG.legacyProduction, PORT_CONFIG.production]
|
|
for (const port of candidates) {
|
|
if (await isPortAvailable(port)) {
|
|
allocatedPort = port
|
|
return port
|
|
}
|
|
}
|
|
|
|
console.warn(
|
|
`Preferred port ${preferredPort} is in use, finding alternative...`,
|
|
)
|
|
|
|
// Fallback: try sequential ports starting from preferred + 1
|
|
for (let attempt = 1; attempt <= PORT_CONFIG.maxAttempts; attempt++) {
|
|
const port = preferredPort + attempt
|
|
if (await isPortAvailable(port)) {
|
|
allocatedPort = port
|
|
console.log(`Allocated fallback port: ${port}`)
|
|
return port
|
|
}
|
|
}
|
|
|
|
// Last resort: let the OS pick an available port
|
|
console.warn(
|
|
"All sequential ports failed. Requesting OS-assigned port (localStorage may not persist across restarts).",
|
|
)
|
|
const osPort = await new Promise<number>((resolve, reject) => {
|
|
const server = net.createServer()
|
|
server.once("error", reject)
|
|
server.once("listening", () => {
|
|
const addr = server.address()
|
|
const port = (addr as net.AddressInfo).port
|
|
server.close(() => resolve(port))
|
|
})
|
|
server.listen(0, "127.0.0.1")
|
|
})
|
|
allocatedPort = osPort
|
|
console.log(`OS assigned port: ${osPort}`)
|
|
return osPort
|
|
}
|
|
|
|
/**
|
|
* Get the currently allocated port
|
|
* Returns null if no port has been allocated yet
|
|
*/
|
|
export function getAllocatedPort(): number | null {
|
|
return allocatedPort
|
|
}
|
|
|
|
/**
|
|
* Reset the allocated port (useful for testing or restart scenarios)
|
|
*/
|
|
export function resetAllocatedPort(): void {
|
|
allocatedPort = null
|
|
}
|
|
|
|
/**
|
|
* Get the server URL with the allocated port
|
|
*/
|
|
export function getServerUrl(): string {
|
|
if (allocatedPort === null) {
|
|
throw new Error(
|
|
"No port allocated yet. Call findAvailablePort() first.",
|
|
)
|
|
}
|
|
return `http://127.0.0.1:${allocatedPort}`
|
|
}
|