mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
208 lines
8.0 KiB
TypeScript
208 lines
8.0 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
|
|
import { isPrivateUrl, redirectGuardedFetch } from "@/lib/ssrf-protection"
|
|
|
|
// Mock DNS so tests are deterministic and never hit the network.
|
|
const lookupMock = vi.hoisted(() => vi.fn())
|
|
vi.mock("node:dns/promises", () => ({
|
|
default: { lookup: lookupMock },
|
|
lookup: lookupMock,
|
|
}))
|
|
|
|
describe("isPrivateUrl", () => {
|
|
beforeEach(() => {
|
|
lookupMock.mockReset()
|
|
})
|
|
|
|
it("blocks private IPv6 URLs (string-only fast path, no DNS)", async () => {
|
|
expect(await isPrivateUrl("http://[::1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[0:0:0:0:0:0:0:1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[::]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[::ffff:127.0.0.1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[fc00::1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[fd12:3456:789a::1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[fe80::1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[fe9f::1]/")).toBe(true)
|
|
expect(await isPrivateUrl("http://[febf::1]/")).toBe(true)
|
|
expect(lookupMock).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it("blocks literal private IPv4 without DNS", async () => {
|
|
expect(await isPrivateUrl("http://127.0.0.1/")).toBe(true)
|
|
expect(await isPrivateUrl("http://10.0.0.5/")).toBe(true)
|
|
expect(await isPrivateUrl("http://192.168.1.1/")).toBe(true)
|
|
expect(await isPrivateUrl("http://169.254.169.254/")).toBe(true)
|
|
expect(await isPrivateUrl("http://0.0.0.0/")).toBe(true)
|
|
// 100.64.0.0/10 CGNAT (RFC 6598), routable in some cloud internal nets
|
|
expect(await isPrivateUrl("http://100.64.0.1/")).toBe(true)
|
|
expect(await isPrivateUrl("http://100.127.255.255/")).toBe(true)
|
|
expect(lookupMock).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it("treats CGNAT boundaries correctly", async () => {
|
|
// 100.63.x and 100.128.x are outside 100.64.0.0/10 → public
|
|
lookupMock.mockResolvedValue([{ address: "100.63.255.255", family: 4 }])
|
|
expect(await isPrivateUrl("http://just-below.example/")).toBe(false)
|
|
lookupMock.mockResolvedValue([{ address: "100.128.0.1", family: 4 }])
|
|
expect(await isPrivateUrl("http://just-above.example/")).toBe(false)
|
|
})
|
|
|
|
it("blocks a hostname that resolves to a private IPv6 address", async () => {
|
|
lookupMock.mockResolvedValue([{ address: "fd00::1", family: 6 }])
|
|
expect(await isPrivateUrl("http://v6.example.com/")).toBe(true)
|
|
})
|
|
|
|
it("allows public URLs that resolve to public IPs", async () => {
|
|
lookupMock.mockResolvedValue([{ address: "93.184.216.34", family: 4 }])
|
|
expect(await isPrivateUrl("https://example.com/article")).toBe(false)
|
|
})
|
|
|
|
it("blocks public-looking hostnames that resolve to a private IP (DNS-rebinding-style bypass)", async () => {
|
|
// e.g. 127-0-0-1.sslip.io resolves to 127.0.0.1
|
|
lookupMock.mockResolvedValue([{ address: "127.0.0.1", family: 4 }])
|
|
expect(await isPrivateUrl("http://127-0-0-1.sslip.io/")).toBe(true)
|
|
})
|
|
|
|
it("blocks when any resolved address is private", async () => {
|
|
lookupMock.mockResolvedValue([
|
|
{ address: "93.184.216.34", family: 4 },
|
|
{ address: "10.1.2.3", family: 4 },
|
|
])
|
|
expect(await isPrivateUrl("http://mixed.example.com/")).toBe(true)
|
|
})
|
|
|
|
it("blocks when DNS resolution fails", async () => {
|
|
lookupMock.mockRejectedValue(new Error("ENOTFOUND"))
|
|
expect(await isPrivateUrl("http://does-not-resolve.example/")).toBe(
|
|
true,
|
|
)
|
|
})
|
|
})
|
|
|
|
describe("redirectGuardedFetch with the quota on", () => {
|
|
const answers = (map: Record<string, Response>) =>
|
|
vi.fn(
|
|
async (url: string) =>
|
|
map[String(url)] ?? new Response("?", { status: 404 }),
|
|
)
|
|
|
|
beforeEach(() => {
|
|
lookupMock.mockReset()
|
|
// Hosts ending in .example are public
|
|
lookupMock.mockImplementation(async (host: string) =>
|
|
host.endsWith(".example")
|
|
? [{ address: "93.184.216.34", family: 4 }]
|
|
: [],
|
|
)
|
|
vi.stubEnv("DYNAMODB_QUOTA_TABLE", "quota")
|
|
vi.stubEnv("ALLOW_PRIVATE_URLS", undefined)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals()
|
|
})
|
|
|
|
it("follows a redirect to a public address", async () => {
|
|
// A user's own proxy that moves http to https
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
answers({
|
|
"http://proxy.example/v1/chat": new Response(null, {
|
|
status: 308,
|
|
headers: { location: "https://proxy.example/v1/chat" },
|
|
}),
|
|
"https://proxy.example/v1/chat": new Response("ok"),
|
|
}),
|
|
)
|
|
const guarded = redirectGuardedFetch()
|
|
expect(guarded).toBeDefined()
|
|
const res = await guarded?.("http://proxy.example/v1/chat", {
|
|
method: "POST",
|
|
body: "{}",
|
|
})
|
|
expect(await res?.text()).toBe("ok")
|
|
})
|
|
|
|
it("refuses a redirect to the server's own network", async () => {
|
|
// It would be counted as a public endpoint while using the server's
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
answers({
|
|
"https://public.example/api/chat": new Response(null, {
|
|
status: 307,
|
|
headers: { location: "http://127.0.0.1:11434/api/chat" },
|
|
}),
|
|
}),
|
|
)
|
|
await expect(
|
|
redirectGuardedFetch()?.("https://public.example/api/chat", {
|
|
method: "POST",
|
|
body: "{}",
|
|
}),
|
|
).rejects.toThrow(/private addresses/)
|
|
expect(fetch).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it("follows a private address's redirect to another one", async () => {
|
|
// Counted as the server's from the start
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
answers({
|
|
"http://10.0.0.5:4000/v1/chat": new Response(null, {
|
|
status: 307,
|
|
headers: { location: "http://10.0.0.6:4000/v1/chat" },
|
|
}),
|
|
"http://10.0.0.6:4000/v1/chat": new Response("ok"),
|
|
}),
|
|
)
|
|
const res = await redirectGuardedFetch()?.(
|
|
"http://10.0.0.5:4000/v1/chat",
|
|
{ method: "POST", body: "{}" },
|
|
)
|
|
expect(await res?.text()).toBe("ok")
|
|
})
|
|
|
|
it("sends no credentials to another origin", async () => {
|
|
const fetchMock = answers({
|
|
"https://proxy.example/v1/chat": new Response(null, {
|
|
status: 307,
|
|
headers: { location: "https://other.example/v1/chat" },
|
|
}),
|
|
"https://other.example/v1/chat": new Response("ok"),
|
|
})
|
|
vi.stubGlobal("fetch", fetchMock)
|
|
await redirectGuardedFetch()?.("https://proxy.example/v1/chat", {
|
|
method: "POST",
|
|
body: "{}",
|
|
headers: {
|
|
Authorization: "Bearer user-key",
|
|
Cookie: "eo_token=1",
|
|
"x-api-key": "anthropic-key",
|
|
"x-goog-api-key": "google-key",
|
|
"api-key": "azure-key",
|
|
"Content-Type": "application/json",
|
|
},
|
|
})
|
|
const sent = (call: number) =>
|
|
new Headers(
|
|
(
|
|
fetchMock.mock.calls[call] as unknown as [
|
|
string,
|
|
RequestInit,
|
|
]
|
|
)[1].headers,
|
|
)
|
|
expect(sent(0).get("authorization")).toBe("Bearer user-key")
|
|
expect(sent(1).get("authorization")).toBeNull()
|
|
expect(sent(1).get("cookie")).toBeNull()
|
|
for (const name of ["x-api-key", "x-goog-api-key", "api-key"]) {
|
|
expect(sent(1).get(name)).toBeNull()
|
|
}
|
|
expect(sent(1).get("content-type")).toBe("application/json")
|
|
})
|
|
|
|
it("is not used without the quota", () => {
|
|
vi.stubEnv("DYNAMODB_QUOTA_TABLE", undefined)
|
|
expect(redirectGuardedFetch()).toBeUndefined()
|
|
})
|
|
})
|