Files
next-ai-draw-io/stores/versions-store.ts
T
Dayuan Jiang 60105ddb51 refactor: remove dead code and over-engineering found by two audits (#986)
## Problem

Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.

## Change

Every item below was either approved one by one or covered by "fix all of the others".

- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.

Source lines: 74,983 before, 67,418 after (excluding lockfiles).

The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).

## Testing

- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
2026-10-12 12:35:55 +09:00

133 lines
4.9 KiB
TypeScript

import { nanoid } from "nanoid"
import { create } from "zustand"
import type { VersionItem } from "@/components/canvas/versions-context"
/**
* One diagram state produced by an AI change, shown as a card in the chat.
* What the card displays is the VersionItem part; the rest ties the version
* to its chat turn. The number stays when older versions are dropped; the
* "before" document is kept only on the latest version; older sessions
* have no pageId (the first page).
*/
export interface DiagramVersion extends VersionItem {
/** Index of the user message that started this turn */
turnIndex: number
toolCallId?: string
/** Saved with the session: this version is what the canvas shows */
onCanvas?: boolean
/** Saved with the session: this version's change was undone */
undone?: boolean
}
// The two flags live on the versions so they are saved with the session
function withFlags(
versions: DiagramVersion[],
onCanvasId: string | null,
undoneId: string | null,
): DiagramVersion[] {
return versions.map(({ onCanvas, undone, ...rest }) => ({
...rest,
...(rest.id === onCanvasId && { onCanvas: true }),
...(rest.id === undoneId && { undone: true }),
}))
}
// Versions are stored with the session; keep the list bounded
export const MAX_VERSIONS = 20
interface VersionsState {
versions: DiagramVersion[]
/** The change on the latest version was undone with its card's button */
undoneVersionId: string | null
/** The version the canvas shows (null after an undo or hand edits) */
onCanvasVersionId: string | null
setVersions: (versions: DiagramVersion[]) => void
addVersion: (version: Omit<DiagramVersion, "id" | "number">) => string
updateVersion: (id: string, patch: Partial<DiagramVersion>) => void
/** Drop versions from turns that are being re-run (edit or regenerate) */
removeFromTurn: (turnIndex: number) => void
/** The change of this version was undone; null: no undone change */
setUndone: (id: string | null) => void
/** This version is on the canvas again (restored or redone) */
setOnCanvas: (id: string) => void
/** The canvas was changed by hand (undo included): no version is on it */
clearCanvasFlags: () => void
clear: () => void
}
export const useVersionsStore = create<VersionsState>((set) => ({
versions: [],
undoneVersionId: null,
onCanvasVersionId: null,
setVersions: (versions) =>
set({
// A missing thumbnail could not be made: no "rendering" forever.
versions: versions.map((v) => ({
...v,
svg: v.svg ?? "",
})),
undoneVersionId: versions.find((v) => v.undone)?.id ?? null,
onCanvasVersionId: versions.find((v) => v.onCanvas)?.id ?? null,
}),
addVersion: (version) => {
const id = nanoid(10)
set((state) => {
// Only the newest version keeps its "before" XML
const older = state.versions.map(({ beforeXml, ...rest }) => rest)
const number = (state.versions.at(-1)?.number ?? 0) + 1
const next = [...older, { ...version, id, number }].slice(
-MAX_VERSIONS,
)
return {
versions: withFlags(next, id, null),
undoneVersionId: null,
onCanvasVersionId: id,
}
})
return id
},
updateVersion: (id, patch) =>
set((state) => ({
versions: state.versions.map((v) =>
v.id === id ? { ...v, ...patch } : v,
),
})),
removeFromTurn: (turnIndex) =>
set((state) => {
const versions = state.versions.filter(
(v) => v.turnIndex < turnIndex,
)
// The canvas goes back to the snapshot before that turn, which
// can hold hand edits made after the latest kept version
return {
versions: withFlags(versions, null, null),
undoneVersionId: null,
onCanvasVersionId: null,
}
}),
setUndone: (id) =>
set((state) => ({
versions: withFlags(state.versions, null, id),
undoneVersionId: id,
onCanvasVersionId: null,
})),
setOnCanvas: (id) =>
set((state) => ({
versions: withFlags(state.versions, id, null),
undoneVersionId: null,
onCanvasVersionId: id,
})),
clearCanvasFlags: () =>
set((state) =>
state.onCanvasVersionId === null && state.undoneVersionId === null
? state
: {
versions: withFlags(state.versions, null, null),
undoneVersionId: null,
onCanvasVersionId: null,
},
),
clear: () =>
set({ versions: [], undoneVersionId: null, onCanvasVersionId: null }),
}))