mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
138 lines
5.6 KiB
TypeScript
138 lines
5.6 KiB
TypeScript
/**
|
|
* The web app runs the MCP server's diagram modules in the browser, where
|
|
* DOMParser and XMLSerializer are the native ones (jsdom here), not the
|
|
* linkedom polyfill the MCP tests use.
|
|
*/
|
|
import { deflateRaw } from "pako"
|
|
import { describe, expect, it } from "vitest"
|
|
import { applyDiagramOperations } from "@/packages/mcp-server/src/diagram-operations.ts"
|
|
import { editDiagram } from "@/packages/mcp-server/src/edit-diagram.ts"
|
|
import { decompressPageContent } from "@/packages/mcp-server/src/load-diagram.ts"
|
|
import {
|
|
hasCells,
|
|
normalizeToMxfile,
|
|
wrapCellsInModel,
|
|
} from "@/packages/mcp-server/src/pages.ts"
|
|
import { getXmlSyntaxError } from "@/packages/mcp-server/src/xml-syntax.ts"
|
|
import { validateAndFixXml } from "@/packages/mcp-server/src/xml-validation.ts"
|
|
|
|
const box = (id: string, parent = "1") =>
|
|
`<mxCell id="${id}" value="${id}" vertex="1" parent="${parent}"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
const edge = (id: string, source: string, target: string) =>
|
|
`<mxCell id="${id}" edge="1" parent="1" source="${source}" target="${target}"><mxGeometry relative="1" as="geometry"/></mxCell>`
|
|
const file = (cells: string) =>
|
|
normalizeToMxfile(wrapCellsInModel(cells), {
|
|
pageId: "p1",
|
|
pageName: "Page-1",
|
|
}) as string
|
|
|
|
describe("MCP diagram modules with a browser DOM", () => {
|
|
it("wraps bare cells into a valid file", () => {
|
|
const xml = file(box("a") + box("b"))
|
|
expect(xml).toContain('<diagram id="p1" name="Page-1">')
|
|
expect(validateAndFixXml(xml).valid).toBe(true)
|
|
expect(hasCells(xml)).toBe(true)
|
|
expect(hasCells(file(""))).toBe(false)
|
|
})
|
|
|
|
it("fixes the case of a misspelled tag in model XML", () => {
|
|
const result = validateAndFixXml(
|
|
file(box("a"))
|
|
.replace('<mxCell id="a"', '<mxcell id="a"')
|
|
.replace("</mxCell></root>", "</mxcell></root>"),
|
|
)
|
|
expect(result.valid).toBe(true)
|
|
expect(result.fixes.join(" ")).toMatch(/tag case/)
|
|
})
|
|
|
|
it("reports syntax errors with line and column", () => {
|
|
expect(getXmlSyntaxError("<mxfile><diagram></mxfile>")).toMatch(
|
|
/^1:\d+/,
|
|
)
|
|
expect(getXmlSyntaxError(file(box("a")))).toBeNull()
|
|
})
|
|
|
|
it("deletes a cell with its edges", () => {
|
|
const xml = file(box("a") + box("b") + edge("e", "a", "b"))
|
|
const { result, errors } = applyDiagramOperations(xml, [
|
|
{ operation: "delete", cell_id: "a" },
|
|
])
|
|
expect(errors).toEqual([])
|
|
expect(result).not.toContain('id="a"')
|
|
expect(result).not.toContain('id="e"')
|
|
expect(result).toContain('id="b"')
|
|
})
|
|
|
|
it("runs a whole edit and serializes the target page", () => {
|
|
const outcome = editDiagram(
|
|
file(box("a")),
|
|
[{ operation: "add", cell_id: "b", new_xml: box("b") }],
|
|
{},
|
|
)
|
|
expect(outcome.ok).toBe(true)
|
|
if (outcome.ok) expect(outcome.xml).toContain('id="b"')
|
|
|
|
const failed = editDiagram(
|
|
file(box("a")),
|
|
[{ operation: "add", cell_id: "b", new_xml: box("b") + box("c") }],
|
|
{},
|
|
)
|
|
expect(failed.ok).toBe(false)
|
|
})
|
|
|
|
it("decompresses a draw.io compressed page", () => {
|
|
const model = wrapCellsInModel(box("a"))
|
|
const deflated = deflateRaw(encodeURIComponent(model))
|
|
const base64 = btoa(String.fromCharCode(...deflated))
|
|
expect(decompressPageContent(base64)).toBe(model)
|
|
expect(decompressPageContent("not compressed")).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe("edit_diagram on one page of a multi-page file", () => {
|
|
// Page A has an edge "g"; on page B, "g" is a shape on layer "L"
|
|
const twoPages = `<mxfile><diagram id="pa" name="A"><mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/>${box("s")}${box("t")}<mxCell id="g" edge="1" parent="1" source="s" target="t"><mxGeometry relative="1" as="geometry"/></mxCell></root></mxGraphModel></diagram><diagram id="pb" name="B"><mxGraphModel><root><mxCell id="0"/><mxCell id="L" parent="0"/>${box("g", "L")}</root></mxGraphModel></diagram></mxfile>`
|
|
const cellOn = (xml: string, pageId: string, id: string) =>
|
|
new DOMParser()
|
|
.parseFromString(xml, "text/xml")
|
|
.querySelector(`diagram[id="${pageId}"] mxCell[id="${id}"]`)
|
|
|
|
it("puts a compact cell without a parent on that page's layer", () => {
|
|
const outcome = editDiagram(
|
|
twoPages,
|
|
[
|
|
{
|
|
operation: "add",
|
|
cell_id: "c",
|
|
new_xml:
|
|
'<mxCell id="c" value="c" x="10" y="10" w="80" h="40"/>',
|
|
},
|
|
],
|
|
{ page_id: "pb" },
|
|
)
|
|
if (!outcome.ok) throw new Error(outcome.errors.join("; "))
|
|
expect(cellOn(outcome.xml, "pb", "c")?.getAttribute("parent")).toBe("L")
|
|
expect(cellOn(outcome.xml, "pa", "c")).toBeNull()
|
|
})
|
|
|
|
it("reads the edges of that page only", () => {
|
|
// A shape inside the group "g" is no edge label on page B
|
|
const outcome = editDiagram(
|
|
twoPages,
|
|
[
|
|
{
|
|
operation: "add",
|
|
cell_id: "c",
|
|
new_xml:
|
|
'<mxCell id="c" value="c" parent="g" x="10" y="10" w="80" h="40"/>',
|
|
},
|
|
],
|
|
{ page_id: "pb" },
|
|
)
|
|
if (!outcome.ok) throw new Error(outcome.errors.join("; "))
|
|
expect(cellOn(outcome.xml, "pb", "c")?.getAttribute("style")).toContain(
|
|
"whiteSpace=wrap",
|
|
)
|
|
})
|
|
})
|