mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-12 20:49:53 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
119 lines
3.6 KiB
TypeScript
119 lines
3.6 KiB
TypeScript
// @vitest-environment node
|
|
import { MockLanguageModelV3 } from "ai/test"
|
|
import { afterEach, describe, expect, it, vi } from "vitest"
|
|
import { POST as validateDiagram } from "@/app/api/validate-diagram/route"
|
|
|
|
const RESULT = {
|
|
valid: false,
|
|
issues: [
|
|
{
|
|
type: "overlap",
|
|
severity: "critical",
|
|
description: "Box A covers box B",
|
|
},
|
|
],
|
|
suggestions: ["Move box B to the right"],
|
|
}
|
|
|
|
// A vision model that answers with the result as JSON text
|
|
vi.mock("@/lib/ai-providers", () => ({
|
|
getValidationModel: () =>
|
|
new MockLanguageModelV3({
|
|
doGenerate: (async () => ({
|
|
content: [{ type: "text", text: JSON.stringify(RESULT) }],
|
|
finishReason: { unified: "stop", raw: "stop" },
|
|
usage: {
|
|
inputTokens: { total: 1 },
|
|
outputTokens: { total: 1 },
|
|
},
|
|
warnings: [],
|
|
})) as any,
|
|
}),
|
|
}))
|
|
|
|
// The quota, off unless a test turns it on
|
|
const quota = vi.hoisted(() => ({
|
|
enabled: false,
|
|
allowed: true,
|
|
checks: [] as Array<{ limits: any; increment?: number }>,
|
|
recorded: [] as number[],
|
|
}))
|
|
vi.mock("@/lib/dynamo-quota-manager", () => ({
|
|
isQuotaEnabled: () => quota.enabled,
|
|
checkAndIncrementRequest: async (
|
|
_ip: string,
|
|
limits: unknown,
|
|
increment?: number,
|
|
) => {
|
|
quota.checks.push({ limits, increment })
|
|
return quota.allowed
|
|
? { allowed: true }
|
|
: {
|
|
allowed: false,
|
|
type: "token",
|
|
error: "Daily token limit exceeded",
|
|
used: 10,
|
|
limit: 10,
|
|
}
|
|
},
|
|
recordTokenUsage: async (_ip: string, tokens: number) => {
|
|
quota.recorded.push(tokens)
|
|
},
|
|
}))
|
|
|
|
const post = () =>
|
|
new Request("http://localhost/api/validate-diagram", {
|
|
method: "POST",
|
|
headers: {
|
|
"Content-Type": "application/json",
|
|
"x-forwarded-for": "203.0.113.7",
|
|
},
|
|
body: JSON.stringify({ imageData: "data:image/png;base64,AAAA" }),
|
|
})
|
|
|
|
afterEach(() => {
|
|
quota.enabled = false
|
|
quota.allowed = true
|
|
quota.checks = []
|
|
quota.recorded = []
|
|
})
|
|
|
|
describe("the quota", () => {
|
|
it("refuses a check once the daily tokens are used up", async () => {
|
|
quota.enabled = true
|
|
quota.allowed = false
|
|
const res = await validateDiagram(post())
|
|
expect(res.status).toBe(429)
|
|
})
|
|
|
|
it("applies the token limits only, and records the tokens", async () => {
|
|
// The request limit is for chats: the day's last chat must still
|
|
// get its check, and the check does not count as a chat
|
|
quota.enabled = true
|
|
const res = await validateDiagram(post())
|
|
expect(await res.json()).toEqual(RESULT)
|
|
expect(quota.checks).toHaveLength(1)
|
|
expect(quota.checks[0].increment).toBe(0)
|
|
expect(quota.checks[0].limits.requests).toBe(0)
|
|
expect(quota.recorded).toEqual([2])
|
|
})
|
|
})
|
|
|
|
describe("POST /api/validate-diagram", () => {
|
|
it("answers the model's result as JSON", async () => {
|
|
const res = await validateDiagram(post())
|
|
expect(res.headers.get("content-type")).toContain("application/json")
|
|
expect(await res.json()).toEqual(RESULT)
|
|
})
|
|
|
|
it("answers valid when the check is turned off", async () => {
|
|
vi.stubEnv("ENABLE_VLM_VALIDATION", "false")
|
|
const res = await validateDiagram(post())
|
|
expect(await res.json()).toEqual({
|
|
valid: true,
|
|
issues: [],
|
|
suggestions: [],
|
|
})
|
|
})
|
|
})
|