mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
116 lines
4.5 KiB
TypeScript
116 lines
4.5 KiB
TypeScript
import { deflateRawSync } from "node:zlib"
|
|
import { act, renderHook } from "@testing-library/react"
|
|
import type React from "react"
|
|
import { afterEach, describe, expect, it, vi } from "vitest"
|
|
import { DiagramProvider, useDiagram } from "@/contexts/diagram-context"
|
|
|
|
vi.mock("sonner", () => ({ toast: { success: vi.fn() } }))
|
|
|
|
// The provider with a stand-in draw.io that records each export request
|
|
function setup() {
|
|
const { result } = renderHook(() => useDiagram(), {
|
|
wrapper: ({ children }: { children: React.ReactNode }) => (
|
|
<DiagramProvider>{children}</DiagramProvider>
|
|
),
|
|
})
|
|
const requests: { format: string; message: string }[] = []
|
|
result.current.drawioRef.current = {
|
|
exportDiagram: (r: any) => requests.push(r),
|
|
load: vi.fn(),
|
|
} as any
|
|
// draw.io's reply to a request: it echoes the request in `message`.
|
|
// Async, so what the caller does with the result runs before it returns
|
|
const reply = (request: { message: string }, data: string, xml = "") =>
|
|
act(async () => {
|
|
result.current.handleDiagramExport({
|
|
event: "export",
|
|
data,
|
|
xml,
|
|
format: "xmlsvg",
|
|
message: request,
|
|
} as any)
|
|
})
|
|
return { result, requests, reply }
|
|
}
|
|
|
|
// An editable SVG as draw.io exports it: the diagram, compressed, in its
|
|
// content attribute
|
|
const svgOf = (label: string) => {
|
|
const model = `<mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/><mxCell id="2" value="${label}" vertex="1" parent="1"/></root></mxGraphModel>`
|
|
const packed = deflateRawSync(
|
|
Buffer.from(encodeURIComponent(model)),
|
|
).toString("base64")
|
|
const content = `<mxfile><diagram id="p">${packed}</diagram></mxfile>`
|
|
.replaceAll("&", "&")
|
|
.replaceAll("<", "<")
|
|
.replaceAll(">", ">")
|
|
.replaceAll('"', """)
|
|
const svg = `<svg xmlns="http://www.w3.org/2000/svg" content="${content}"></svg>`
|
|
return `data:image/svg+xml;base64,${btoa(svg)}`
|
|
}
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
describe("exports in flight at the same time", () => {
|
|
it("give the chat's export only its own reply", async () => {
|
|
const { result, requests, reply } = setup()
|
|
// An edit's history export is still on its way when the chat exports
|
|
const older = result.current.fetchDiagramXml()
|
|
const current = result.current.fetchDiagramXml()
|
|
let currentDone = false
|
|
current.then(() => {
|
|
currentDone = true
|
|
})
|
|
await reply(requests[0], svgOf("older"))
|
|
expect(await older).toContain('value="older"')
|
|
expect(currentDone).toBe(false)
|
|
await reply(requests[1], svgOf("current"))
|
|
expect(await current).toContain('value="current"')
|
|
})
|
|
|
|
it("save each file with its own result", async () => {
|
|
const { result, requests, reply } = setup()
|
|
const saved: { name: string; href: string }[] = []
|
|
vi.spyOn(HTMLAnchorElement.prototype, "click").mockImplementation(
|
|
function (this: HTMLAnchorElement) {
|
|
saved.push({ name: this.download, href: this.href })
|
|
},
|
|
)
|
|
const blobs = new Map<string, Blob>()
|
|
URL.createObjectURL = vi.fn((blob: Blob) => {
|
|
const url = `blob:test-${blobs.size}`
|
|
blobs.set(url, blob)
|
|
return url
|
|
})
|
|
URL.revokeObjectURL = vi.fn()
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
vi.fn(async () => new Response("{}")),
|
|
)
|
|
|
|
const twoPages =
|
|
'<mxfile><diagram id="a" name="A"><mxGraphModel><root/></mxGraphModel></diagram><diagram id="b" name="B"><mxGraphModel><root/></mxGraphModel></diagram></mxfile>'
|
|
act(() => {
|
|
result.current.saveDiagramToFile("doc", "drawio")
|
|
result.current.saveDiagramToFile("pic", "png")
|
|
})
|
|
// The PNG answers first
|
|
await reply(requests[1], "data:image/png;base64,iVBORw0KGgo=")
|
|
await reply(requests[0], svgOf("doc"), twoPages)
|
|
|
|
expect(saved.map((s) => s.name)).toEqual(["pic.png", "doc.drawio"])
|
|
expect(saved[0].href).toMatch(/^data:image\/png/)
|
|
const file = blobs.get(saved[1].href)
|
|
const text = await new Promise<string>((resolve) => {
|
|
const reader = new FileReader()
|
|
reader.onload = () => resolve(String(reader.result))
|
|
reader.readAsText(file as Blob)
|
|
})
|
|
expect(text).toContain('name="A"')
|
|
expect(text).toContain('name="B"')
|
|
vi.unstubAllGlobals()
|
|
})
|
|
})
|