mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-12 20:49:53 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
196 lines
6.7 KiB
TypeScript
196 lines
6.7 KiB
TypeScript
import {
|
|
APICallError,
|
|
InvalidToolInputError,
|
|
LoadAPIKeyError,
|
|
NoSuchToolError,
|
|
RetryError,
|
|
ToolCallRepairError,
|
|
} from "ai"
|
|
|
|
/**
|
|
* What went wrong with a model call, for a hint the user can act on. The
|
|
* provider's own message always goes along, because a guess can be wrong.
|
|
*/
|
|
type LLMErrorCode =
|
|
| "invalid_api_key"
|
|
| "forbidden"
|
|
| "model_not_found"
|
|
| "insufficient_quota"
|
|
| "rate_limited"
|
|
| "context_too_long"
|
|
| "images_unsupported"
|
|
| "tools_unsupported"
|
|
| "output_truncated"
|
|
| "provider_unavailable"
|
|
| "cannot_connect"
|
|
| "timeout"
|
|
// A 403 on the server's own key, e.g. a daily spend cap blocked it
|
|
| "server_key_forbidden"
|
|
| "unknown"
|
|
|
|
interface LLMError {
|
|
type: "provider"
|
|
code: LLMErrorCode
|
|
message: string
|
|
}
|
|
|
|
// Texts that name the cause more precisely than the status code: a quota
|
|
// error can come as 403 or 429, a context or image error as a plain 400
|
|
const SPECIFIC_TEXTS: Array<[RegExp, LLMErrorCode]> = [
|
|
[
|
|
// Not "too many tokens": that is Bedrock's throttling message
|
|
/context length|context window|maximum context|prompt is too long|input is too long|too many input tokens/i,
|
|
"context_too_long",
|
|
],
|
|
[
|
|
/image content block|image_url|does not support image|image input is not supported/i,
|
|
"images_unsupported",
|
|
],
|
|
[
|
|
/does not support tools|tool use is not supported|tools? (?:are|is) not supported|function calling is not supported/i,
|
|
"tools_unsupported",
|
|
],
|
|
// Bedrock, when the output limit cut the tool call's JSON short
|
|
[/toolUse\.input is invalid/i, "output_truncated"],
|
|
// Bedrock, for a model id without the inference profile prefix
|
|
[/on-demand throughput isn.t supported/i, "model_not_found"],
|
|
[
|
|
/insufficient[_ ]quota|insufficient balance|exceeded your current quota|credit balance is too low|余额不足/i,
|
|
"insufficient_quota",
|
|
],
|
|
]
|
|
|
|
const STATUS_CODES: Record<number, LLMErrorCode> = {
|
|
401: "invalid_api_key",
|
|
402: "insufficient_quota",
|
|
// Not "invalid key": a valid key can lack access to a model or region
|
|
403: "forbidden",
|
|
404: "model_not_found",
|
|
408: "timeout",
|
|
// A retired model
|
|
410: "model_not_found",
|
|
413: "context_too_long",
|
|
429: "rate_limited",
|
|
}
|
|
|
|
const GENERAL_TEXTS: Array<[RegExp, LLMErrorCode]> = [
|
|
[
|
|
/model[_ ]not[_ ]found|model .*does not exist|unknown model|no such model/i,
|
|
"model_not_found",
|
|
],
|
|
[
|
|
/invalid[_ ]api[_ ]key|incorrect api key|unauthorized/i,
|
|
"invalid_api_key",
|
|
],
|
|
// "too many tokens": Bedrock's throttling
|
|
[/rate limit|too many requests|too many tokens/i, "rate_limited"],
|
|
[
|
|
/Cannot connect to API|ECONNREFUSED|ENOTFOUND|ECONNRESET|ETIMEDOUT|fetch failed/i,
|
|
"cannot_connect",
|
|
],
|
|
]
|
|
|
|
/** Secrets a provider may echo back: API keys, Bearer tokens, key=value */
|
|
function redact(text: string): string {
|
|
return text
|
|
.replace(/\b(sk|pk|rk|ak)-[A-Za-z0-9_-]{8,}/g, "$1-[redacted]")
|
|
.replace(/\bBearer\s+[A-Za-z0-9._~+/-]+=*/gi, "Bearer [redacted]")
|
|
.replace(/\bAKIA[0-9A-Z]{16}\b/g, "[redacted]")
|
|
.replace(
|
|
/\b(api[_-]?key|access[_-]?key|secret|token|password|signature)(["']?\s*[:=]\s*["']?)[^\s"',&}]+/gi,
|
|
"$1$2[redacted]",
|
|
)
|
|
}
|
|
|
|
function problemDetail(body: string): string | undefined {
|
|
try {
|
|
const detail = JSON.parse(body)?.detail
|
|
return typeof detail === "string" ? detail : undefined
|
|
} catch {
|
|
return undefined
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The error text for the chat stream: what went wrong with the provider as
|
|
* JSON for the hint, or the text the model must read to fix a tool call.
|
|
* On the server's keys the provider's own text stays in the server log:
|
|
* it can name the server's account, role or internal hosts.
|
|
*/
|
|
export function streamErrorText(error: unknown, hideDetails = false): string {
|
|
// The SDK passes an invalid tool call's error as a plain string. Other
|
|
// strings come from providers (DeepSeek's SDK sends stream errors so).
|
|
if (
|
|
typeof error === "string" &&
|
|
/^(Invalid input for tool|Model tried to call unavailable tool)/.test(
|
|
error,
|
|
)
|
|
) {
|
|
return error
|
|
}
|
|
if (isToolCallError(error)) return (error as Error).message
|
|
const classified = classifyLLMError(error)
|
|
if (hideDetails) {
|
|
console.error("[chat] Provider error:", error)
|
|
if (classified.code === "forbidden") {
|
|
// The hint says all the user can do; there is no message to add
|
|
classified.code = "server_key_forbidden"
|
|
classified.message = ""
|
|
} else {
|
|
classified.message = "The provider returned an error."
|
|
}
|
|
}
|
|
return JSON.stringify(classified)
|
|
}
|
|
|
|
/**
|
|
* Model and tool errors the SDK sends back to the model as the tool result,
|
|
* so it can fix its call. Their text has to stay as it is.
|
|
*/
|
|
export function isToolCallError(error: unknown): boolean {
|
|
return (
|
|
InvalidToolInputError.isInstance(error) ||
|
|
NoSuchToolError.isInstance(error) ||
|
|
ToolCallRepairError.isInstance(error)
|
|
)
|
|
}
|
|
|
|
export function classifyLLMError(error: unknown): LLMError {
|
|
// After the SDK's retries, the last attempt says what happened
|
|
const e = RetryError.isInstance(error) ? error.lastError : error
|
|
// Errors sent inside the stream can be plain objects like OpenRouter's
|
|
// { code: 503, message }
|
|
const plain = e as {
|
|
message?: unknown
|
|
code?: unknown
|
|
statusCode?: number
|
|
}
|
|
const raw =
|
|
e instanceof Error
|
|
? e.message
|
|
: typeof plain?.message === "string"
|
|
? plain.message
|
|
: String(e)
|
|
const body = APICallError.isInstance(e) ? (e.responseBody ?? "") : ""
|
|
// A problem+json body names the reason the SDK left out (NVIDIA: "Gone")
|
|
const detail = problemDetail(body)
|
|
const message = redact(detail ? `${raw}: ${detail}` : raw).slice(0, 500)
|
|
const text = `${raw} ${body}`
|
|
const status = APICallError.isInstance(e)
|
|
? e.statusCode
|
|
: (plain?.statusCode ??
|
|
(typeof plain?.code === "number" ? plain.code : undefined))
|
|
|
|
const find = (rules: Array<[RegExp, LLMErrorCode]>) =>
|
|
rules.find(([pattern]) => pattern.test(text))?.[1]
|
|
const code =
|
|
(e instanceof Error && e.name === "TimeoutError" && "timeout") ||
|
|
(LoadAPIKeyError.isInstance(e) && "invalid_api_key") ||
|
|
find(SPECIFIC_TEXTS) ||
|
|
(status && STATUS_CODES[status]) ||
|
|
(status && status >= 500 && "provider_unavailable") ||
|
|
find(GENERAL_TEXTS) ||
|
|
"unknown"
|
|
return { type: "provider", code, message }
|
|
}
|