fix: return empty string for valid result with no issues in formatValidationFeedback

This commit is contained in:
dayuan.jiang
2026-01-20 20:04:29 +09:00
parent fa06c61538
commit fd9302e736
2 changed files with 7 additions and 5 deletions

View File

@@ -16,6 +16,11 @@ import type { ValidationResult } from "./validation-schema"
* @returns Formatted string for tool error output
*/
export function formatValidationFeedback(result: ValidationResult): string {
// If validation passed with no issues, return empty string
if (result.valid && result.issues.length === 0) {
return ""
}
const lines: string[] = []
lines.push("DIAGRAM VISUAL VALIDATION FAILED")

View File

@@ -78,7 +78,7 @@ describe("formatValidationFeedback", () => {
expect(feedback).toContain("Adjust spacing")
})
it("formats result with no issues", () => {
it("returns empty string for valid result with no issues", () => {
const result: ValidationResult = {
valid: true,
issues: [],
@@ -87,10 +87,7 @@ describe("formatValidationFeedback", () => {
const feedback = formatValidationFeedback(result)
expect(feedback).toContain("DIAGRAM VISUAL VALIDATION FAILED")
expect(feedback).not.toContain("Critical Issues")
expect(feedback).not.toContain("Warnings:")
expect(feedback).not.toContain("Suggestions to fix:")
expect(feedback).toBe("")
})
it("formats result with multiple suggestions", () => {