i/rtabmap_ros
1
0
Fork 0
mirror of https://github.com/introlab/rtabmap_ros.git synced 2026-10-04 16:57:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(rtabmap_slam): release scan mutex on conversion failure (#1459)

Browse Source 
* fix(rtabmap_slam): release scan mutex on conversion failure

* test(rtabmap_slam): cover scan transform recovery in native tests

Replace the standalone reproducer with registered C++ GoogleTests for 2D and 3D scan recovery. Use real ROS inputs, separate DDS domains and bounded timeouts, and include rtabmap_slam in supported CI and coverage jobs.

Validated on Jazzy with RTAB-Map core 9ed83a7: both negative controls fail map recovery without the unlocks; both pass with the fix, followed by five repeated runs per case (10/10 passed). Broader distro CI has not been run locally.

* chore(rtabmap_slam): keep upstream submission focused on mutex fix

Remove the regression test and CI integration from the proposed diff. Retain the reproducer in commit 254ca3b so it can be offered separately with the validation evidence.

---------

Co-authored-by: Matthew Kotara <[email protected]>
Co-authored-by: matlabbe <[email protected]>
This commit is contained in:
Matthew Kotara
2026-09-22 17:50:04 -07:00
committed by GitHub
co-authored by Matthew Kotara matlabbe
parent 335d155768
commit 853a434fe9
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rtabmap_slam/src/CoreWrapper.cpp
+2
View File
@@ -1801,6 +1801,7 @@ void CoreWrapper::commonLaserScanCallback(
rtabmap_.getMemory() && uStrNumCmp(rtabmap_.getMemory()->getDatabaseVersion(), "0.11.10") < 0))
{
RCLCPP_ERROR(this->get_logger(), "Could not convert laser scan msg! Aborting rtabmap update...");
syncDataMutex_.unlock();
return;
}
}
@@ -1819,6 +1820,7 @@ void CoreWrapper::commonLaserScanCallback(
scanCloudIs2d_))
{
RCLCPP_ERROR(this->get_logger(), "Could not convert 3d laser scan msg! Aborting rtabmap update...");
syncDataMutex_.unlock();
return;
}
}