From 9cee4c17b2eb6537ae56bbe72f4020e202930162 Mon Sep 17 00:00:00 2001
From: matlabbe <matlabbe@gmail.com>
Date: Fri, 7 Aug 2026 21:16:28 -0700
Subject: [PATCH] CI: Fixed doc job failing on master while it should not

---
 .github/workflows/docs.yml | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 123a8fce..b869be00 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -207,5 +207,12 @@ jobs:
             echo ""
             echo "- Landing page: ${url}/"
             echo "- C++ API: ${url}/api/latest/"
-            [[ -n "${note}" ]] && { echo ""; echo "${note}"; }
+            # An `if` rather than `[[ ... ]] && { ... }`: as the last command in
+            # the group, a false test would make the group (and so the whole
+            # step) exit 1. `note` is empty on push, which failed every master
+            # run while pull requests passed.
+            if [[ -n "${note}" ]]; then
+              echo ""
+              echo "${note}"
+            fi
           } >> "$GITHUB_STEP_SUMMARY"