Files
next-ai-draw-io/tests/unit/template-storage.test.ts
T
Dayuan Jiang 60105ddb51 refactor: remove dead code and over-engineering found by two audits (#986)
## Problem

Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.

## Change

Every item below was either approved one by one or covered by "fix all of the others".

- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.

Source lines: 74,983 before, 67,418 after (excluding lockfiles).

The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).

## Testing

- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
2026-10-12 12:35:55 +09:00

265 lines
8.0 KiB
TypeScript

import { describe, expect, it } from "vitest"
import {
generateDefaultTitle,
searchTemplates,
sortTemplates,
type Template,
validateImportData,
} from "@/lib/template-storage"
describe("generateDefaultTitle", () => {
it("returns the prompt as-is when 20 chars or fewer", () => {
expect(generateDefaultTitle("Hello")).toBe("Hello")
expect(generateDefaultTitle("A".repeat(20))).toBe("A".repeat(20))
})
it("truncates to 20 chars with ellipsis for longer prompts", () => {
const result = generateDefaultTitle(
"This is a very long prompt that should be truncated",
)
expect(result).toBe("This is a very long...")
expect(result.length).toBeGreaterThan(20)
})
it("trims whitespace before truncating", () => {
expect(generateDefaultTitle(" hello ")).toBe("hello")
expect(generateDefaultTitle(" " + "x".repeat(25) + " ")).toBe(
"xxxxxxxxxxxxxxxxxxxx...",
)
})
})
describe("sortTemplates", () => {
const baseTemplate = (
overrides: Partial<Omit<Template, "id">> & Pick<Template, "id">,
): Template => ({
title: "Test",
prompt: "test prompt",
createdAt: 1000,
updatedAt: 1000,
runCount: 0,
lastUsedAt: 0,
pinned: false,
...overrides,
})
it("sorts pinned templates first", () => {
const templates = [
baseTemplate({ id: "1", runCount: 10 }),
baseTemplate({ id: "2", pinned: true, runCount: 1 }),
]
const result = sortTemplates(templates)
expect(result[0].id).toBe("2")
})
it("sorts by runCount descending among non-pinned", () => {
const templates = [
baseTemplate({ id: "1", runCount: 5 }),
baseTemplate({ id: "2", runCount: 10 }),
baseTemplate({ id: "3", runCount: 1 }),
]
const result = sortTemplates(templates)
expect(result.map((t) => t.id)).toEqual(["2", "1", "3"])
})
it("sorts by lastUsedAt descending when runCount is equal", () => {
const templates = [
baseTemplate({ id: "1", runCount: 5, lastUsedAt: 100 }),
baseTemplate({ id: "2", runCount: 5, lastUsedAt: 200 }),
]
const result = sortTemplates(templates)
expect(result[0].id).toBe("2")
})
it("sorts by updatedAt descending when runCount and lastUsedAt are equal", () => {
const templates = [
baseTemplate({
id: "1",
runCount: 5,
lastUsedAt: 100,
updatedAt: 50,
}),
baseTemplate({
id: "2",
runCount: 5,
lastUsedAt: 100,
updatedAt: 150,
}),
]
const result = sortTemplates(templates)
expect(result[0].id).toBe("2")
})
it("does not mutate the original array", () => {
const templates = [
baseTemplate({ id: "1", runCount: 1 }),
baseTemplate({ id: "2", runCount: 10 }),
]
const copy = [...templates]
sortTemplates(templates)
expect(templates.map((t) => t.id)).toEqual(copy.map((t) => t.id))
})
it("returns empty array for empty input", () => {
expect(sortTemplates([])).toEqual([])
})
})
describe("searchTemplates", () => {
const templates: Template[] = [
{
id: "1",
title: "Flowchart",
prompt: "Create a flowchart",
description: "Basic flowchart template",
createdAt: 1000,
updatedAt: 1000,
runCount: 0,
lastUsedAt: 0,
pinned: false,
},
{
id: "2",
title: "ER Diagram",
prompt: "Design a database",
description: "Entity relationship diagram",
createdAt: 1000,
updatedAt: 1000,
runCount: 0,
lastUsedAt: 0,
pinned: false,
},
{
id: "3",
title: "Network",
prompt: "Draw network topology",
createdAt: 1000,
updatedAt: 1000,
runCount: 0,
lastUsedAt: 0,
pinned: false,
},
]
it("returns all templates when query is empty", () => {
expect(searchTemplates(templates, "")).toHaveLength(3)
expect(searchTemplates(templates, " ")).toHaveLength(3)
})
it("searches by title", () => {
const result = searchTemplates(templates, "flowchart")
expect(result).toHaveLength(1)
expect(result[0].id).toBe("1")
})
it("searches by description", () => {
const result = searchTemplates(templates, "entity")
expect(result).toHaveLength(1)
expect(result[0].id).toBe("2")
})
it("is case-insensitive", () => {
const result = searchTemplates(templates, "FLOWCHART")
expect(result).toHaveLength(1)
expect(result[0].id).toBe("1")
})
it("returns empty array when no match", () => {
const result = searchTemplates(templates, "nonexistent")
expect(result).toHaveLength(0)
})
it("handles templates without description", () => {
const result = searchTemplates(templates, "network")
expect(result).toHaveLength(1)
expect(result[0].id).toBe("3")
})
})
describe("validateImportData", () => {
it("rejects non-object input", () => {
expect(validateImportData(null).valid).toBe(false)
expect(validateImportData("string").valid).toBe(false)
expect(validateImportData(123).valid).toBe(false)
})
it("rejects missing schemaVersion", () => {
const result = validateImportData({ templates: [] })
expect(result.valid).toBe(false)
expect(result.error).toContain("schemaVersion")
})
it("rejects missing templates array", () => {
const result = validateImportData({ schemaVersion: 1 })
expect(result.valid).toBe(false)
expect(result.error).toContain("templates")
})
it("rejects template with missing prompt", () => {
const result = validateImportData({
schemaVersion: 1,
templates: [{ title: "Test" }],
})
expect(result.valid).toBe(false)
expect(result.error).toContain("prompt")
})
it("rejects template with empty prompt", () => {
const result = validateImportData({
schemaVersion: 1,
templates: [{ title: "Test", prompt: " " }],
})
expect(result.valid).toBe(false)
expect(result.error).toContain("prompt")
})
it("rejects template with missing title", () => {
const result = validateImportData({
schemaVersion: 1,
templates: [{ prompt: "test" }],
})
expect(result.valid).toBe(false)
expect(result.error).toContain("title")
})
it("accepts valid data", () => {
const result = validateImportData({
schemaVersion: 1,
templates: [
{
id: "1",
title: "Test",
prompt: "test prompt",
createdAt: Date.now(),
updatedAt: Date.now(),
runCount: 0,
lastUsedAt: 0,
pinned: false,
},
],
})
expect(result.valid).toBe(true)
})
it("accepts empty templates array", () => {
const result = validateImportData({
schemaVersion: 1,
templates: [],
})
expect(result.valid).toBe(true)
})
it("reports index of invalid template", () => {
const result = validateImportData({
schemaVersion: 1,
templates: [
{ title: "Valid", prompt: "valid" },
{ title: "Also Valid", prompt: "also valid" },
{ title: "No Prompt" },
],
})
expect(result.valid).toBe(false)
expect(result.error).toContain("index 2")
})
})