Files
next-ai-draw-io/tests/e2e/language.spec.ts
T
Dayuan Jiang 60105ddb51 refactor: remove dead code and over-engineering found by two audits (#986)
## Problem

Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.

## Change

Every item below was either approved one by one or covered by "fix all of the others".

- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.

Source lines: 74,983 before, 67,418 after (excluding lockfiles).

The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).

## Testing

- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
2026-10-12 12:35:55 +09:00

156 lines
5.1 KiB
TypeScript

import type { Page } from "@playwright/test"
import { SINGLE_BOX_XML } from "./fixtures/diagrams"
import {
expect,
getChatInput,
getIframe,
getSendButton,
openApp,
openSettingsTab,
sendMessage,
sleep,
test,
waitForComplete,
} from "./lib/fixtures"
import { createMockSSEResponse } from "./lib/helpers"
/** Pick a language in the settings, then close them */
async function pickLanguage(page: Page, name: string) {
await openSettingsTab(page, "general")
await page.locator("#language-select").click()
await page.getByRole("option", { name, exact: true }).click()
await page.keyboard.press("Escape")
}
test.describe("Language Switching", () => {
test("loads English by default", async ({ page }) => {
await openApp(page)
const chatInput = getChatInput(page)
await expect(chatInput).toBeVisible({ timeout: 10000 })
await expect(getSendButton(page, "Send")).toBeVisible()
})
test("can switch to Japanese", async ({ page }) => {
await openApp(page)
await test.step("open settings and select Japanese", async () => {
await pickLanguage(page, "日本語")
})
await test.step("verify UI is in Japanese", async () => {
await expect(getSendButton(page, "送信")).toBeVisible({
timeout: 5000,
})
})
})
test("can switch to Chinese", async ({ page }) => {
await openApp(page)
await test.step("open settings and select Chinese", async () => {
await pickLanguage(page, "中文")
})
await test.step("verify UI is in Chinese", async () => {
await expect(getSendButton(page, "发送")).toBeVisible({
timeout: 5000,
})
})
})
test("language persists after reload", async ({ page }) => {
await openApp(page)
await test.step("switch to Japanese", async () => {
await pickLanguage(page, "日本語")
await sleep(500)
})
await test.step("verify Japanese before reload", async () => {
await expect(getSendButton(page, "送信")).toBeVisible({
timeout: 10000,
})
})
await test.step("reload and verify Japanese persists", async () => {
await page.reload({ waitUntil: "networkidle" })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
// Wait for hydration and localStorage to be read
await sleep(1000)
await expect(getSendButton(page, "送信")).toBeVisible({
timeout: 10000,
})
})
})
test("Japanese locale URL works", async ({ page }) => {
await openApp(page, { path: "/ja" })
await expect(getSendButton(page, "送信")).toBeVisible({
timeout: 10000,
})
})
test("Chinese locale URL works", async ({ page }) => {
await openApp(page, { path: "/zh" })
await expect(getSendButton(page, "发送")).toBeVisible({
timeout: 10000,
})
})
test("a stale offer to switch without saving does nothing once a message is being sent", async ({
page,
}) => {
// Registered before the app's own listener, so it can drop
// draw.io's export replies once asked to
await page.addInitScript(() => {
window.addEventListener("message", (event) => {
if (
(window as any).__dropExports &&
typeof event.data === "string" &&
event.data.includes('"event":"export"')
) {
event.stopImmediatePropagation()
}
})
})
await page.route("**/api/chat", (route) =>
route.fulfill({
status: 200,
contentType: "text/event-stream",
body: createMockSSEResponse(SINGLE_BOX_XML, "Drew the box."),
}),
)
await openApp(page)
await sendMessage(page, "Draw a box")
await waitForComplete(page)
// Storage is full: switching the language offers to go on unsaved
await page.evaluate(() => {
IDBObjectStore.prototype.put = () => {
throw new DOMException("Storage is full", "QuotaExceededError")
}
})
await pickLanguage(page, "日本語")
const offer = page.getByRole("button", {
name: "Continue without saving",
})
await expect(offer).toBeVisible({ timeout: 5000 })
// The next message waits for its diagram export (it never comes)
await page.evaluate(() => {
;(window as any).__dropExports = true
})
await sendMessage(page, "Make it red")
// Other toasts may stack over it
await offer.dispatchEvent("click")
await sleep(1500)
await expect(page).toHaveURL(/\/en(\?|$)/)
// The export gives up: the message is back in the composer
await expect(getChatInput(page)).toHaveValue("Make it red", {
timeout: 15000,
})
})
})