Files
next-ai-draw-io/tests/unit/use-diagram-tool-handlers.test.tsx
T
dayuan.jiang c75f74a5a0 fix: what the third round broke, and the first batch's review
MCP preview after the server lost a session (it expired, or the MCP
process restarted):
- Every server state has an id, made when the state is created. The tab
  notices a new id even when the version numbers happen to match, and
  every push names the state it was based on, so one based on a lost state
  is refused, also when it comes before the tab's first poll (the server
  recovers the saved file first).
- The tab keeps the newest canvas XML, saved or not. When the server knows
  nothing (no file) or exactly what the tab last saved, the canvas wins and
  is saved, so edits made while the server was down are kept. Otherwise
  the server's diagram (an AI write the tab missed, a cleared document
  that was saved) is shown and the tab's copy goes to History.
- Late answers to an old state's push or poll are dropped; a failed push
  says the server is unreachable; Download as .drawio saves the canvas.

Settings and server:
- Saved providers this version does not know stay in storage with their
  keys, and sending no longer trips over them.
- The desktop "Ollama (Local)" preset with a key goes to local Ollama
  again; a server model's Ollama URL variable is read; the admin panel
  writes Ollama Cloud's URL for a key without one.
- Provider error texts show again in the desktop app and for EdgeOne.
- .env: a quoted value followed by a comment ending in a quote is read as
  dotenv reads it; unquoted values are unchanged.
- Desktop app: the next launch opens the port where a chat was last
  saved; a launch elsewhere that saves nothing does not move it, and a
  page with no chats lets the next launch try the other port once.
- The Test button no longer stays busy after another tab changed the key.
- A completed append_diagram is no longer undone by an earlier failed
  edit's preview; a file read once in vain is saved again once it is read
  or gone.

From the first batch's review:
- The admin panel's Test of an entry without a URL now tests the server's
  <P>_BASE_URL, where chat sends the entry's key; chat is unchanged (the
  first fix rerouted working setups).
- The model list ends downloads that are too large, accepts answers
  without a body, and keeps the "redirects are not allowed" explanation.
- A test covers the preview's History rendering.
2026-10-05 17:33:36 +09:00

83 lines
3.5 KiB
TypeScript

import { renderHook } from "@testing-library/react"
import { describe, expect, it, vi } from "vitest"
import { useDiagramToolHandlers } from "@/hooks/use-diagram-tool-handlers"
const geometry =
'<mxGeometry x="0" y="0" width="80" height="40" as="geometry"/>'
const box = (id: string) =>
`<mxCell id="${id}" value="${id}" vertex="1" parent="1">${geometry}</mxCell>`
function setup(partialXml: string) {
const refs = {
partialXmlRef: { current: partialXml },
// A failed edit's preview is still on the canvas, its original kept
editDiagramOriginalXmlRef: {
current: new Map([["edit-1", "<mxfile>original</mxfile>"]]),
},
processedToolCallsRef: { current: new Set<string>() },
validationRetryCountRef: { current: 0 },
chartXMLRef: { current: "" },
}
const onDisplayChart = vi.fn(
(_xml: string, _skipValidation?: boolean): string | null => null,
)
const { result } = renderHook(() =>
useDiagramToolHandlers({
...refs,
onDisplayChart,
onFetchChart: async () => "",
onExport: () => {},
enableVlmValidation: false,
}),
)
const addToolOutput = vi.fn()
const append = (xml: string) =>
result.current.handleToolCall(
{
toolCall: {
toolCallId: "append-1",
toolName: "append_diagram",
input: { xml },
},
},
addToolOutput,
)
return { refs, onDisplayChart, addToolOutput, append }
}
describe("append_diagram and the stored previews", () => {
it("takes the stored originals when it draws the completed diagram", async () => {
// Otherwise the preview code later loads the failed edit's original
// over the completed diagram
const { refs, onDisplayChart, append } = setup(
`${box("2")}<mxCell id="3" value="3" vertex="1" parent="1"><mxGeometry x="0" y="0" width="8`,
)
await append('0" height="40" as="geometry"/></mxCell>')
expect(onDisplayChart).toHaveBeenCalledTimes(1)
expect(onDisplayChart.mock.calls[0][0]).toContain('id="3"')
expect(refs.editDiagramOriginalXmlRef.current.size).toBe(0)
expect(refs.processedToolCallsRef.current.has("edit-1")).toBe(true)
})
it("leaves them while the diagram is still incomplete", async () => {
// Nothing is drawn, so the failed edit's preview must still be undone
const { refs, onDisplayChart, append } = setup(
`${box("2")}<mxCell id="3" value="3" vertex="1" parent="1"><mxGeometry x="0" y="0" width="8`,
)
await append('0" height="40"')
expect(onDisplayChart).not.toHaveBeenCalled()
expect(refs.editDiagramOriginalXmlRef.current.size).toBe(1)
expect(refs.processedToolCallsRef.current.has("edit-1")).toBe(false)
})
it("leaves them when the assembled diagram is invalid", async () => {
const { refs, onDisplayChart, addToolOutput, append } = setup(
`<mxCell id="1" value="root id" vertex="1" parent="1">${geometry}</mxCell><mxCell id="3" value="3" vertex="1" parent="1"><mxGeometry x="0" y="0" width="8`,
)
await append('0" height="40" as="geometry"/></mxCell>')
expect(onDisplayChart).not.toHaveBeenCalled()
expect(addToolOutput.mock.calls[0][0].state).toBe("output-error")
expect(refs.editDiagramOriginalXmlRef.current.size).toBe(1)
})
})