Files
next-ai-draw-io/tests/unit/chat-route-quota.test.ts
T
dayuan.jiang 4731394f32 fix(security): check request sources, regions and endpoints
- Bedrock: a request's AWS region must be a region name. It becomes part
  of the endpoint's host name, so a value such as
  "us-east-1.attacker.example/" sent the server's bearer token or signed
  request to another host.
- MCP preview server: only the preview page itself (Origin equal to the
  Host) or a non-browser client may call it; a page on another localhost
  port could replace the diagram with a plain text POST. History builds
  its thumbnails element by element and shows only SVG data images, so a
  stored value can no longer run script in the preview.
- chat, validate-model, validate-diagram, provider-models and parse-url
  take JSON bodies only, so another website cannot make the user's own
  server (the desktop app, a local install) run models with their keys;
  the desktop app also refuses a foreign Host (DNS rebinding).
- The model list reads at most 2 MB, also through the Gateway SDK, and
  answers only with its own error texts: the URL is the caller's and may
  be an internal address.
- An admin panel provider with its own key and no URL no longer inherits
  the global <P>_BASE_URL, which may be a proxy for another key; OpenAI
  then gets the official endpoint, as its Test. Azure keeps the server's
  resource.
2026-10-05 17:02:06 +09:00

180 lines
5.5 KiB
TypeScript

// @vitest-environment node
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
// Quota on, and every check answers that the daily limit is used up
const quota = vi.hoisted(() => ({ checks: 0 }))
vi.mock("@/lib/dynamo-quota-manager", () => ({
isQuotaEnabled: () => true,
checkAndIncrementRequest: async () => {
quota.checks++
return {
allowed: false,
error: "Daily limit reached",
type: "request",
used: 10,
limit: 10,
}
},
recordTokenUsage: async () => {},
}))
// No DNS in tests: only loopback addresses are private
vi.mock("@/lib/ssrf-protection", async (importOriginal) => ({
...(await importOriginal<typeof import("@/lib/ssrf-protection")>()),
isPrivateUrl: async (url: string) =>
/^https?:\/\/(127\.0\.0\.1|localhost)\b/.test(url),
}))
import { POST as chat } from "@/app/api/chat/route"
const ENV = [
"AI_PROVIDER",
"AI_MODEL",
"OPENAI_API_KEY",
"OLLAMA_BASE_URL",
"OLLAMA_API_KEY",
"AI_GATEWAY_API_KEY",
"ALLOW_PRIVATE_URLS",
]
const saved: Record<string, string | undefined> = {}
beforeEach(() => {
for (const k of ENV) saved[k] = process.env[k]
process.env.AI_PROVIDER = "openai"
process.env.AI_MODEL = "gpt-5.5"
process.env.OPENAI_API_KEY = "server-key"
quota.checks = 0
// No request may reach a provider
vi.stubGlobal(
"fetch",
vi.fn(async () => {
throw new Error("no network in tests")
}),
)
})
afterEach(() => {
for (const k of ENV) {
if (saved[k] === undefined) delete process.env[k]
else process.env[k] = saved[k]
}
vi.unstubAllGlobals()
})
const send = (headers: Record<string, string>) =>
chat(
new Request("http://localhost/api/chat", {
method: "POST",
headers: {
"Content-Type": "application/json",
"x-forwarded-for": "203.0.113.7",
...headers,
},
body: JSON.stringify({
messages: [
{
id: "u1",
role: "user",
parts: [{ type: "text", text: "Draw two boxes" }],
},
],
xml: "",
}),
}),
)
describe("chat quota", () => {
it("counts a request whose key header the provider never reads", async () => {
// OpenAI ignores the AWS key, so this runs on the server's key
const res = await send({
"x-ai-provider": "openai",
"x-aws-access-key-id": "x",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("does not count a request on the user's own key", async () => {
const res = await send({
"x-ai-provider": "openai",
"x-ai-api-key": "user-key",
"x-ai-model": "gpt-5.5",
})
expect(res.status).not.toBe(429)
expect(quota.checks).toBe(0)
})
it("counts the server's keyless Ollama and EdgeOne", async () => {
process.env.AI_PROVIDER = "ollama"
process.env.AI_MODEL = "llama3.2"
process.env.OLLAMA_BASE_URL = "http://ollama.internal:11434/api"
expect((await send({})).status).toBe(429)
expect(
(
await send({
"x-ai-provider": "edgeone",
"x-ai-model": "@tx/deepseek-ai/deepseek-v3-0324",
})
).status,
).toBe(429)
expect(quota.checks).toBe(2)
})
it("counts EdgeOne with a key header it never reads", async () => {
const res = await send({
"x-ai-provider": "edgeone",
"x-ai-api-key": "ignored",
"x-ai-model": "@tx/deepseek-ai/deepseek-v3-0324",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("counts Ollama at a private address, the server's network", async () => {
const res = await send({
"x-ai-provider": "ollama",
"x-ai-base-url": "http://127.0.0.1:11434/api",
"x-ai-model": "llama3.2",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("does not count Ollama on the user's own server", async () => {
const res = await send({
"x-ai-provider": "ollama",
"x-ai-base-url": "https://ollama.example.com/api",
"x-ai-model": "llama3.2",
})
expect(res.status).not.toBe(429)
expect(quota.checks).toBe(0)
})
})
describe("request checks", () => {
it("refuses an AWS region that is not a region name", async () => {
process.env.AI_PROVIDER = "bedrock"
process.env.AI_MODEL = "amazon.nova-lite-v1:0"
const res = await send({
"x-aws-region": "us-east-1.attacker.example/",
})
expect(res.status).toBe(400)
expect(await res.text()).toMatch(/Invalid AWS region/)
expect(fetch).not.toHaveBeenCalled()
})
})
describe("server model allowlist", () => {
it("runs AI_MODEL only on the server's AI_PROVIDER", async () => {
// Another provider's server key must not run it
process.env.AI_GATEWAY_API_KEY = "server-gateway-key"
const res = await send({
"x-ai-provider": "gateway",
"x-ai-model": "gpt-5.5",
})
expect(res.status).toBe(400)
expect(await res.text()).toMatch(/not available on this server/)
expect(quota.checks).toBe(0)
})
})