mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-10 03:29:50 +08:00
Found by the PR review, each with a test that failed first:
- get_diagram during a page export returned the one-page projection on
screen as the whole document (6 of 6 times when timed so). The preview
page no longer answers a sync while a projection shows, and syncs after
reloading, so the poll that restores the real document exports it.
- Exports are numbered on the server too: a late result of an export that
timed out was saved as the next export's file.
- In Chrome, a new_xml with a syntax error counted the <parsererror>
element as a second cell, so the web app rejected edits that auto-fix
repairs ("must contain exactly one cell").
- hasCells missed single-quoted ids, so screenshot_diagram called such a
diagram empty and auto-save never created its file.
- A literal \n directly under a <diagram> that has a model passed
validation; only text-only pages are compressed data.
- A wrapped mxCell repeating its UserObject's id took the wrapper's place
in edits, so delete and update left an empty or nested wrapper.
- Bare cells with a shape or edge id of "0" or "1" are rejected with a
clear message instead of being renamed, which broke their edges.
- DRAWIO_DATA_DIR expands ~, which JSON configs pass on as it is.
152 lines
6.8 KiB
TypeScript
152 lines
6.8 KiB
TypeScript
/**
|
|
* Tests for edit_diagram operations on cells that draw.io wraps in
|
|
* <UserObject> or <object> (cells with links, tooltips or custom data).
|
|
* The id sits on the wrapper; the inner mxCell has none.
|
|
*/
|
|
|
|
import { deflateRawSync } from "node:zlib"
|
|
import { beforeAll, describe, expect, it, vi } from "vitest"
|
|
import { installDomPolyfill } from "../src/dom.ts"
|
|
|
|
beforeAll(() => {
|
|
installDomPolyfill()
|
|
})
|
|
|
|
import { applyDiagramOperations } from "../src/diagram-operations.ts"
|
|
|
|
const DOC = `<mxfile><diagram id="p" name="Page-1"><mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/><UserObject id="a" label="A" link="https://example.com"><mxCell vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell></UserObject><mxCell id="b" value="B" vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell><object id="e1" label="" tooltip="t"><mxCell edge="1" source="b" target="a" parent="1"><mxGeometry relative="1" as="geometry"/></mxCell></object><mxCell id="child" value="C" vertex="1" parent="a"><mxGeometry as="geometry"/></mxCell></root></mxGraphModel></diagram></mxfile>`
|
|
|
|
describe("wrapped cells", () => {
|
|
it("deletes a UserObject cell with its edges and children", () => {
|
|
const { result, errors } = applyDiagramOperations(DOC, [
|
|
{ operation: "delete", cell_id: "a" },
|
|
])
|
|
expect(errors).toEqual([])
|
|
expect(result).not.toContain('id="a"')
|
|
expect(result).not.toContain('id="e1"')
|
|
expect(result).not.toContain('id="child"')
|
|
expect(result).toContain('id="b"')
|
|
})
|
|
|
|
it("cascades to a wrapped edge when deleting a plain cell", () => {
|
|
const { result, errors } = applyDiagramOperations(DOC, [
|
|
{ operation: "delete", cell_id: "b" },
|
|
{ operation: "delete", cell_id: "e1" },
|
|
])
|
|
// e1 was already removed by the cascade, so no warning for it
|
|
expect(errors).toEqual([])
|
|
expect(result).not.toContain('id="e1"')
|
|
expect(result).toContain('id="a"')
|
|
})
|
|
|
|
it("warns when deleting a cell that does not exist", () => {
|
|
const { errors } = applyDiagramOperations(DOC, [
|
|
{ operation: "delete", cell_id: "missing" },
|
|
])
|
|
expect(errors).toHaveLength(1)
|
|
expect(errors[0]).toMatchObject({ type: "delete", cellId: "missing" })
|
|
})
|
|
|
|
it("updates a UserObject cell", () => {
|
|
const { result, errors } = applyDiagramOperations(DOC, [
|
|
{
|
|
operation: "update",
|
|
cell_id: "a",
|
|
new_xml: `<UserObject id="a" label="A2" link="https://example.com"><mxCell vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell></UserObject>`,
|
|
},
|
|
])
|
|
expect(errors).toEqual([])
|
|
expect(result).toContain('label="A2"')
|
|
expect(result.match(/id="a"/g)).toHaveLength(1)
|
|
})
|
|
|
|
it("refuses to add a cell whose id a UserObject already uses", () => {
|
|
const { errors } = applyDiagramOperations(DOC, [
|
|
{
|
|
operation: "add",
|
|
cell_id: "a",
|
|
new_xml: `<mxCell id="a" vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell>`,
|
|
},
|
|
])
|
|
expect(errors[0]?.message).toContain("already exists")
|
|
})
|
|
})
|
|
|
|
describe("cascade delete logging", () => {
|
|
it("does not write cascade logs to stdout (the JSON-RPC channel)", () => {
|
|
const plain = `<mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/><mxCell id="x" vertex="1" parent="1"/><mxCell id="y" vertex="1" parent="1"/><mxCell id="e" edge="1" source="x" target="y" parent="1"/></root></mxGraphModel>`
|
|
const spy = vi.spyOn(console, "log").mockImplementation(() => {})
|
|
const { result } = applyDiagramOperations(plain, [
|
|
{ operation: "delete", cell_id: "x" },
|
|
])
|
|
expect(result).not.toContain('id="e"')
|
|
expect(spy).not.toHaveBeenCalled()
|
|
spy.mockRestore()
|
|
})
|
|
})
|
|
|
|
describe("pages without a <root>", () => {
|
|
const ADD_A = {
|
|
operation: "add" as const,
|
|
cell_id: "a",
|
|
new_xml: `<mxCell id="a" vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell>`,
|
|
}
|
|
|
|
it("treats an empty page as a blank page", () => {
|
|
const doc = `<mxfile><diagram id="p" name="Page-1"></diagram></mxfile>`
|
|
const { result, errors } = applyDiagramOperations(doc, [ADD_A])
|
|
expect(errors).toEqual([])
|
|
expect(result).toContain('<mxCell id="0"/>')
|
|
expect(result).toContain('<mxCell id="1" parent="0"/>')
|
|
expect(result).toContain('<mxCell id="a"')
|
|
})
|
|
|
|
it("decompresses a compressed page before editing it", () => {
|
|
const model = `<mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/><mxCell id="b" vertex="1" parent="1"/></root></mxGraphModel>`
|
|
const compressed = deflateRawSync(
|
|
Buffer.from(encodeURIComponent(model)),
|
|
).toString("base64")
|
|
const doc = `<mxfile><diagram id="p" name="Page-1">${compressed}</diagram></mxfile>`
|
|
const { result, errors } = applyDiagramOperations(doc, [ADD_A])
|
|
expect(errors).toEqual([])
|
|
expect(result).not.toContain(compressed)
|
|
expect(result).toContain('<mxCell id="b"')
|
|
expect(result).toContain('<mxCell id="a"')
|
|
// Only one model and one set of root cells
|
|
expect(result.match(/<mxGraphModel/g)).toHaveLength(1)
|
|
expect(result.match(/<mxCell id="0"/g)).toHaveLength(1)
|
|
})
|
|
|
|
it("reports a page whose text is not compressed XML", () => {
|
|
const doc = `<mxfile><diagram id="p" name="Page-1">not base64 !!</diagram></mxfile>`
|
|
const { errors } = applyDiagramOperations(doc, [ADD_A])
|
|
expect(errors[0]?.cellId).toBe("")
|
|
expect(errors[0]?.message).toContain("could not be decompressed")
|
|
})
|
|
})
|
|
|
|
describe("a wrapped mxCell with its wrapper's id", () => {
|
|
const doc = `<mxfile><diagram id="p" name="P"><mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/><UserObject id="u" label="A" link="https://example.com"><mxCell id="u" vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell></UserObject></root></mxGraphModel></diagram></mxfile>`
|
|
|
|
it("deletes the whole wrapper", () => {
|
|
const { result, errors } = applyDiagramOperations(doc, [
|
|
{ operation: "delete", cell_id: "u" },
|
|
])
|
|
expect(errors).toEqual([])
|
|
expect(result).not.toContain("UserObject")
|
|
})
|
|
|
|
it("replaces the wrapper on update", () => {
|
|
const { result, errors } = applyDiagramOperations(doc, [
|
|
{
|
|
operation: "update",
|
|
cell_id: "u",
|
|
new_xml: `<UserObject id="u" label="B" link="https://example.com"><mxCell vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell></UserObject>`,
|
|
},
|
|
])
|
|
expect(errors).toEqual([])
|
|
expect(result.match(/<UserObject/g)).toHaveLength(1)
|
|
expect(result).toContain('label="B"')
|
|
})
|
|
})
|