mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-12 20:49:53 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
112 lines
4.0 KiB
TypeScript
112 lines
4.0 KiB
TypeScript
import { expect, type Page, test } from "@playwright/test"
|
|
import { openApp, sendMessage } from "./lib/fixtures"
|
|
|
|
/** Answer the chat request with the given response and send a message */
|
|
async function chatWith(
|
|
page: Page,
|
|
response: { status: number; contentType: string; body: string },
|
|
) {
|
|
await page.route("**/api/chat", (route) => route.fulfill(response))
|
|
await openApp(page)
|
|
await sendMessage(page, "Draw a box")
|
|
}
|
|
|
|
test("a rejected key shows a hint, the provider's words and a settings button", async ({
|
|
page,
|
|
}) => {
|
|
await chatWith(page, {
|
|
status: 401,
|
|
contentType: "application/json",
|
|
body: JSON.stringify({
|
|
type: "provider",
|
|
code: "invalid_api_key",
|
|
message: "Authentication Fails, Your api key is invalid",
|
|
}),
|
|
})
|
|
await expect(
|
|
page.getByText("The provider rejected the API key"),
|
|
).toBeVisible({
|
|
timeout: 15000,
|
|
})
|
|
// First match: the Next.js dev overlay at the end also lists the error
|
|
await expect(page.getByText("Authentication Fails").first()).toBeVisible()
|
|
await page.getByRole("button", { name: "Open model settings" }).click()
|
|
// A server model answered: settings opens on the models tab's list
|
|
const dialog = page.getByRole("dialog", { name: "Settings" })
|
|
await expect(dialog).toBeVisible()
|
|
await expect(
|
|
dialog.getByRole("heading", { name: "Models", exact: true }),
|
|
).toBeVisible()
|
|
await expect(dialog.getByText("Use your own API key")).toBeVisible()
|
|
})
|
|
|
|
test("an error before the stream shows its text, not raw JSON", async ({
|
|
page,
|
|
}) => {
|
|
await chatWith(page, {
|
|
status: 400,
|
|
contentType: "application/json",
|
|
body: JSON.stringify({
|
|
error: 'Model "x" is not available on the server',
|
|
}),
|
|
})
|
|
// The whole message, not the JSON around it (the Next.js dev overlay
|
|
// also lists the raw console error; it is not part of the app)
|
|
await expect(
|
|
page.getByText('Model "x" is not available on the server', {
|
|
exact: true,
|
|
}),
|
|
).toBeVisible({ timeout: 15000 })
|
|
})
|
|
|
|
test("a provider rate limit is not shown as this site's quota", async ({
|
|
page,
|
|
}) => {
|
|
const errorText = JSON.stringify({
|
|
type: "provider",
|
|
code: "rate_limited",
|
|
message: "Rate limit exceeded for your organization",
|
|
})
|
|
await chatWith(page, {
|
|
status: 200,
|
|
contentType: "text/event-stream",
|
|
body: `data: {"type":"start"}\n\ndata: ${JSON.stringify({ type: "error", errorText })}\n\ndata: [DONE]\n\n`,
|
|
})
|
|
await expect(
|
|
page.getByText("The provider is limiting requests"),
|
|
).toBeVisible({ timeout: 15000 })
|
|
// The site's own tokens-per-minute toast
|
|
await expect(page.getByText("Rate limit reached")).toHaveCount(0)
|
|
})
|
|
|
|
test("a refused server key shows only the quota hint and a settings button", async ({
|
|
page,
|
|
}) => {
|
|
// What the chat route streams when the server's key gets a 403, e.g.
|
|
// after a daily spend cap blocked it
|
|
const errorText = JSON.stringify({
|
|
type: "provider",
|
|
code: "server_key_forbidden",
|
|
message: "",
|
|
})
|
|
await chatWith(page, {
|
|
status: 200,
|
|
contentType: "text/event-stream",
|
|
body: `data: {"type":"start"}\n\ndata: ${JSON.stringify({ type: "error", errorText })}\n\ndata: [DONE]\n\n`,
|
|
})
|
|
await expect(
|
|
page.getByText("Today's free quota is used up", { exact: false }),
|
|
).toBeVisible({ timeout: 15000 })
|
|
await expect(page.getByText("The provider returned an error")).toHaveCount(
|
|
0,
|
|
)
|
|
await page.getByRole("button", { name: "Open model settings" }).click()
|
|
// A server model answered: settings opens on the models tab's list
|
|
const dialog = page.getByRole("dialog", { name: "Settings" })
|
|
await expect(dialog).toBeVisible()
|
|
await expect(
|
|
dialog.getByRole("heading", { name: "Models", exact: true }),
|
|
).toBeVisible()
|
|
await expect(dialog.getByText("Use your own API key")).toBeVisible()
|
|
})
|