mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-12 12:39:52 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
257 lines
10 KiB
TypeScript
257 lines
10 KiB
TypeScript
import { renderHook } from "@testing-library/react"
|
|
import { describe, expect, it, vi } from "vitest"
|
|
|
|
const page = (cells: string) =>
|
|
`<mxfile><diagram id="p" name="Page-1"><mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/>${cells}</root></mxGraphModel></diagram></mxfile>`
|
|
const box = (id: string) =>
|
|
`<mxCell id="${id}" value="${id}" vertex="1" parent="1"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
|
|
// The first edit's result is loaded (the ref has it); the chartXML state
|
|
// has not caught up yet
|
|
const BEFORE_FIRST_EDIT = page(box("a"))
|
|
const AFTER_FIRST_EDIT = page(box("a") + box("b"))
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
loadDiagram: vi.fn((_xml: string, ..._rest: unknown[]) => null),
|
|
// The canvas for a test that needs another one
|
|
canvas: null as string | null,
|
|
}))
|
|
|
|
vi.mock("@/contexts/diagram-context", () => ({
|
|
useDiagram: () => ({
|
|
chartXML: mocks.canvas ?? BEFORE_FIRST_EDIT,
|
|
chartXMLRef: { current: mocks.canvas ?? AFTER_FIRST_EDIT },
|
|
loadDiagram: mocks.loadDiagram,
|
|
}),
|
|
}))
|
|
|
|
import { useDiagramStreaming } from "@/components/chat/use-diagram-streaming"
|
|
|
|
describe("the streaming preview of a second edit", () => {
|
|
it("starts from the first edit's result", () => {
|
|
const editDiagramOriginalXmlRef = { current: new Map<string, string>() }
|
|
const messages = [
|
|
{
|
|
id: "m1",
|
|
role: "assistant",
|
|
parts: [
|
|
{
|
|
type: "tool-edit_diagram",
|
|
toolCallId: "edit-2",
|
|
state: "input-streaming",
|
|
input: {
|
|
operations: [
|
|
{
|
|
operation: "add",
|
|
cell_id: "c",
|
|
new_xml: box("c"),
|
|
},
|
|
],
|
|
},
|
|
},
|
|
],
|
|
},
|
|
] as any
|
|
renderHook(() =>
|
|
useDiagramStreaming({
|
|
messages,
|
|
processedToolCallsRef: { current: new Set() },
|
|
editDiagramOriginalXmlRef,
|
|
loadedMessageIdsRef: { current: new Set() },
|
|
}),
|
|
)
|
|
expect(editDiagramOriginalXmlRef.current.get("edit-2")).toBe(
|
|
AFTER_FIRST_EDIT,
|
|
)
|
|
})
|
|
})
|
|
|
|
describe("the streaming preview of display_diagram", () => {
|
|
it("expands the named styles and adds the defaults to the cells so far", () => {
|
|
mocks.loadDiagram.mockClear()
|
|
// A complete definition and cell, then a cell still being written
|
|
const xml = `<mxStyle name="blue" value="fillColor=#dae8fc;strokeColor=#6c8ebf;"/>
|
|
<mxCell id="a" value="a" style="rounded=1;blue;" vertex="1" parent="1"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>
|
|
<mxCell id="b" value="b" style="blue;" vertex="1" parent="1"><mxGeometry x="0" y="0" wid`
|
|
const messages = [
|
|
{
|
|
id: "m1",
|
|
role: "assistant",
|
|
parts: [
|
|
{
|
|
type: "tool-display_diagram",
|
|
toolCallId: "draw-1",
|
|
state: "input-streaming",
|
|
input: { xml },
|
|
},
|
|
],
|
|
},
|
|
] as any
|
|
renderHook(() =>
|
|
useDiagramStreaming({
|
|
messages,
|
|
processedToolCallsRef: { current: new Set() },
|
|
editDiagramOriginalXmlRef: { current: new Map() },
|
|
loadedMessageIdsRef: { current: new Set() },
|
|
}),
|
|
)
|
|
expect(mocks.loadDiagram).toHaveBeenCalledTimes(1)
|
|
const loaded = mocks.loadDiagram.mock.calls[0][0]
|
|
expect(loaded).toContain(
|
|
'style="rounded=1;fillColor=#dae8fc;strokeColor=#6c8ebf;whiteSpace=wrap;html=1;"',
|
|
)
|
|
expect(loaded).not.toContain("mxStyle")
|
|
expect(loaded).not.toContain('id="b"')
|
|
})
|
|
|
|
it("fixes an unescaped & and HTML in a label, as the final diagram does", () => {
|
|
mocks.loadDiagram.mockClear()
|
|
const xml = `<mxCell id="a" value="R & D <b>team</b>" vertex="1" parent="1"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
renderHook(() =>
|
|
useDiagramStreaming({
|
|
messages: [
|
|
{
|
|
id: "m1",
|
|
role: "assistant",
|
|
parts: [
|
|
{
|
|
type: "tool-display_diagram",
|
|
toolCallId: "draw-2",
|
|
state: "input-streaming",
|
|
input: { xml },
|
|
},
|
|
],
|
|
},
|
|
] as any,
|
|
processedToolCallsRef: { current: new Set() },
|
|
editDiagramOriginalXmlRef: { current: new Map() },
|
|
loadedMessageIdsRef: { current: new Set() },
|
|
}),
|
|
)
|
|
expect(mocks.loadDiagram).toHaveBeenCalledTimes(1)
|
|
const loaded = mocks.loadDiagram.mock.calls[0][0]
|
|
expect(loaded).toContain('value="R & D <b>team</b>"')
|
|
})
|
|
})
|
|
|
|
describe("the streaming preview of edit_diagram", () => {
|
|
it("adds the default styles to the cell being added, like the final edit", () => {
|
|
mocks.loadDiagram.mockClear()
|
|
const messages = [
|
|
{
|
|
id: "m1",
|
|
role: "assistant",
|
|
parts: [
|
|
{
|
|
type: "tool-edit_diagram",
|
|
toolCallId: "edit-3",
|
|
state: "input-streaming",
|
|
input: {
|
|
operations: [
|
|
{
|
|
operation: "add",
|
|
cell_id: "c",
|
|
new_xml: box("c").replace(
|
|
'vertex="1"',
|
|
'style="rounded=1;" vertex="1"',
|
|
),
|
|
},
|
|
],
|
|
},
|
|
},
|
|
],
|
|
},
|
|
] as any
|
|
renderHook(() =>
|
|
useDiagramStreaming({
|
|
messages,
|
|
processedToolCallsRef: { current: new Set() },
|
|
editDiagramOriginalXmlRef: { current: new Map() },
|
|
loadedMessageIdsRef: { current: new Set() },
|
|
}),
|
|
)
|
|
expect(mocks.loadDiagram).toHaveBeenCalledTimes(1)
|
|
expect(mocks.loadDiagram.mock.calls[0][0]).toContain(
|
|
'style="rounded=1;whiteSpace=wrap;html=1;"',
|
|
)
|
|
})
|
|
})
|
|
|
|
describe("the streaming preview on the model's page", () => {
|
|
const box2 = (id: string, parent = "1") =>
|
|
`<mxCell id="${id}" value="${id}" vertex="1" parent="${parent}"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
// Page A has an edge "g"; on page B, "g" is a shape on layer "L"
|
|
const twoPages = `<mxfile><diagram id="pa" name="A"><mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/>${box2("s")}${box2("t")}<mxCell id="g" edge="1" parent="1" source="s" target="t"><mxGeometry relative="1" as="geometry"/></mxCell></root></mxGraphModel></diagram><diagram id="pb" name="B"><mxGraphModel><root><mxCell id="0"/><mxCell id="L" parent="0"/>${box2("g", "L")}</root></mxGraphModel></diagram></mxfile>`
|
|
const cellOn = (xml: string, pageId: string, id: string) =>
|
|
new DOMParser()
|
|
.parseFromString(xml, "text/xml")
|
|
.querySelector(`diagram[id="${pageId}"] mxCell[id="${id}"]`)
|
|
const stream = (part: object) =>
|
|
renderHook(() =>
|
|
useDiagramStreaming({
|
|
messages: [
|
|
{ id: "m1", role: "assistant", parts: [part] },
|
|
] as any,
|
|
processedToolCallsRef: { current: new Set() },
|
|
editDiagramOriginalXmlRef: { current: new Map() },
|
|
loadedMessageIdsRef: { current: new Set() },
|
|
turnPageIdRef: { current: "pb" },
|
|
}),
|
|
)
|
|
|
|
it("applies an edit to that page, with its layer and its edges", () => {
|
|
mocks.loadDiagram.mockClear()
|
|
mocks.canvas = twoPages
|
|
try {
|
|
stream({
|
|
type: "tool-edit_diagram",
|
|
toolCallId: "edit-p",
|
|
state: "input-streaming",
|
|
input: {
|
|
operations: [
|
|
{
|
|
operation: "add",
|
|
cell_id: "c",
|
|
new_xml:
|
|
'<mxCell id="c" value="c" x="10" y="10" w="80" h="40"/>',
|
|
},
|
|
{
|
|
operation: "add",
|
|
cell_id: "d",
|
|
new_xml:
|
|
'<mxCell id="d" value="d" parent="g" x="10" y="10" w="80" h="40"/>',
|
|
},
|
|
],
|
|
},
|
|
})
|
|
const loaded = mocks.loadDiagram.mock.calls.at(-1)?.[0] as string
|
|
expect(cellOn(loaded, "pb", "c")?.getAttribute("parent")).toBe("L")
|
|
expect(cellOn(loaded, "pb", "d")?.getAttribute("style")).toContain(
|
|
"whiteSpace=wrap",
|
|
)
|
|
expect(cellOn(loaded, "pa", "c")).toBeNull()
|
|
} finally {
|
|
mocks.canvas = null
|
|
}
|
|
})
|
|
|
|
it("draws display_diagram's cells on that page", () => {
|
|
mocks.loadDiagram.mockClear()
|
|
mocks.canvas = twoPages
|
|
try {
|
|
stream({
|
|
type: "tool-display_diagram",
|
|
toolCallId: "draw-p",
|
|
state: "input-streaming",
|
|
input: { xml: box2("n") },
|
|
})
|
|
const loaded = mocks.loadDiagram.mock.calls.at(-1)?.[0] as string
|
|
expect(cellOn(loaded, "pb", "n")).not.toBeNull()
|
|
expect(cellOn(loaded, "pb", "g")).toBeNull()
|
|
expect(cellOn(loaded, "pa", "g")).not.toBeNull()
|
|
} finally {
|
|
mocks.canvas = null
|
|
}
|
|
})
|
|
})
|