Files
next-ai-draw-io/tests/unit/chat-route-errors.test.ts
T
Dayuan Jiang 60105ddb51 refactor: remove dead code and over-engineering found by two audits (#986)
## Problem

Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.

## Change

Every item below was either approved one by one or covered by "fix all of the others".

- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.

Source lines: 74,983 before, 67,418 after (excluding lockfiles).

The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).

## Testing

- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
2026-10-12 12:35:55 +09:00

239 lines
8.3 KiB
TypeScript

// @vitest-environment node
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
// No DNS in tests: only loopback addresses are private
vi.mock("@/lib/ssrf-protection", async (importOriginal) => ({
...(await importOriginal<typeof import("@/lib/ssrf-protection")>()),
isPrivateUrl: async (url: string) =>
/^https?:\/\/(127\.0\.0\.1|localhost)\b/.test(url),
}))
import { POST as chat } from "@/app/api/chat/route"
const ENV = [
"AI_PROVIDER",
"AI_MODEL",
"OPENAI_API_KEY",
"OLLAMA_BASE_URL",
"OLLAMA_API_KEY",
"NEXT_AI_DRAWIO_DESKTOP",
]
beforeEach(() => {
for (const k of ENV) vi.stubEnv(k, undefined)
})
afterEach(() => {
vi.unstubAllGlobals()
})
/** Every provider request answers with this status and text */
const providerAnswers = (status: number, body: string) =>
vi.stubGlobal(
"fetch",
vi.fn(
async () =>
new Response(body, {
status,
headers: { "Content-Type": "application/json" },
}),
),
)
/** The error text the chat panel gets from the stream */
async function streamedError(headers: Record<string, string>) {
const res = await chat(
new Request("http://localhost/api/chat", {
method: "POST",
headers: { "Content-Type": "application/json", ...headers },
body: JSON.stringify({
messages: [
{
id: "u1",
role: "user",
parts: [{ type: "text", text: "Draw two boxes" }],
},
],
xml: "",
}),
}),
)
const text = await res.text()
const line = text.split("\n").find((l) => l.includes('"type":"error"'))
return line ? JSON.parse(JSON.parse(line.slice(6)).errorText).message : ""
}
describe("provider error texts in the stream", () => {
it("shows the user's own local Ollama error in the desktop app", async () => {
process.env.NEXT_AI_DRAWIO_DESKTOP = "1"
process.env.AI_PROVIDER = "ollama"
process.env.AI_MODEL = "llama3"
// Ollama is not running
vi.stubGlobal(
"fetch",
vi.fn(async () => {
throw Object.assign(new TypeError("fetch failed"), {
cause: new Error("connect ECONNREFUSED 127.0.0.1:11434"),
})
}),
)
expect(await streamedError({})).toMatch(
/127\.0\.0\.1:11434|fetch failed/,
)
// The SDK retries a refused connection twice, waiting between
}, 20_000)
it("shows the server's keyless Ollama error on the web too", async () => {
// No key, no money involved; round three hid this text
process.env.AI_PROVIDER = "ollama"
process.env.AI_MODEL = "llama3"
process.env.OLLAMA_BASE_URL = "http://ollama.internal:11434/api"
vi.stubGlobal(
"fetch",
vi.fn(async () => {
throw Object.assign(new TypeError("fetch failed"), {
cause: new Error("connect ECONNREFUSED 10.0.0.9:11434"),
})
}),
)
expect(await streamedError({})).not.toBe(
"The provider returned an error.",
)
}, 20_000)
it("shows EdgeOne's own daily quota explanation", async () => {
// The function answers 429, which the SDK retries with a wait;
// the status does not decide whether the text is shown
providerAnswers(
400,
JSON.stringify({
error: {
message:
"The daily public quota has been exhausted. After deployment, you can enjoy a personal daily exclusive quota.",
},
}),
)
expect(
await streamedError({
"x-ai-provider": "edgeone",
"x-ai-model": "@tx/deepseek-ai/deepseek-v3-0324",
}),
).toMatch(/daily public quota/)
})
it("hides the provider's text on the server's own key", async () => {
process.env.AI_PROVIDER = "openai"
process.env.AI_MODEL = "gpt-5.5"
process.env.OPENAI_API_KEY = "server-key"
providerAnswers(
403,
JSON.stringify({
error: { message: "Organization org-operator is suspended" },
}),
)
const message = await streamedError({})
expect(message).not.toMatch(/org-operator/)
// A 403 on the server's key gets its own hint and no message
expect(message).toBe("")
})
})
describe("the output cap", () => {
it("holds for the server's own keyless endpoints too", async () => {
vi.stubEnv("MAX_OUTPUT_TOKENS", "8000")
const sent: string[] = []
vi.stubGlobal(
"fetch",
vi.fn(async (_url: string, init?: RequestInit) => {
sent.push(String(init?.body ?? ""))
return new Response("{}", { status: 400 })
}),
)
const res = await chat(
new Request("http://localhost/api/chat", {
method: "POST",
headers: {
"Content-Type": "application/json",
"x-ai-provider": "ollama",
"x-ai-base-url": "http://127.0.0.1:11434/api",
"x-ai-model": "llama3",
"x-max-output-tokens": "200000",
},
body: JSON.stringify({
messages: [
{
id: "u1",
role: "user",
parts: [{ type: "text", text: "Draw" }],
},
],
xml: "",
}),
}),
)
await res.text()
expect(sent[0]).toContain('"max_output_tokens":8000')
})
})
describe("a tool call that never got its result", () => {
it("is left out of the prompt instead of failing every later message", async () => {
// Stop while the screenshot check ran left display_diagram without
// a result, and the chat was saved like that
process.env.AI_PROVIDER = "openai"
process.env.AI_MODEL = "gpt-5.5"
process.env.OPENAI_API_KEY = "server-key"
const sent: string[] = []
vi.stubGlobal(
"fetch",
vi.fn(async (_url: string, init?: RequestInit) => {
sent.push(String(init?.body ?? ""))
return new Response(
JSON.stringify({ error: { message: "x" } }),
{
status: 400,
headers: { "Content-Type": "application/json" },
},
)
}),
)
const res = await chat(
new Request("http://localhost/api/chat", {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({
messages: [
{
id: "u1",
role: "user",
parts: [{ type: "text", text: "Draw a box" }],
},
{
id: "a1",
role: "assistant",
parts: [
{
type: "tool-display_diagram",
toolCallId: "call-without-result",
state: "input-available",
input: { xml: "<mxCell/>" },
},
],
},
{
id: "u2",
role: "user",
parts: [{ type: "text", text: "Make it red" }],
},
],
xml: "",
}),
}),
)
await res.text()
// The request reached the model, without the unanswered call
expect(sent).toHaveLength(1)
expect(sent[0]).toContain("Make it red")
expect(sent[0]).not.toContain("call-without-result")
})
})