mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
222 lines
6.7 KiB
TypeScript
222 lines
6.7 KiB
TypeScript
// Declarative registry of the general env vars editable in the admin panel.
|
|
// Drives both server-side validation (app/api/admin/settings) and UI
|
|
// rendering (app/[lang]/admin). Keys are exactly the env var names.
|
|
//
|
|
// AI providers and models are managed separately in the panel's Models
|
|
// section (lib/admin/providers.ts), not here.
|
|
//
|
|
// Not listed here (and therefore rejected by the API):
|
|
// - NEXT_PUBLIC_* vars: baked into the client bundle at build time
|
|
// - ADMIN_PASSWORD / SETTINGS_FILE: bootstrap values, env-only to avoid lockout
|
|
// - Per-provider reasoning/thinking tuning vars: env-only (see env.example)
|
|
|
|
type SettingType = "string" | "secret" | "number" | "boolean"
|
|
|
|
export interface SettingDef {
|
|
key: string
|
|
group: string
|
|
type: SettingType
|
|
label: string
|
|
description?: string
|
|
min?: number
|
|
max?: number
|
|
placeholder?: string
|
|
// Built-in default applied at runtime when the value is unset, so the UI
|
|
// can reflect actual behavior (e.g. ALLOW_PRIVATE_URLS defaults to "true").
|
|
default?: string
|
|
// Value is only picked up at process start (module-load readers)
|
|
restartRequired?: boolean
|
|
}
|
|
|
|
export interface SettingGroup {
|
|
id: string
|
|
title: string
|
|
description: string
|
|
// Optional sections gated by an on/off switch in the panel; fields are
|
|
// grayed out until enabled. Starts on when any field is already set.
|
|
toggleable?: boolean
|
|
}
|
|
|
|
export const SETTING_GROUPS: SettingGroup[] = [
|
|
{
|
|
id: "generation",
|
|
title: "Generation",
|
|
description: "Output parameters applied to all chat requests.",
|
|
},
|
|
{
|
|
id: "access",
|
|
title: "Access Control",
|
|
description: "Restrict who can use this deployment.",
|
|
},
|
|
{
|
|
id: "features",
|
|
title: "Features",
|
|
description: "Optional features and security toggles.",
|
|
},
|
|
{
|
|
id: "observability",
|
|
title: "Observability",
|
|
description: "Langfuse tracing for LLM calls.",
|
|
toggleable: true,
|
|
},
|
|
{
|
|
id: "quota",
|
|
title: "Quota & Rate Limits",
|
|
description:
|
|
"Per-IP usage limits. Enforcement requires a DynamoDB table.",
|
|
toggleable: true,
|
|
},
|
|
]
|
|
|
|
export const SETTINGS_REGISTRY: SettingDef[] = [
|
|
// ── Generation ───────────────────────────────────────────────────
|
|
{
|
|
key: "TEMPERATURE",
|
|
group: "generation",
|
|
type: "number",
|
|
label: "Temperature",
|
|
description:
|
|
"Leave unset for reasoning models that reject temperature.",
|
|
min: 0,
|
|
max: 2,
|
|
},
|
|
{
|
|
key: "MAX_OUTPUT_TOKENS",
|
|
group: "generation",
|
|
type: "number",
|
|
label: "Max Output Tokens",
|
|
min: 1,
|
|
},
|
|
|
|
// ── Access Control ───────────────────────────────────────────────
|
|
{
|
|
key: "ACCESS_CODE_LIST",
|
|
group: "access",
|
|
type: "string",
|
|
label: "Access Codes",
|
|
description:
|
|
"Comma-separated list. Users must enter one to chat. Empty = open access.",
|
|
placeholder: "code1,code2",
|
|
},
|
|
|
|
// ── Features ─────────────────────────────────────────────────────
|
|
{
|
|
key: "ENABLE_VLM_VALIDATION",
|
|
group: "features",
|
|
type: "boolean",
|
|
label: "VLM Diagram Validation",
|
|
description:
|
|
"Visually validate generated diagrams with a vision model.",
|
|
},
|
|
{
|
|
key: "VALIDATION_MODEL",
|
|
group: "features",
|
|
type: "string",
|
|
label: "Validation Model",
|
|
description: "Falls back to the default AI model when empty.",
|
|
},
|
|
{
|
|
key: "VALIDATION_TIMEOUT",
|
|
group: "features",
|
|
type: "number",
|
|
label: "Validation Timeout (ms)",
|
|
min: 1000,
|
|
},
|
|
{
|
|
key: "ALLOW_PRIVATE_URLS",
|
|
group: "features",
|
|
type: "boolean",
|
|
label: "Allow Private URLs",
|
|
description:
|
|
"Turn off to block requests to private IPs and internal hostnames (SSRF protection).",
|
|
// Unset means allowed at runtime (ssrf-protection: !== "false")
|
|
default: "true",
|
|
},
|
|
|
|
// ── Observability ────────────────────────────────────────────────
|
|
{
|
|
key: "LANGFUSE_PUBLIC_KEY",
|
|
group: "observability",
|
|
type: "string",
|
|
label: "Langfuse Public Key",
|
|
placeholder: "pk-lf-…",
|
|
restartRequired: true,
|
|
},
|
|
{
|
|
key: "LANGFUSE_SECRET_KEY",
|
|
group: "observability",
|
|
type: "secret",
|
|
label: "Langfuse Secret Key",
|
|
restartRequired: true,
|
|
},
|
|
{
|
|
key: "LANGFUSE_BASEURL",
|
|
group: "observability",
|
|
type: "string",
|
|
label: "Langfuse Base URL",
|
|
placeholder: "https://cloud.langfuse.com",
|
|
restartRequired: true,
|
|
},
|
|
|
|
// ── Quota ────────────────────────────────────────────────────────
|
|
{
|
|
key: "DAILY_REQUEST_LIMIT",
|
|
group: "quota",
|
|
type: "number",
|
|
label: "Daily Request Limit",
|
|
description: "Per IP per day.",
|
|
min: 1,
|
|
},
|
|
{
|
|
key: "DAILY_TOKEN_LIMIT",
|
|
group: "quota",
|
|
type: "number",
|
|
label: "Daily Token Limit",
|
|
description: "Per IP per day.",
|
|
min: 1,
|
|
},
|
|
{
|
|
key: "TPM_LIMIT",
|
|
group: "quota",
|
|
type: "number",
|
|
label: "Tokens Per Minute",
|
|
min: 1,
|
|
},
|
|
{
|
|
key: "DYNAMODB_QUOTA_TABLE",
|
|
group: "quota",
|
|
type: "string",
|
|
label: "DynamoDB Table",
|
|
description: "Quota enforcement is disabled when empty.",
|
|
restartRequired: true,
|
|
},
|
|
{
|
|
key: "DYNAMODB_REGION",
|
|
group: "quota",
|
|
type: "string",
|
|
label: "DynamoDB Region",
|
|
placeholder: "ap-northeast-1",
|
|
restartRequired: true,
|
|
},
|
|
{
|
|
key: "QUOTA_TIMEZONE",
|
|
group: "quota",
|
|
type: "string",
|
|
label: "Quota Timezone",
|
|
description: "Timezone for the daily reset boundary.",
|
|
placeholder: "UTC",
|
|
restartRequired: true,
|
|
},
|
|
]
|
|
|
|
export const SETTINGS_BY_KEY: Map<string, SettingDef> = new Map(
|
|
SETTINGS_REGISTRY.map((def) => [def.key, def]),
|
|
)
|
|
|
|
export const SETTINGS_BY_GROUP: Map<string, SettingDef[]> = new Map(
|
|
SETTING_GROUPS.map((g) => [
|
|
g.id,
|
|
SETTINGS_REGISTRY.filter((d) => d.group === g.id),
|
|
]),
|
|
)
|