Files
next-ai-draw-io/tests/unit/chat-route-quota.test.ts
T
Dayuan Jiang 60105ddb51 refactor: remove dead code and over-engineering found by two audits (#986)
## Problem

Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.

## Change

Every item below was either approved one by one or covered by "fix all of the others".

- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.

Source lines: 74,983 before, 67,418 after (excluding lockfiles).

The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).

## Testing

- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
2026-10-12 12:35:55 +09:00

223 lines
7.3 KiB
TypeScript

// @vitest-environment node
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
// Quota on, and every check answers that the daily limit is used up
const quota = vi.hoisted(() => ({ checks: 0 }))
vi.mock("@/lib/dynamo-quota-manager", () => ({
isQuotaEnabled: () => true,
checkAndIncrementRequest: async () => {
quota.checks++
return {
allowed: false,
error: "Daily limit reached",
type: "request",
used: 10,
limit: 10,
}
},
recordTokenUsage: async () => {},
}))
// No DNS in tests: only loopback addresses are private
vi.mock("@/lib/ssrf-protection", async (importOriginal) => ({
...(await importOriginal<typeof import("@/lib/ssrf-protection")>()),
isPrivateUrl: async (url: string) =>
/^https?:\/\/(127\.0\.0\.1|localhost)\b/.test(url),
}))
import { POST as chat } from "@/app/api/chat/route"
beforeEach(() => {
vi.stubEnv("AI_PROVIDER", "openai")
vi.stubEnv("AI_MODEL", "gpt-5.5")
vi.stubEnv("OPENAI_API_KEY", "server-key")
quota.checks = 0
// No request may reach a provider
vi.stubGlobal(
"fetch",
vi.fn(async () => {
throw new Error("no network in tests")
}),
)
})
afterEach(() => {
vi.unstubAllGlobals()
})
const send = (headers: Record<string, string>) =>
chat(
new Request("http://localhost/api/chat", {
method: "POST",
headers: {
"Content-Type": "application/json",
"x-forwarded-for": "203.0.113.7",
...headers,
},
body: JSON.stringify({
messages: [
{
id: "u1",
role: "user",
parts: [{ type: "text", text: "Draw two boxes" }],
},
],
xml: "",
}),
}),
)
describe("chat quota", () => {
it("counts a request whose key header the provider never reads", async () => {
// OpenAI ignores the AWS key, so this runs on the server's key
const res = await send({
"x-ai-provider": "openai",
"x-aws-access-key-id": "x",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("does not count a request on the user's own key", async () => {
const res = await send({
"x-ai-provider": "openai",
"x-ai-api-key": "user-key",
"x-ai-model": "gpt-5.5",
})
expect(res.status).not.toBe(429)
expect(quota.checks).toBe(0)
})
it("counts the server's keyless Ollama and EdgeOne", async () => {
vi.stubEnv("AI_PROVIDER", "ollama")
vi.stubEnv("AI_MODEL", "llama3.2")
vi.stubEnv("OLLAMA_BASE_URL", "http://ollama.internal:11434/api")
expect((await send({})).status).toBe(429)
expect(
(
await send({
"x-ai-provider": "edgeone",
"x-ai-model": "@tx/deepseek-ai/deepseek-v3-0324",
})
).status,
).toBe(429)
expect(quota.checks).toBe(2)
})
it("counts EdgeOne with a key header it never reads", async () => {
const res = await send({
"x-ai-provider": "edgeone",
"x-ai-api-key": "ignored",
"x-ai-model": "@tx/deepseek-ai/deepseek-v3-0324",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("counts Ollama at a private address, the server's network", async () => {
const res = await send({
"x-ai-provider": "ollama",
"x-ai-base-url": "http://127.0.0.1:11434/api",
"x-ai-model": "llama3.2",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("counts the server's network whatever key header comes along", async () => {
// A keyless Ollama or a local SGLang ignores a dummy key
for (const headers of [
{
"x-ai-provider": "ollama",
"x-ai-base-url": "http://127.0.0.1:11434/api",
"x-ai-api-key": "dummy",
"x-ai-model": "llama3.2",
},
{
"x-ai-provider": "openai",
"x-ai-base-url": "http://127.0.0.1:30000/v1",
"x-ai-api-key": "dummy",
"x-ai-model": "m",
},
]) {
expect((await send(headers)).status).toBe(429)
}
expect(quota.checks).toBe(2)
})
it("does not count a provider that never uses the base URL header", async () => {
// Bedrock on the user's own AWS keys goes to AWS, whatever the
// leftover base URL says (with a key header too, so the request gets
// past the custom URL check to the quota decision)
const res = await send({
"x-ai-provider": "bedrock",
"x-ai-model": "amazon.nova-lite-v1:0",
"x-ai-base-url": "http://127.0.0.1:8080",
"x-ai-api-key": "leftover",
"x-aws-access-key-id": "id",
"x-aws-secret-access-key": "secret",
"x-aws-region": "us-east-1",
})
expect(res.status).not.toBe(429)
expect(quota.checks).toBe(0)
})
it("counts EdgeOne even with a base URL header", async () => {
const res = await send({
"x-ai-provider": "edgeone",
"x-ai-model": "@tx/deepseek-ai/deepseek-v3-0324",
"x-ai-base-url": "https://this-site.example/api/edgeai",
})
expect(res.status).toBe(429)
expect(quota.checks).toBe(1)
})
it("never counts in the desktop app, where every endpoint is the user's", async () => {
vi.stubEnv("NEXT_AI_DRAWIO_DESKTOP", "1")
const res = await send({
"x-ai-provider": "ollama",
"x-ai-base-url": "http://127.0.0.1:11434/api",
"x-ai-model": "llama3.2",
})
expect(res.status).not.toBe(429)
expect(quota.checks).toBe(0)
})
it("does not count Ollama on the user's own server", async () => {
const res = await send({
"x-ai-provider": "ollama",
"x-ai-base-url": "https://ollama.example.com/api",
"x-ai-model": "llama3.2",
})
expect(res.status).not.toBe(429)
expect(quota.checks).toBe(0)
})
})
describe("request checks", () => {
it("refuses an AWS region that is not a region name", async () => {
vi.stubEnv("AI_PROVIDER", "bedrock")
vi.stubEnv("AI_MODEL", "amazon.nova-lite-v1:0")
const res = await send({
"x-aws-region": "us-east-1.attacker.example/",
})
expect(res.status).toBe(400)
expect(await res.text()).toMatch(/Invalid AWS region/)
expect(fetch).not.toHaveBeenCalled()
})
})
describe("server model allowlist", () => {
it("runs AI_MODEL only on the server's AI_PROVIDER", async () => {
// Another provider's server key must not run it
vi.stubEnv("AI_GATEWAY_API_KEY", "server-gateway-key")
const res = await send({
"x-ai-provider": "gateway",
"x-ai-model": "gpt-5.5",
})
expect(res.status).toBe(400)
expect(await res.text()).toMatch(/not available on this server/)
expect(quota.checks).toBe(0)
})
})