Files
next-ai-draw-io/tests/unit/api-access-code.test.ts
T
Dayuan Jiang 60105ddb51 refactor: remove dead code and over-engineering found by two audits (#986)
## Problem

Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.

## Change

Every item below was either approved one by one or covered by "fix all of the others".

- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.

Source lines: 74,983 before, 67,418 after (excluding lockfiles).

The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).

## Testing

- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
2026-10-12 12:35:55 +09:00

155 lines
4.9 KiB
TypeScript

// @vitest-environment node
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
import { POST as parseUrl } from "@/app/api/parse-url/route"
import { POST as validateDiagram } from "@/app/api/validate-diagram/route"
import { POST as validateModel } from "@/app/api/validate-model/route"
import { POST as verifyAccessCode } from "@/app/api/verify-access-code/route"
import { checkAccessCode } from "@/lib/access-code"
// Treat every URL as public so no test hits DNS
vi.mock("@/lib/ssrf-protection", async (importOriginal) => ({
...(await importOriginal<typeof import("@/lib/ssrf-protection")>()),
isPrivateUrl: async () => false,
}))
function post(path: string, body: unknown, accessCode?: string): Request {
return new Request(`http://localhost${path}`, {
method: "POST",
headers: {
"Content-Type": "application/json",
...(accessCode ? { "x-access-code": accessCode } : {}),
},
body: JSON.stringify(body),
})
}
beforeEach(() => {
vi.stubEnv("ACCESS_CODE_LIST", "secret, other")
})
afterEach(() => {
vi.unstubAllGlobals()
})
describe("checkAccessCode", () => {
it("passes when no access codes are configured", () => {
vi.stubEnv("ACCESS_CODE_LIST", undefined)
expect(checkAccessCode(post("/x", {}))).toBeNull()
})
it("rejects a missing or wrong code and accepts a listed one", () => {
expect(checkAccessCode(post("/x", {}))?.status).toBe(401)
expect(checkAccessCode(post("/x", {}, "nope"))?.status).toBe(401)
expect(checkAccessCode(post("/x", {}, "other"))).toBeNull()
})
})
describe("routes that spend server resources require the access code", () => {
it("parse-url", async () => {
const res = await parseUrl(
post("/api/parse-url", { url: "https://example.com" }),
)
expect(res.status).toBe(401)
})
it("validate-diagram", async () => {
const res = await validateDiagram(
post("/api/validate-diagram", {
imageData: "data:image/png;base64,AAAA",
}),
)
expect(res.status).toBe(401)
})
it("validate-model", async () => {
const res = await validateModel(
post("/api/validate-model", {
provider: "openai",
apiKey: "sk",
modelId: "m",
}),
)
expect(res.status).toBe(401)
})
it("verify-access-code", async () => {
const bad = await verifyAccessCode(post("/api/verify-access-code", {}))
expect(bad.status).toBe(401)
expect((await bad.json()).valid).toBe(false)
const good = await verifyAccessCode(
post("/api/verify-access-code", {}, "secret"),
)
expect((await good.json()).valid).toBe(true)
})
})
describe("size limits", () => {
it("parse-url stops reading a body over the download limit", async () => {
const chunk = new Uint8Array(1024 * 1024)
let sent = 0
const body = new ReadableStream<Uint8Array>({
pull(controller) {
sent++
controller.enqueue(chunk)
},
})
vi.stubGlobal(
"fetch",
vi.fn(
async () =>
new Response(body, {
headers: { "content-type": "text/html" },
}),
),
)
const res = await parseUrl(
post("/api/parse-url", { url: "https://example.com" }, "secret"),
)
expect(res.status).toBe(413)
expect(sent).toBeLessThan(10)
})
it("validate-diagram rejects oversized image data", async () => {
const imageData = `data:image/png;base64,${"A".repeat(6 * 1024 * 1024)}`
const res = await validateDiagram(
post("/api/validate-diagram", { imageData }, "secret"),
)
expect(res.status).toBe(413)
})
})
describe("validate-model redirects", () => {
it("refuses redirects when private URLs are blocked", async () => {
vi.stubEnv("ALLOW_PRIVATE_URLS", "false")
vi.stubGlobal(
"fetch",
vi.fn(
async () =>
new Response(null, {
status: 302,
headers: { location: "http://169.254.169.254/" },
}),
),
)
const res = await validateModel(
post(
"/api/validate-model",
{
provider: "openai",
apiKey: "sk",
modelId: "m",
baseUrl: "https://attacker.example/v1",
},
"secret",
),
)
const data = await res.json()
expect(data.valid).toBe(false)
expect(data.error).toMatch(/Redirects are not allowed/)
expect(fetch).toHaveBeenCalledTimes(1)
})
})