mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-12 12:39:52 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
146 lines
4.1 KiB
TypeScript
146 lines
4.1 KiB
TypeScript
import { LangfuseClient } from "@langfuse/client"
|
|
import { observe, updateActiveTrace } from "@langfuse/tracing"
|
|
import * as api from "@opentelemetry/api"
|
|
import { randomUUID } from "crypto"
|
|
|
|
// Singleton LangfuseClient instance for direct API calls
|
|
let langfuseClient: LangfuseClient | null = null
|
|
|
|
type IngestionBatch = Parameters<
|
|
LangfuseClient["api"]["ingestion"]["batch"]
|
|
>[0]["batch"]
|
|
|
|
// Attach a score to the session's most recent chat trace. When the session
|
|
// has no trace yet, a fallbackTrace creates a standalone trace to carry the
|
|
// score; without one the score is skipped. Returns whether a score was written.
|
|
export async function scoreLatestTrace(
|
|
langfuse: LangfuseClient,
|
|
opts: {
|
|
sessionId: string
|
|
name: string
|
|
value: number
|
|
comment: string
|
|
fallbackTrace?: {
|
|
name: string
|
|
userId: string
|
|
input: unknown
|
|
metadata: Record<string, unknown>
|
|
}
|
|
},
|
|
): Promise<boolean> {
|
|
const { sessionId, name, value, comment, fallbackTrace } = opts
|
|
const traces = await langfuse.api.trace.list({ sessionId, limit: 1 })
|
|
let traceId = traces.data?.[0]?.id
|
|
const timestamp = new Date().toISOString()
|
|
const batch: IngestionBatch = []
|
|
|
|
if (!traceId) {
|
|
if (!fallbackTrace) return false
|
|
traceId = randomUUID()
|
|
batch.push({
|
|
type: "trace-create",
|
|
id: randomUUID(),
|
|
timestamp,
|
|
body: { id: traceId, sessionId, ...fallbackTrace, timestamp },
|
|
})
|
|
}
|
|
batch.push({
|
|
type: "score-create",
|
|
id: randomUUID(),
|
|
timestamp,
|
|
body: { id: randomUUID(), traceId, name, value, comment },
|
|
})
|
|
await langfuse.api.ingestion.batch({ batch })
|
|
return true
|
|
}
|
|
|
|
export function getLangfuseClient(): LangfuseClient | null {
|
|
if (!process.env.LANGFUSE_PUBLIC_KEY || !process.env.LANGFUSE_SECRET_KEY) {
|
|
return null
|
|
}
|
|
|
|
if (!langfuseClient) {
|
|
langfuseClient = new LangfuseClient({
|
|
publicKey: process.env.LANGFUSE_PUBLIC_KEY,
|
|
secretKey: process.env.LANGFUSE_SECRET_KEY,
|
|
baseUrl: process.env.LANGFUSE_BASEURL,
|
|
})
|
|
}
|
|
|
|
return langfuseClient
|
|
}
|
|
|
|
// Check if Langfuse is configured (both keys required)
|
|
function isLangfuseEnabled(): boolean {
|
|
return !!(
|
|
process.env.LANGFUSE_PUBLIC_KEY && process.env.LANGFUSE_SECRET_KEY
|
|
)
|
|
}
|
|
|
|
// Update trace with input data at the start of request
|
|
export function setTraceInput(params: {
|
|
input: string
|
|
sessionId?: string
|
|
userId?: string
|
|
}) {
|
|
if (!isLangfuseEnabled()) return
|
|
|
|
updateActiveTrace({
|
|
name: "chat",
|
|
input: params.input,
|
|
sessionId: params.sessionId,
|
|
userId: params.userId,
|
|
})
|
|
}
|
|
|
|
// Update trace with output and end the span
|
|
// Note: AI SDK 6 telemetry automatically reports token usage on its spans,
|
|
// so we only need to set the output text and close our wrapper span
|
|
export function setTraceOutput(output: string) {
|
|
if (!isLangfuseEnabled()) return
|
|
|
|
updateActiveTrace({ output })
|
|
endTrace()
|
|
}
|
|
|
|
// End the observe() wrapper span (AI SDK creates its own child spans with usage).
|
|
// It uses endOnExit: false, so every request path has to end it, or the trace
|
|
// is never exported: stream finish, stream error/abort, and early returns.
|
|
export function endTrace() {
|
|
if (!isLangfuseEnabled()) return
|
|
|
|
const activeSpan = api.trace.getActiveSpan()
|
|
if (activeSpan) {
|
|
activeSpan.end()
|
|
}
|
|
}
|
|
|
|
// Get telemetry config for streamText
|
|
export function getTelemetryConfig(params: {
|
|
sessionId?: string
|
|
userId?: string
|
|
}) {
|
|
if (!isLangfuseEnabled()) return undefined
|
|
|
|
return {
|
|
isEnabled: true,
|
|
recordInputs: true,
|
|
recordOutputs: true,
|
|
metadata: {
|
|
sessionId: params.sessionId,
|
|
userId: params.userId,
|
|
},
|
|
}
|
|
}
|
|
|
|
// Wrap a handler with Langfuse observe
|
|
export function wrapWithObserve<T>(
|
|
handler: (req: Request) => Promise<T>,
|
|
): (req: Request) => Promise<T> {
|
|
if (!isLangfuseEnabled()) {
|
|
return handler
|
|
}
|
|
|
|
return observe(handler, { name: "chat", endOnExit: false })
|
|
}
|