mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-13 04:59:51 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
143 lines
6.1 KiB
TypeScript
143 lines
6.1 KiB
TypeScript
import pako from "pako"
|
|
import { describe, expect, it } from "vitest"
|
|
import {
|
|
pageModelXml,
|
|
pageSelectorFor,
|
|
placeOnPage,
|
|
replacePageModel,
|
|
} from "@/lib/diagram-pages"
|
|
|
|
const box = (id: string) =>
|
|
`<mxCell id="${id}" value="${id}" vertex="1" parent="1"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
const model = (cells: string) =>
|
|
`<mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/>${cells}</root></mxGraphModel>`
|
|
const page = (id: string, cells: string) =>
|
|
`<diagram id="${id}" name="Page ${id}">${model(cells)}</diagram>`
|
|
const packedPage = (id: string, cells: string) => {
|
|
const packed = Buffer.from(
|
|
pako.deflateRaw(encodeURIComponent(model(cells))),
|
|
).toString("base64")
|
|
return `<diagram id="${id}" name="Page ${id}">${packed}</diagram>`
|
|
}
|
|
const TWO_PAGES = `<mxfile vars="{"x":"1"}">${page("a", box("A"))}${page("b", box("B"))}</mxfile>`
|
|
|
|
const pagesOf = (xml: string) =>
|
|
Array.from(
|
|
new DOMParser()
|
|
.parseFromString(xml, "text/xml")
|
|
.getElementsByTagName("diagram"),
|
|
).map((d) => ({
|
|
id: d.getAttribute("id"),
|
|
name: d.getAttribute("name"),
|
|
cells: Array.from(d.getElementsByTagName("mxCell"))
|
|
.map((c) => c.getAttribute("id"))
|
|
.filter((id) => id !== "0" && id !== "1"),
|
|
}))
|
|
|
|
describe("pageModelXml", () => {
|
|
it("gives the page with the id, and the first page without one", () => {
|
|
expect(pageModelXml(TWO_PAGES, "b")).toContain('id="B"')
|
|
expect(pageModelXml(TWO_PAGES, "b")).not.toContain('id="A"')
|
|
expect(pageModelXml(TWO_PAGES, null)).toContain('id="A"')
|
|
expect(pageModelXml(TWO_PAGES, "missing")).toContain('id="A"')
|
|
})
|
|
|
|
it("inflates a compressed page and passes a bare model through", () => {
|
|
const file = `<mxfile>${page("a", box("A"))}${packedPage("b", box("B"))}</mxfile>`
|
|
expect(pageModelXml(file, "b")).toContain('id="B"')
|
|
expect(pageModelXml(model(box("Z")), "b")).toBe(model(box("Z")))
|
|
expect(pageModelXml("<broken", "a")).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe("pageSelectorFor", () => {
|
|
it("selects the page only when the document has it", () => {
|
|
expect(pageSelectorFor(TWO_PAGES, "b")).toEqual({ page_id: "b" })
|
|
expect(pageSelectorFor(TWO_PAGES, "missing")).toEqual({})
|
|
expect(pageSelectorFor(TWO_PAGES, null)).toEqual({})
|
|
expect(pageSelectorFor(model(box("Z")), "b")).toEqual({})
|
|
})
|
|
})
|
|
|
|
describe("replacePageModel", () => {
|
|
it("replaces one page and keeps the others, the names and the variables", () => {
|
|
const result = replacePageModel(TWO_PAGES, "b", model(box("N")))
|
|
expect(pagesOf(result)).toEqual([
|
|
{ id: "a", name: "Page a", cells: ["A"] },
|
|
{ id: "b", name: "Page b", cells: ["N"] },
|
|
])
|
|
expect(result).toContain('vars="{"x":"1"}"')
|
|
})
|
|
|
|
it("falls back to the first page for an unknown or missing id", () => {
|
|
for (const id of ["missing", null]) {
|
|
const result = replacePageModel(TWO_PAGES, id, model(box("N")))
|
|
expect(pagesOf(result).map((p) => p.cells)).toEqual([["N"], ["B"]])
|
|
}
|
|
})
|
|
|
|
it("starts from the blank file when there is no document", () => {
|
|
for (const base of ["", "<mxGraphModel/>", "<broken"]) {
|
|
const result = replacePageModel(base, "any", model(box("N")))
|
|
expect(pagesOf(result)).toEqual([
|
|
{ id: "page-1", name: "Page-1", cells: ["N"] },
|
|
])
|
|
}
|
|
})
|
|
|
|
it("refuses anything but a model", () => {
|
|
expect(() => replacePageModel(TWO_PAGES, "a", "<root/>")).toThrow()
|
|
})
|
|
})
|
|
|
|
describe("placeOnPage", () => {
|
|
it("puts one page's worth of drawing on the model's page", () => {
|
|
const drawn = `<mxfile><diagram id="page-1" name="Page-1">${model(box("N"))}</diagram></mxfile>`
|
|
const result = placeOnPage(drawn, TWO_PAGES, "b")
|
|
expect(pagesOf(result)).toEqual([
|
|
{ id: "a", name: "Page a", cells: ["A"] },
|
|
{ id: "b", name: "Page b", cells: ["N"] },
|
|
])
|
|
})
|
|
|
|
it("applies the drawn file's variables, and keeps the canvas's otherwise", () => {
|
|
const withVars = `<mxfile vars="{"team":"New"}"><diagram id="p" name="P">${model(box("N"))}</diagram></mxfile>`
|
|
expect(placeOnPage(withVars, TWO_PAGES, "b")).toContain(
|
|
'vars="{"team":"New"}"',
|
|
)
|
|
const without = `<mxfile><diagram id="p" name="P">${model(box("N"))}</diagram></mxfile>`
|
|
expect(placeOnPage(without, TWO_PAGES, "b")).toContain(
|
|
'vars="{"x":"1"}"',
|
|
)
|
|
})
|
|
|
|
it("lets a drawing with several pages replace the document", () => {
|
|
const drawn = `<mxfile>${page("x", box("X"))}${page("y", box("Y"))}</mxfile>`
|
|
expect(pagesOf(placeOnPage(drawn, TWO_PAGES, "b"))).toEqual([
|
|
{ id: "x", name: "Page x", cells: ["X"] },
|
|
{ id: "y", name: "Page y", cells: ["Y"] },
|
|
])
|
|
// A canvas without variables leaves it as it is
|
|
const plainCanvas = `<mxfile>${page("a", box("A"))}</mxfile>`
|
|
expect(placeOnPage(drawn, plainCanvas, "a")).toBe(drawn)
|
|
})
|
|
|
|
it("gives a drawing with several pages the canvas's variables unless it has its own", () => {
|
|
const drawn = `<mxfile>${page("x", box("X"))}${page("y", box("Y"))}</mxfile>`
|
|
expect(placeOnPage(drawn, TWO_PAGES, "b")).toContain(
|
|
'vars="{"x":"1"}"',
|
|
)
|
|
const withVars = `<mxfile vars="{"team":"New"}">${page("x", box("X"))}${page("y", box("Y"))}</mxfile>`
|
|
const result = placeOnPage(withVars, TWO_PAGES, "b")
|
|
expect(result).toContain('vars="{"team":"New"}"')
|
|
expect(result).not.toContain(""x"")
|
|
})
|
|
|
|
it("draws on the blank file when the canvas is empty", () => {
|
|
const drawn = `<mxfile><diagram id="page-1" name="Page-1">${model(box("N"))}</diagram></mxfile>`
|
|
expect(pagesOf(placeOnPage(drawn, "", null))).toEqual([
|
|
{ id: "page-1", name: "Page-1", cells: ["N"] },
|
|
])
|
|
})
|
|
})
|