mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-12 12:39:52 +08:00
## Problem
Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests.
## Change
Every item below was either approved one by one or covered by "fix all of the others".
- **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency.
- **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs.
- **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default.
- **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog.
- **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages.
- **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client.
- **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before.
- **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`.
- **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`.
Source lines: 74,983 before, 67,418 after (excluding lockfiles).
The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`).
## Testing
- `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean
- `biome ci`: 0 errors (37 pre-existing warnings)
- Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed
- `next build`: clean
- Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main
240 lines
9.2 KiB
TypeScript
240 lines
9.2 KiB
TypeScript
"use client"
|
|
|
|
import { Bookmark, Edit2, Plus } from "lucide-react"
|
|
import { useEffect, useId, useState } from "react"
|
|
import { Button } from "@/components/ui/button"
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from "@/components/ui/dialog"
|
|
import { Input } from "@/components/ui/input"
|
|
import { Label } from "@/components/ui/label"
|
|
import { Switch } from "@/components/ui/switch"
|
|
import { Textarea } from "@/components/ui/textarea"
|
|
import { useDictionary } from "@/hooks/use-dictionary"
|
|
import {
|
|
createTemplate,
|
|
type Template,
|
|
updateTemplate,
|
|
} from "@/lib/template-storage"
|
|
|
|
interface TemplateFormDialogProps {
|
|
open: boolean
|
|
onOpenChange: (open: boolean) => void
|
|
onSuccess: () => void
|
|
/** The template to edit; without one the dialog creates a new template */
|
|
template?: Template | null
|
|
initialPrompt?: string
|
|
}
|
|
|
|
// One form for creating and editing a template
|
|
export function TemplateFormDialog({
|
|
open,
|
|
onOpenChange,
|
|
onSuccess,
|
|
template,
|
|
initialPrompt = "",
|
|
}: TemplateFormDialogProps) {
|
|
const dict = useDictionary()
|
|
const id = useId()
|
|
const isEdit = !!template
|
|
const [title, setTitle] = useState("")
|
|
const [description, setDescription] = useState("")
|
|
const [prompt, setPrompt] = useState("")
|
|
const [pinned, setPinned] = useState(false)
|
|
const [isSubmitting, setIsSubmitting] = useState(false)
|
|
const [error, setError] = useState<string | null>(null)
|
|
|
|
// Fill the form each time the dialog opens, dropping cancelled edits
|
|
useEffect(() => {
|
|
if (!open) return
|
|
setTitle(template?.title || "")
|
|
setDescription(template?.description || "")
|
|
setPrompt(template ? template.prompt || "" : initialPrompt)
|
|
setPinned(template?.pinned || false)
|
|
setError(null)
|
|
}, [open, template, initialPrompt])
|
|
|
|
const handleSubmit = async (e: React.FormEvent) => {
|
|
e.preventDefault()
|
|
// React submit events bubble through the portal; keep them away from
|
|
// the chat form this dialog may be rendered in
|
|
e.stopPropagation()
|
|
|
|
const trimmedPrompt = prompt.trim()
|
|
if (!trimmedPrompt) {
|
|
setError(dict.templates.promptRequired)
|
|
return
|
|
}
|
|
|
|
setIsSubmitting(true)
|
|
setError(null)
|
|
|
|
const failed = isEdit
|
|
? dict.templates.updateFailed
|
|
: dict.templates.createFailed
|
|
try {
|
|
const fields = {
|
|
prompt: trimmedPrompt,
|
|
description: description.trim() || undefined,
|
|
pinned,
|
|
}
|
|
// An emptied title keeps the old one when editing; a new template
|
|
// gets a default title from its prompt
|
|
const result = template
|
|
? await updateTemplate(template.id, {
|
|
...fields,
|
|
title: title.trim() || template.title,
|
|
})
|
|
: await createTemplate({
|
|
...fields,
|
|
title: title.trim() || undefined,
|
|
})
|
|
if (result) {
|
|
onSuccess()
|
|
onOpenChange(false)
|
|
} else {
|
|
setError(failed)
|
|
}
|
|
} catch (err) {
|
|
console.error("Failed to save template:", err)
|
|
setError(failed)
|
|
} finally {
|
|
setIsSubmitting(false)
|
|
}
|
|
}
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={onOpenChange}>
|
|
<DialogContent className="sm:max-w-[500px] overflow-hidden">
|
|
<form onSubmit={handleSubmit}>
|
|
<DialogHeader>
|
|
<DialogTitle className="flex items-center gap-2">
|
|
{isEdit ? (
|
|
<Edit2 className="w-5 h-5" />
|
|
) : (
|
|
<Plus className="w-5 h-5" />
|
|
)}
|
|
{isEdit
|
|
? dict.templates.editTitle
|
|
: dict.templates.createTitle}
|
|
</DialogTitle>
|
|
<DialogDescription>
|
|
{isEdit
|
|
? dict.templates.editDescription
|
|
: dict.templates.createDescription}
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
|
|
<div className="space-y-4 py-4">
|
|
{/* Prompt field - required */}
|
|
<div className="space-y-2">
|
|
<Label
|
|
htmlFor={`${id}-prompt`}
|
|
className="text-foreground"
|
|
>
|
|
{dict.templates.promptLabel}
|
|
<span className="text-destructive ml-1">*</span>
|
|
</Label>
|
|
<Textarea
|
|
id={`${id}-prompt`}
|
|
value={prompt}
|
|
onChange={(e) => setPrompt(e.target.value)}
|
|
placeholder={dict.templates.promptPlaceholder}
|
|
className="min-h-[100px] resize-none break-words"
|
|
required
|
|
/>
|
|
</div>
|
|
|
|
{/* Title field - optional */}
|
|
<div className="space-y-2">
|
|
<Label
|
|
htmlFor={`${id}-title`}
|
|
className="text-foreground"
|
|
>
|
|
{dict.templates.titleLabel}
|
|
</Label>
|
|
<Input
|
|
id={`${id}-title`}
|
|
value={title}
|
|
onChange={(e) => setTitle(e.target.value)}
|
|
placeholder={dict.templates.titlePlaceholder}
|
|
/>
|
|
<p className="text-xs text-muted-foreground">
|
|
{dict.templates.titleHint}
|
|
</p>
|
|
</div>
|
|
|
|
{/* Description field - optional */}
|
|
<div className="space-y-2">
|
|
<Label
|
|
htmlFor={`${id}-description`}
|
|
className="text-foreground"
|
|
>
|
|
{dict.templates.descriptionLabel}
|
|
</Label>
|
|
<Textarea
|
|
id={`${id}-description`}
|
|
value={description}
|
|
onChange={(e) => setDescription(e.target.value)}
|
|
placeholder={
|
|
dict.templates.descriptionPlaceholder
|
|
}
|
|
className="min-h-[60px] resize-none"
|
|
/>
|
|
</div>
|
|
|
|
{/* Pinned switch */}
|
|
<div className="flex items-center justify-between">
|
|
<div className="space-y-0.5">
|
|
<Label
|
|
htmlFor={`${id}-pinned`}
|
|
className="flex items-center gap-2 text-foreground"
|
|
>
|
|
<Bookmark className="w-4 h-4" />
|
|
{dict.templates.pinnedLabel}
|
|
</Label>
|
|
<p className="text-xs text-muted-foreground">
|
|
{dict.templates.pinnedHint}
|
|
</p>
|
|
</div>
|
|
<Switch
|
|
id={`${id}-pinned`}
|
|
checked={pinned}
|
|
onCheckedChange={setPinned}
|
|
/>
|
|
</div>
|
|
|
|
{/* Error message */}
|
|
{error && (
|
|
<p className="text-sm text-destructive">{error}</p>
|
|
)}
|
|
</div>
|
|
|
|
<DialogFooter>
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
onClick={() => onOpenChange(false)}
|
|
disabled={isSubmitting}
|
|
>
|
|
{dict.common.cancel}
|
|
</Button>
|
|
<Button type="submit" disabled={isSubmitting}>
|
|
{isSubmitting
|
|
? dict.common.loading
|
|
: isEdit
|
|
? dict.common.save
|
|
: dict.templates.createButton}
|
|
</Button>
|
|
</DialogFooter>
|
|
</form>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|