mirror of
https://github.com/DayuanJiang/next-ai-draw-io.git
synced 2026-10-10 03:29:50 +08:00
Found by the second PR review: - get_diagram with a page selector, or a rejected edit's error, counted the whole document as seen, so an edit on another page could overwrite the user's change there. A one-page view now counts for all pages only if the others are unchanged; otherwise the reply says to get them. - add_page accepted shapes with the root cell ids "0" and "1" and renamed them, breaking their edges. The check also missed ids on UserObject wrappers and ids written with spaces around the "=". - Root cells written over two lines were kept as an extra layer, cells with id = "a" did not count as cells, and CDATA text before a page's model passed the check although draw.io cannot open the page. - Auto-save cleanup deleted the user's own files that start with mcp-. Only names in the session id format are removed now. - Restoring a history entry dropped edits made in the browser since the last entry. They are added to history first. - A session whose state expired showed a blank page, and the next change overwrote its auto-save file. The saved file is loaded instead. - An edit on a page export's one-page projection, made before the real document was back, replaced the whole document. - A late sync reply could overwrite a newer edit: each sync export is numbered, and the server ignores replies older than the current state. - screenshot_diagram could return another session's image after start_session ran during its retries.
138 lines
5.4 KiB
TypeScript
138 lines
5.4 KiB
TypeScript
/**
|
|
* Tests for wrapCellsInModel: the model may send only the mxCell elements of
|
|
* a page, like in the web app, and the server adds the wrapper and root cells.
|
|
*/
|
|
|
|
import { beforeAll, describe, expect, it } from "vitest"
|
|
import { installDomPolyfill } from "../src/dom.ts"
|
|
|
|
beforeAll(() => {
|
|
installDomPolyfill()
|
|
})
|
|
|
|
import { prepareNewDiagram, reservedIdError } from "../src/new-diagram.ts"
|
|
import { hasCells, wrapCellsInModel } from "../src/pages.ts"
|
|
import { validateAndFixXml } from "../src/xml-validation.ts"
|
|
|
|
const A = `<mxCell id="2" value="A" vertex="1" parent="1"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
const B = `<mxCell id="3" value="B" vertex="1" parent="1"><mxGeometry x="200" y="0" width="80" height="40" as="geometry"/></mxCell>`
|
|
const ROOTS = `<mxCell id="0"/><mxCell id="1" parent="0"/>`
|
|
|
|
describe("wrapCellsInModel", () => {
|
|
it("wraps sibling cells so they pass validation", () => {
|
|
expect(validateAndFixXml(A + B).valid).toBe(false)
|
|
const wrapped = wrapCellsInModel(A + B)
|
|
expect(wrapped).toBe(
|
|
`<mxGraphModel><root>${ROOTS}${A}${B}</root></mxGraphModel>`,
|
|
)
|
|
expect(validateAndFixXml(wrapped).valid).toBe(true)
|
|
})
|
|
|
|
it("replaces root cells the model wrote itself", () => {
|
|
const wrapped = wrapCellsInModel(
|
|
`<mxCell id="0"></mxCell><mxCell id="1" parent="0"/>${A}`,
|
|
)
|
|
expect(wrapped.match(/id="0"/g)).toHaveLength(1)
|
|
expect(wrapped.match(/id="1"/g)).toHaveLength(1)
|
|
expect(wrapped).toContain(A)
|
|
})
|
|
|
|
it("unwraps a <root> and drops trailing provider tags", () => {
|
|
const wrapped = wrapCellsInModel(
|
|
`<root>${A}</root></invoke></function_calls>`,
|
|
)
|
|
expect(wrapped).toBe(
|
|
`<mxGraphModel><root>${ROOTS}${A}</root></mxGraphModel>`,
|
|
)
|
|
})
|
|
|
|
it("drops comments and text before the first cell", () => {
|
|
const expected = `<mxGraphModel><root>${ROOTS}${A}</root></mxGraphModel>`
|
|
expect(wrapCellsInModel(`Here is the diagram: ${A}`)).toBe(expected)
|
|
expect(wrapCellsInModel(`<!-- boxes -->\n${A}`)).toBe(expected)
|
|
})
|
|
|
|
it("leaves <mxGraphModel> and <mxfile> input unchanged", () => {
|
|
const model = `<mxGraphModel><root>${ROOTS}${A}</root></mxGraphModel>`
|
|
const file = `<mxfile><diagram id="p" name="P">${model}</diagram></mxfile>`
|
|
expect(wrapCellsInModel(model)).toBe(model)
|
|
expect(wrapCellsInModel(file)).toBe(file)
|
|
})
|
|
|
|
it("replaces root cells written over two lines", () => {
|
|
const wrapped = wrapCellsInModel(
|
|
`<mxCell id="0">\n</mxCell>\n<mxCell id="1" parent="0">\n</mxCell>\n${A}`,
|
|
)
|
|
expect(wrapped).toBe(
|
|
`<mxGraphModel><root>${ROOTS}${A}</root></mxGraphModel>`,
|
|
)
|
|
})
|
|
|
|
it("keeps a UserObject cell at the end", () => {
|
|
const wrapped = `<UserObject id="u" label="U"><mxCell vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell></UserObject>`
|
|
expect(wrapCellsInModel(A + wrapped)).toContain(wrapped)
|
|
expect(wrapCellsInModel(`${wrapped}</invoke>`)).toBe(
|
|
`<mxGraphModel><root>${ROOTS}${wrapped}</root></mxGraphModel>`,
|
|
)
|
|
})
|
|
})
|
|
|
|
describe("hasCells", () => {
|
|
it("counts cells written with single quotes", () => {
|
|
expect(hasCells(`<mxCell id='2' vertex='1' parent='1'/>`)).toBe(true)
|
|
expect(hasCells(`<mxCell id='0'/><mxCell id='1' parent='0'/>`)).toBe(
|
|
false,
|
|
)
|
|
})
|
|
|
|
it("counts cells with spaces around the =", () => {
|
|
expect(hasCells(`<mxCell id = "a" vertex="1" parent="1"/>`)).toBe(true)
|
|
expect(
|
|
hasCells(`<mxCell id = "0"/><mxCell id = "1" parent="0"/>`),
|
|
).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe("reservedIdError", () => {
|
|
it("finds a shape that uses a root cell id", () => {
|
|
expect(reservedIdError(A)).toBeNull()
|
|
expect(reservedIdError(ROOTS + A)).toBeNull()
|
|
expect(
|
|
reservedIdError(`<mxCell id = "1" vertex="1" parent="1"/>`),
|
|
).toMatch(/"0" and "1"/)
|
|
// A linked or labelled shape has its id on the wrapper
|
|
expect(
|
|
reservedIdError(
|
|
`<UserObject id="1" label="Docs"><mxCell vertex="1" parent="1"><mxGeometry as="geometry"/></mxCell></UserObject>`,
|
|
),
|
|
).toMatch(/"0" and "1"/)
|
|
// A whole model has its own root cells
|
|
expect(
|
|
reservedIdError(
|
|
`<mxGraphModel><root>${ROOTS}</root></mxGraphModel>`,
|
|
),
|
|
).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe("prepareNewDiagram", () => {
|
|
it("rejects a shape that uses a root cell id", () => {
|
|
// It would clash with the added root cell "1" and be renamed,
|
|
// which breaks the edges that point to it
|
|
const cells =
|
|
`<mxCell id="1" value="Start" vertex="1" parent="1"><mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>` +
|
|
`<mxCell id="3" edge="1" parent="1" source="1" target="2"><mxGeometry relative="1" as="geometry"/></mxCell>`
|
|
const out = prepareNewDiagram(cells)
|
|
expect(out.ok).toBe(false)
|
|
if (out.ok) return
|
|
expect(out.error).toMatch(/"0" and "1"/)
|
|
})
|
|
|
|
it("still accepts the root cells sent along with the shapes", () => {
|
|
const out = prepareNewDiagram(
|
|
`<mxCell id="0"/><mxCell id="1" parent="0"/>${A}`,
|
|
)
|
|
expect(out.ok).toBe(true)
|
|
})
|
|
})
|