test: read the failed edit's output without unsafe optional chaining

The model always got the first page and display_diagram replaced the whole
file with one page, so drawing on page 3 of a multi-page file deleted the
other pages (#241), and edits went to page 1 while the user looked at
another page.

Now a turn records the page the user is viewing when the message is sent.
That page's model goes to the model (also as previousXml, on regenerate and
in edit_diagram error messages), selected shapes are sent on any page,
display_diagram and append_diagram replace only that page (a drawing that
brings several pages still replaces the file), edit_diagram targets it,
and the streaming preview draws on it. Compact cells and default styles
take the layer and the edges of that page, in the preview and in
editDiagram. The editor bridge replaces the current page in place when the
other pages are unchanged, so Ctrl+Z undoes an AI change on a multi-page
file in one step; when a full load is needed, the user's page is shown
again afterwards. Version summaries and the compare dialog count the page
the change was made on.

.github/workflows/wait-for-confirmation.yml

@@ -1,55 +0,0 @@
-# Issues labelled "wait for confrim" are waiting for the reporter. After 15
-# days without activity the issue gets a reminder and the "no response"
-# label; after 15 more days it is closed. A reply from the reporter removes
-# both labels, so the issue shows up as needing the maintainer again.
-name: Wait for confirmation
-
-on:
-  schedule:
-    - cron: "17 3 * * *"
-  workflow_dispatch:
-  issue_comment:
-    types: [created]
-
-permissions:
-  issues: write
-
-jobs:
-  remind-and-close:
-    if: github.event_name != 'issue_comment'
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/stale@v9
-        with:
-          only-issue-labels: "wait for confrim"
-          days-before-issue-stale: 15
-          days-before-issue-close: 15
-          days-before-pr-stale: -1
-          days-before-pr-close: -1
-          stale-issue-label: "no response"
-          stale-issue-message: >-
-            Still there? We asked for more information 15 days ago. A reply
-            would help; if we hear nothing in another 15 days this issue will
-            be closed. It can be reopened any time.
-          close-issue-message: >-
-            No reply in 30 days, so this issue is closed for now. If the
-            problem is still there, reply or reopen it.
-          close-issue-reason: not_planned
-          remove-stale-when-updated: true
-
-  reporter-replied:
-    if: >-
-      github.event_name == 'issue_comment' &&
-      contains(github.event.issue.labels.*.name, 'wait for confrim') &&
-      github.event.comment.user.type != 'Bot' &&
-      !contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)
-    runs-on: ubuntu-latest
-    steps:
-      - name: The reporter answered, so the issue is the maintainer's again
-        run: >-
-          gh issue edit "$NUMBER" --repo "$REPO"
-          --remove-label "wait for confrim" --remove-label "no response"
-        env:
-          GH_TOKEN: ${{ github.token }}
-          NUMBER: ${{ github.event.issue.number }}
-          REPO: ${{ github.repository }}

tests/e2e/workspace.spec.ts

@@ -108,25 +108,6 @@ async function boxOf(locator: Locator) {
     return box
 }
 
-/**
- * Click the canvas where no shape is, to deselect: the corner of the
- * container farthest from the shape. A fixed spot near the top-left corner
- * is not safe, as a click on a shape may scroll it into that corner.
- */
-async function clickEmptyCanvas(page: Page, shape: Locator) {
-    const container = getIframeContent(page).locator(".geDiagramContainer")
-    const box = await boxOf(container)
-    const shapeBox = await boxOf(shape)
-    const shapeX = shapeBox.x + shapeBox.width / 2
-    const shapeY = shapeBox.y + shapeBox.height / 2
-    await container.click({
-        position: {
-            x: shapeX < box.x + box.width / 2 ? box.width - 20 : 20,
-            y: shapeY < box.y + box.height / 2 ? box.height - 20 : 20,
-        },
-    })
-}
-
 /** draw.io's own Undo button: draw.io sets "disabled" with nothing to undo */
 function drawioUndo(page: Page) {
     return getIframeContent(page).locator('.geSimpleMainMenu a[title="Undo"]')
@@ -4531,7 +4512,9 @@ test.describe("Edge cases", () => {
         })
         await sendMessage(page, "Make this red")
         // Deselected while the diagram exports
-        await clickEmptyCanvas(page, shape)
+        await canvas
+            .locator(".geDiagramContainer")
+            .click({ position: { x: 10, y: 10 } })
         await expect(chip).toHaveCount(0)
         await page.evaluate(() => (window as any).__releaseExports())
         await waitForCompleteCount(page, 2)