Compare commits

...

1 Commits

Author SHA1 Message Date
dayuan.jiang
015537e97d feat: expand PR review scope to catch more issues
- Add categories for scope creep, suspicious .gitignore additions, UI inconsistencies
- Change from 'be very selective' to 'report ALL issues found'
- Simplify DO NOT comment list to allow more actionable feedback
2025-11-29 11:36:42 +09:00

View File

@@ -86,7 +86,7 @@ jobs:
Then review the current diff for NEW issues only: Then review the current diff for NEW issues only:
Review this PR for ONLY these issues: Review this PR for these issues (report ALL that apply):
1. Bugs that would cause runtime errors or broken functionality 1. Bugs that would cause runtime errors or broken functionality
2. Security issues (exposed secrets, API key leaks) 2. Security issues (exposed secrets, API key leaks)
3. AI SDK misuse - specifically check for: 3. AI SDK misuse - specifically check for:
@@ -96,18 +96,19 @@ jobs:
- Tool definitions: Must use Zod schemas for inputSchema - Tool definitions: Must use Zod schemas for inputSchema
- Status handling: Check status (submitted/streaming/ready/error) before actions - Status handling: Check status (submitted/streaming/ready/error) before actions
- Stream cleanup: Call stop() when aborting streams - Stream cleanup: Call stop() when aborting streams
4. Unrelated changes that should be in separate PRs (scope creep)
5. Suspicious .gitignore additions or accidentally committed files
6. UI/UX inconsistencies (e.g., alignment issues)
When reviewing AI SDK usage, fetch https://ai-sdk.dev/docs/ to verify correct patterns. When reviewing AI SDK usage, fetch https://ai-sdk.dev/docs/ to verify correct patterns.
Key doc pages: /docs/ai-sdk-ui/chatbot, /docs/ai-sdk-core/generating-text, /docs/ai-sdk-core/tools-and-tool-calling Key doc pages: /docs/ai-sdk-ui/chatbot, /docs/ai-sdk-core/generating-text, /docs/ai-sdk-core/tools-and-tool-calling
DO NOT comment on: DO NOT comment on:
- Performance optimizations - Minor performance optimizations
- Code style or formatting - Code style preferences (unless clearly wrong)
- "Best practices" that don't affect functionality - Type annotations that don't affect functionality
- Type safety improvements
- Error handling additions
Use `mcp__github_inline_comment__create_inline_comment` for inline comments. Use `mcp__github_inline_comment__create_inline_comment` for inline comments.
Be very selective - if there are no real bugs, just say "LGTM" in a PR comment. Report ALL issues found - create multiple inline comments if needed. Only say "LGTM" if there are truly no issues.
claude_args: | claude_args: |
--allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh api:*),WebFetch(domain:ai-sdk.dev)" --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh api:*),WebFetch(domain:ai-sdk.dev)"