2 Commits

Include renames

Author	SHA1	Message	Date
Dayuan Jiang	60105ddb51	refactor: remove dead code and over-engineering found by two audits (#986) ... ## Problem Two audits of the repository (a workflow of finder, dedup and per-file verifier agents, run on 2026-10-11 against 1f4141e and again against 07f3e3c after a first round of refactoring) found dead code and features that were more machinery than the app needs: an Electron configuration-preset system with its own settings window, three copies of the about page, a hand-written `.env` parser, an "extended" system prompt nobody selected, two data migrations for formats from 2025-12 and 2026-01, a server-side example cache, type-to-confirm provider deletion, 81 unused dictionary keys, wrapper components around single call sites, and a long tail of unused exports, props, options and tests. ## Change Every item below was either approved one by one or covered by "fix all of the others". - **Electron:** the configuration-preset system is gone (settings window, preload, IPC, menu entry, dev watcher); `config-manager.ts` keeps only `userLocale`; `.env` files are parsed with `dotenv`. Entitlements file and a duplicate CI workflow removed; `test.yml` gets a type check and concurrency. - **Server:** no extended prompt, no example cache, no `ENABLE_HISTORY_XML_REPLACE`, no message metadata or `hasConfig`; the connection test is one shared helper; EdgeOne loses its mock branch and model aliases; `DEBUG_LLM_PAYLOAD` logs message structure instead of payloads; Langfuse scoring helper; `apiKeyEnv` arrays kept and documented in `env.example` and the provider docs. - **Pages:** one about page per language from a single component (old `/cn` and `/ja` URLs redirect with 308); layout uses `hasLocale`; the GitHub icon is a local component instead of `react-icons`; Cloudflare deploys without an R2 cache by default. - **Chat and canvas:** the legacy `diagramHistory` conversion, the localStorage chat migration and the templates storage are gone; `chat-engine` reads the diagram through the context's refs; the diagram context has one tagged export path (`requestTaggedExport` / `fetchDiagramXml`); the screenshot check uses fetch + JSON and `generateText` with `Output.object`; `load-diagram` accepts `<svg:svg>` and strips the XML prolog. - **Settings UI:** `model-selector` inlines its Dialog, Command and Tooltip; `ai-elements/model-selector`, `button-with-tooltip`, `error-toast` removed; no type-to-confirm, no footer, no `bedrockApiKey`; `use-model-config` loses the old-format migration; one reasoning component; the shimmer is CSS (no `motion`, no `@radix-ui/react-use-controllable-state`); 81 dictionary keys removed in all four languages. - **MCP server:** `registerTool` / `ok` / `fail` replace per-tool try/catch; `syncFromBrowser`, `commitDocument`, `describePages`; the hand-written XML syntax check, unused result fields, `pickPageSelector`, `expandStyles` and the `host` attribute handling are gone; tests get a shared `setup.ts` and drive the server through the SDK client. - **Prompt:** the web app's style rules come from the MCP drawing guide (`styleRules`), byte-identical to before. - **Tests:** shared e2e helpers (`openApp`, `sse`, `toolCallEvents`, `chunkedReplies`); placeholder specs dropped; `settings-review-fixes` split by topic; unit tests use `vi.stubEnv`. - **Dependencies removed:** `@xmldom/xmldom`, `remark-gfm`, `@anthropic-ai/tokenizer`, `@testing-library/user-event`, `concurrently`, `wait-on`, `eslint`, `eslint-config-next`, `@vitest/coverage-v8`, `shx`, `motion`, `@radix-ui/react-use-controllable-state`, `react-icons`. Source lines: 74,983 before, 67,418 after (excluding lockfiles). The last commit merges #984 (the canvas shell). Where the shell, the classic page or their tests depend on a wire format or signature this branch had changed, main's version wins (export fields of the poll response, `addHistory` signature); where main only extended code this branch restructured, main's change is carried into the new structure (`start_session`, `get_selection`, `prepareNewDiagram`, the diagram context's `requestExport`). ## Testing - `tsc --noEmit` for the web app, `packages/mcp-server`, its shell and `electron`: clean - `biome ci`: 0 errors (37 pre-existing warnings) - Root `vitest run`: 719 passed; `packages/mcp-server` `vitest run`: 372 passed - `next build`: clean - Playwright, whole web suite on the dev server (4 workers): 280 tests, 279 passed; `language.spec.ts` "a stale offer to switch without saving does nothing once a message is being sent" failed under parallel load and passed alone, as it does on main	2026-10-12 12:35:55 +09:00
Siddhant Shekharanddayuan.jiang	5c884766a8	feat(mcp): add multi-page (mxfile) support to MCP server (#862) ... * feat(mcp): add multi-page (mxfile) support The MCP server's write path could only address a single drawio page even though the underlying .drawio file format and the embedded editor both natively support multi-page documents. A user asking for "a second page with a CNN diagram" would hit the validator with the error "Expected closing tag </root> but found </mxCell>" because the validator assumed input was a bare <mxGraphModel> and could not walk past the <mxfile><diagram>...</diagram></mxfile> wrapper. This patch closes the gap end to end: * New helper module `pages.ts` centralises page CRUD (normalize, parse, list, find, add, rename, delete) so every layer agrees that the canonical in-memory shape is always <mxfile>. normalizeToMxfile and addPageToDoc both strip any leading <?xml ?> declaration before embedding a fragment inside <diagram> (the declaration is only valid at document start). addPageToDoc explicitly rejects full <mxfile> inputs so a caller cannot accidentally nest a document inside a page. * `xml-validation.ts` now detects an <mxfile> root and scopes the duplicate-id check per <diagram>. The legacy regex check would otherwise reject every multi-page doc, because cells "0" and "1" repeat in each page's <root> by design. The DOM-parse path is gated by a cheap regex pre-check so legacy bare <mxGraphModel> callers don't pay any extra cost. The autoFix duplicate-id rename step is also guarded against mxfile inputs — renaming those sentinel cells would silently break drawio's parent references. * `diagram-operations.ts` accepts an optional PageSelector. For <mxfile> input it resolves the page first and scopes all querySelectorAll calls to that page's <root>, so a delete on page 2's cell "2" no longer touches page 1's cell "2". * `create_new_diagram` accepts either a bare <mxGraphModel> (legacy, auto-wrapped into a single-page mxfile) or a full <mxfile> with N diagrams. All existing single-page callers keep working unchanged. * `edit_diagram`, `get_diagram`, and `export_diagram` gain optional `page_id` / `page_name` / `page_index` parameters. When omitted they target the first page — the "active by convention" default. Tool handlers with all-optional input schemas coalesce missing arguments via `input ?? {}` so a no-args MCP invocation can't crash on destructure before reaching the session-existence check. * New tools: `list_pages`, `add_page`, `rename_page`, `delete_page`. * Page-targeted PNG/SVG export uses a "load + export + restore" dance: the server projects the target page into a single-page <mxfile>, pushes it into the transient state so the browser reloads the iframe with just that page, waits for drawio to render (~3s), triggers the export, captures the data, and then restores the original multi-page document. The dance is wrapped in `try/finally` so the restore runs unconditionally — even if an exception is thrown mid-dance, the user's multi-tab view is recovered before the function returns. The earlier attempt to use drawio's `selectPage` postMessage was a no-op because drawio's JSON embed protocol does not expose that action — silently exporting whatever tab happened to be active. The load-export-restore approach trades a brief visible tab-flicker for correctness: the exported image is guaranteed to match the requested page. * Tool description strings reflect the multi-page semantics so the LLM client learns the new contract. * Package version bumped 0.2.0 → 0.3.0 (additive surface — four new tools, three extended input schemas, canonical XML shape change). * CI: `.github/workflows/test.yml` gains an explicit install + vitest run for the mcp-server package so the new multi-page invariants are covered by automation, not just local runs. Backward compatibility: every existing single-page caller continues to work without modification. The session.xml shape is normalised on every write, removing the wrapper-injection hack from the .drawio download path. Tests: 43 unit tests under `packages/mcp-server/tests/multi-page.test.ts` pin the validator's mxfile path, the page-scoped operations, the XML declaration-prefix handling for both normalizeToMxfile and addPageToDoc, addPageToDoc's rejection of full <mxfile> inputs, the single-page projection used by export_diagram (a direct regression test for the selectPage bug — two distinct page selectors must produce visually different projections), and the Transformer + CNN motivating scenario. A `tests/smoke.mjs` smoke test drives the built `dist/index.js` over JSON-RPC and asserts all 9 tools register with the right input schemas. Root vitest suite (107 tests) still green. * fix(mcp): rewrite page-targeted export browser-side; harden edit/get The page-targeted PNG/SVG export never worked: export_diagram swapped the live session to a single-page projection, slept 3s, then wrote the export flag onto a state object that setState() had already replaced in the store Map — so the browser never saw the request and every such export timed out. The swap+restore also clobbered concurrent edits. Move the projection entirely browser-side: requestExport() hands a single -page <mxfile> to the bridge via state.exportXml; the bridge loads it, lets draw.io render, exports, then reloads the user's real document. The canonical session state is never mutated, so there is no restore race and no fixed-delay guessing. The export poll now re-reads the live store entry each tick instead of a captured reference. autosave is suppressed and the version-bump reload is skipped while a projection is on screen; if no real document was captured, restore forces a server reload rather than leaving the iframe stuck on the projection. Also: - edit_diagram now returns isError on a page-level failure (selector matched no page / page has no <root>) instead of reporting success-with-warnings and persisting a no-op; the pre-edit history snapshot is taken only after that gate so a failed edit leaves no phantom undo entry. - edit_diagram/get_diagram re-normalise browser-pushed xml to mxfile so a bare <mxGraphModel> can't silently strip a multi-page document. - get_diagram now errors (instead of silently returning the full doc) when a selector is given but the session isn't a parseable mxfile. - page_id / page_name / add_page.id get .min(1) so empty strings can't silently target the first page. - Extract pages.ts:projectPage(), collapsing three copies of the parse→find→serialise projection logic in index.ts. - Replace the never-in-CI tests/smoke.mjs with tests/server-wiring.test.ts, which boots the server from source via tsx and runs under the existing vitest CI step. * chore(mcp): set version to 0.2.1 for release --------- Co-authored-by: dayuan.jiang <[email protected]>	2026-06-16 09:15:50 +09:00