fix: preserve message parts order in chat display (#151)

- Fix bug where text after tool calls was merged with initial text
- Group consecutive text/file parts into bubbles while keeping tools in order
- Parts now display as: plan -> tool_result -> additional text
- Remove debug logs from fixToolCallInputs function

Co-authored-by: dayuan.jiang <jiangdy@amazon.co.jp>
This commit is contained in:
Dayuan Jiang
2025-12-07 19:56:31 +09:00
committed by GitHub
parent 86420a42c6
commit 8c431ee6ed
2 changed files with 199 additions and 147 deletions

View File

@@ -67,41 +67,23 @@ function isMinimalDiagram(xml: string): boolean {
// Helper function to fix tool call inputs for Bedrock API // Helper function to fix tool call inputs for Bedrock API
// Bedrock requires toolUse.input to be a JSON object, not a string // Bedrock requires toolUse.input to be a JSON object, not a string
function fixToolCallInputs(messages: any[]): any[] { function fixToolCallInputs(messages: any[]): any[] {
return messages.map((msg, msgIndex) => { return messages.map((msg) => {
if (msg.role !== "assistant" || !Array.isArray(msg.content)) { if (msg.role !== "assistant" || !Array.isArray(msg.content)) {
return msg return msg
} }
const fixedContent = msg.content.map((part: any, partIndex: number) => { const fixedContent = msg.content.map((part: any) => {
if (part.type === "tool-call") { if (part.type === "tool-call") {
console.log(
`[fixToolCallInputs] msg[${msgIndex}].content[${partIndex}] tool-call:`,
{
toolName: part.toolName,
inputType: typeof part.input,
input: part.input,
},
)
if (typeof part.input === "string") { if (typeof part.input === "string") {
try { try {
const parsed = JSON.parse(part.input) const parsed = JSON.parse(part.input)
console.log(
`[fixToolCallInputs] Parsed string input to JSON:`,
parsed,
)
return { ...part, input: parsed } return { ...part, input: parsed }
} catch { } catch {
// If parsing fails, wrap the string in an object // If parsing fails, wrap the string in an object
console.log(
`[fixToolCallInputs] Failed to parse, wrapping in object`,
)
return { ...part, input: { rawInput: part.input } } return { ...part, input: { rawInput: part.input } }
} }
} }
// Input is already an object, but verify it's not null/undefined // Input is already an object, but verify it's not null/undefined
if (part.input === null || part.input === undefined) { if (part.input === null || part.input === undefined) {
console.log(
`[fixToolCallInputs] Input is null/undefined, using empty object`,
)
return { ...part, input: {} } return { ...part, input: {} }
} }
} }

View File

@@ -509,30 +509,85 @@ export function ChatMessageDisplay({
</div> </div>
</div> </div>
) : ( ) : (
/* Text content in bubble */ /* Render parts in order, grouping consecutive text/file parts into bubbles */
message.parts?.some( (() => {
(part) => const parts = message.parts || []
const groups: {
type: "content" | "tool"
parts: typeof parts
startIndex: number
}[] = []
parts.forEach((part, index) => {
const isToolPart =
part.type?.startsWith(
"tool-",
)
const isContentPart =
part.type === "text" || part.type === "text" ||
part.type === "file", part.type === "file"
) && (
if (isToolPart) {
groups.push({
type: "tool",
parts: [part],
startIndex: index,
})
} else if (isContentPart) {
const lastGroup =
groups[
groups.length - 1
]
if (
lastGroup?.type ===
"content"
) {
lastGroup.parts.push(
part,
)
} else {
groups.push({
type: "content",
parts: [part],
startIndex: index,
})
}
}
})
return groups.map(
(group, groupIndex) => {
if (group.type === "tool") {
return renderToolPart(
group
.parts[0] as ToolPartLike,
)
}
// Content bubble
return (
<div <div
key={`${message.id}-content-${group.startIndex}`}
className={`px-4 py-3 text-sm leading-relaxed ${ className={`px-4 py-3 text-sm leading-relaxed ${
message.role === "user" message.role ===
"user"
? "bg-primary text-primary-foreground rounded-2xl rounded-br-md shadow-sm" ? "bg-primary text-primary-foreground rounded-2xl rounded-br-md shadow-sm"
: message.role === : message.role ===
"system" "system"
? "bg-destructive/10 text-destructive border border-destructive/20 rounded-2xl rounded-bl-md" ? "bg-destructive/10 text-destructive border border-destructive/20 rounded-2xl rounded-bl-md"
: "bg-muted/60 text-foreground rounded-2xl rounded-bl-md" : "bg-muted/60 text-foreground rounded-2xl rounded-bl-md"
} ${message.role === "user" && isLastUserMessage && onEditMessage ? "cursor-pointer hover:opacity-90 transition-opacity" : ""}`} } ${message.role === "user" && isLastUserMessage && onEditMessage ? "cursor-pointer hover:opacity-90 transition-opacity" : ""} ${groupIndex > 0 ? "mt-3" : ""}`}
role={ role={
message.role === "user" && message.role ===
"user" &&
isLastUserMessage && isLastUserMessage &&
onEditMessage onEditMessage
? "button" ? "button"
: undefined : undefined
} }
tabIndex={ tabIndex={
message.role === "user" && message.role ===
"user" &&
isLastUserMessage && isLastUserMessage &&
onEditMessage onEditMessage
? 0 ? 0
@@ -555,8 +610,10 @@ export function ChatMessageDisplay({
}} }}
onKeyDown={(e) => { onKeyDown={(e) => {
if ( if (
(e.key === "Enter" || (e.key ===
e.key === " ") && "Enter" ||
e.key ===
" ") &&
message.role === message.role ===
"user" && "user" &&
isLastUserMessage && isLastUserMessage &&
@@ -572,20 +629,26 @@ export function ChatMessageDisplay({
} }
}} }}
title={ title={
message.role === "user" && message.role ===
"user" &&
isLastUserMessage && isLastUserMessage &&
onEditMessage onEditMessage
? "Click to edit" ? "Click to edit"
: undefined : undefined
} }
> >
{message.parts?.map( {group.parts.map(
(part, index) => { (
switch (part.type) { part,
case "text": partIndex,
) => {
if (
part.type ===
"text"
) {
return ( return (
<div <div
key={`${message.id}-text-${index}`} key={`${message.id}-text-${group.startIndex}-${partIndex}`}
className={`prose prose-sm max-w-none break-words [&>*:first-child]:mt-0 [&>*:last-child]:mb-0 ${ className={`prose prose-sm max-w-none break-words [&>*:first-child]:mt-0 [&>*:last-child]:mb-0 ${
message.role === message.role ===
"user" "user"
@@ -595,20 +658,34 @@ export function ChatMessageDisplay({
> >
<ReactMarkdown> <ReactMarkdown>
{ {
part.text (
part as {
text: string
}
)
.text
} }
</ReactMarkdown> </ReactMarkdown>
</div> </div>
) )
case "file": }
if (
part.type ===
"file"
) {
return ( return (
<div <div
key={`${message.id}-file-${part.url}`} key={`${message.id}-file-${group.startIndex}-${partIndex}`}
className="mt-2" className="mt-2"
> >
<Image <Image
src={ src={
part.url (
part as {
url: string
}
)
.url
} }
width={ width={
200 200
@@ -625,23 +702,16 @@ export function ChatMessageDisplay({
/> />
</div> </div>
) )
default:
return null
} }
return null
}, },
)} )}
</div> </div>
) )
)} },
{/* Tool calls outside bubble */}
{message.parts?.map((part) => {
if (part.type?.startsWith("tool-")) {
return renderToolPart(
part as ToolPartLike,
) )
} })()
return null )}
})}
{/* Action buttons for assistant messages */} {/* Action buttons for assistant messages */}
{message.role === "assistant" && ( {message.role === "assistant" && (
<div className="flex items-center gap-1 mt-2"> <div className="flex items-center gap-1 mt-2">