refactor: add shared fixtures and test.step() patterns

- Add tests/e2e/lib/fixtures.ts with shared test helpers
- Add tests/e2e/fixtures/diagrams.ts with XML test data
- Add expectBeforeAndAfterReload() helper for persistence tests
- Add test.step() for better test reporting in complex tests
- Consolidate mock helpers into fixtures module
- Reduce code duplication across 17 test files
This commit is contained in:
dayuan.jiang
2026-01-05 00:37:40 +09:00
parent 948cc4666d
commit 828bf43e31
19 changed files with 662 additions and 815 deletions

View File

@@ -1,46 +1,40 @@
import { expect, test } from "@playwright/test"
import { SINGLE_BOX_XML } from "./fixtures/diagrams"
import {
expect,
getChatInput,
getIframe,
sendMessage,
test,
} from "./lib/fixtures"
import { createMockSSEResponse } from "./lib/helpers"
test.describe("File Upload", () => {
test("upload button opens file picker", async ({ page }) => {
await page.goto("/", { waitUntil: "networkidle" })
await page
.locator("iframe")
.waitFor({ state: "visible", timeout: 30000 })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
// Find the upload button (image icon)
const uploadButton = page.locator(
'button[aria-label="Upload file"], button:has(svg.lucide-image)',
)
await expect(uploadButton.first()).toBeVisible({ timeout: 10000 })
// Click should trigger hidden file input
// Just verify the button is clickable
await expect(uploadButton.first()).toBeEnabled()
})
test("shows file preview after selecting image", async ({ page }) => {
await page.goto("/", { waitUntil: "networkidle" })
await page
.locator("iframe")
.waitFor({ state: "visible", timeout: 30000 })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
// Find the hidden file input
const fileInput = page.locator('input[type="file"]')
// Create a test image file
await fileInput.setInputFiles({
name: "test-image.png",
mimeType: "image/png",
buffer: Buffer.from(
// Minimal valid PNG (1x1 transparent pixel)
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==",
"base64",
),
})
// File input should have processed the file
// Check that no error toast appeared
await expect(
page.locator('[role="alert"][data-type="error"]'),
).not.toBeVisible({ timeout: 2000 })
@@ -48,13 +42,10 @@ test.describe("File Upload", () => {
test("can remove uploaded file", async ({ page }) => {
await page.goto("/", { waitUntil: "networkidle" })
await page
.locator("iframe")
.waitFor({ state: "visible", timeout: 30000 })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
const fileInput = page.locator('input[type="file"]')
// Upload a file
await fileInput.setInputFiles({
name: "test-image.png",
mimeType: "image/png",
@@ -64,17 +55,14 @@ test.describe("File Upload", () => {
),
})
// Wait for file preview or no error
await expect(
page.locator('[role="alert"][data-type="error"]'),
).not.toBeVisible({ timeout: 2000 })
// Find and click remove button if it exists (X icon)
const removeButton = page.locator(
'[data-testid="remove-file-button"], button[aria-label*="Remove"], button:has(svg.lucide-x)',
)
// Remove button feature may not exist in all versions - skip if not available
const removeButtonCount = await removeButton.count()
if (removeButtonCount === 0) {
test.skip()
@@ -82,7 +70,6 @@ test.describe("File Upload", () => {
}
await removeButton.first().click()
// Verify button is gone or file preview is removed
await expect(removeButton.first()).not.toBeVisible({ timeout: 2000 })
})
@@ -95,21 +82,17 @@ test.describe("File Upload", () => {
status: 200,
contentType: "text/event-stream",
body: createMockSSEResponse(
`<mxCell id="img" value="Diagram" style="rounded=1;" vertex="1" parent="1"><mxGeometry x="100" y="100" width="100" height="100" as="geometry"/></mxCell>`,
SINGLE_BOX_XML,
"Based on your image, here is a diagram:",
),
})
})
await page.goto("/", { waitUntil: "networkidle" })
await page
.locator("iframe")
.waitFor({ state: "visible", timeout: 30000 })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
const fileInput = page.locator('input[type="file"]')
const chatInput = page.locator('textarea[aria-label="Chat input"]')
// Upload a file
await fileInput.setInputFiles({
name: "architecture.png",
mimeType: "image/png",
@@ -119,29 +102,21 @@ test.describe("File Upload", () => {
),
})
// Type message and send
await chatInput.fill("Convert this to a diagram")
await chatInput.press("ControlOrMeta+Enter")
await sendMessage(page, "Convert this to a diagram")
// Wait for response
await expect(
page.locator('text="Based on your image, here is a diagram:"'),
).toBeVisible({ timeout: 15000 })
// Verify request was made (file should be in request body as base64)
expect(capturedRequest).not.toBeNull()
})
test("shows error for oversized file", async ({ page }) => {
await page.goto("/", { waitUntil: "networkidle" })
await page
.locator("iframe")
.waitFor({ state: "visible", timeout: 30000 })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
const fileInput = page.locator('input[type="file"]')
// Create a large file (> 2MB limit)
const largeBuffer = Buffer.alloc(3 * 1024 * 1024, "x") // 3MB
const largeBuffer = Buffer.alloc(3 * 1024 * 1024, "x")
await fileInput.setInputFiles({
name: "large-image.png",
@@ -149,8 +124,6 @@ test.describe("File Upload", () => {
buffer: largeBuffer,
})
// Should show error toast/message about file size
// The exact error message depends on the app implementation
await expect(
page.locator('[role="alert"], [data-sonner-toast]').first(),
).toBeVisible({ timeout: 5000 })
@@ -158,13 +131,10 @@ test.describe("File Upload", () => {
test("drag and drop file upload works", async ({ page }) => {
await page.goto("/", { waitUntil: "networkidle" })
await page
.locator("iframe")
.waitFor({ state: "visible", timeout: 30000 })
await getIframe(page).waitFor({ state: "visible", timeout: 30000 })
const chatForm = page.locator("form").first()
// Create a DataTransfer with a file
const dataTransfer = await page.evaluateHandle(() => {
const dt = new DataTransfer()
const file = new File(["test content"], "dropped-image.png", {
@@ -174,13 +144,9 @@ test.describe("File Upload", () => {
return dt
})
// Dispatch drag and drop events
await chatForm.dispatchEvent("dragover", { dataTransfer })
await chatForm.dispatchEvent("drop", { dataTransfer })
// Should not crash - verify page is still functional
await expect(
page.locator('textarea[aria-label="Chat input"]'),
).toBeVisible({ timeout: 3000 })
await expect(getChatInput(page)).toBeVisible({ timeout: 3000 })
})
})