fix(api): require access codes and limit sizes on helper routes

- Shared checkAccessCode for validate-diagram, validate-model, parse-url, verify-access-code
- parse-url: 5 MB streamed body limit; validate-diagram: 5 MB image limit
- validate-model refuses redirects when private URLs are blocked
- Admin settings state shared across module instances via globalThis
- Server model ids: unique slugs (non-ASCII names encoded), duplicates rejected
- Panel Bedrock credentials stored as ADMIN_AWS_* so the DynamoDB client keeps its own
- Locale redirect keeps basePath and query; EdgeOne function drops open CORS and checks the access code
- Providers payload reports whether .env sets a default model

lib/admin/providers.ts

@@ -2,6 +2,7 @@ import { z } from "zod"
 import {
     ProviderNameSchema,
     type ServerModelsConfig,
+    slugify,
 } from "@/lib/server-model-config"
 import {
     FIXED_CRED_PROVIDERS,
@@ -182,12 +183,15 @@ export function validateAdminProviders(
             return `${PROVIDER_INFO[single].label} is already configured in AI_MODELS_CONFIG / ai-models.json and shares global credentials. Manage it via the environment configuration instead.`
         }
     }
+    // Server model ids are built from the slugified name, so names must
+    // stay distinct after slugifying ("OpenAI" and "openai" would collide)
     const names = list.map((p) => displayName(p))
-    if (new Set(names).size !== names.length) {
-        return "Provider display names must be unique."
+    const slugs = names.map(slugify)
+    if (new Set(slugs).size !== slugs.length) {
+        return "Provider display names must be unique (ignoring case and punctuation)."
     }
-    const envNames = new Set(envProviders.map((p) => p.name))
-    const clash = names.find((n) => envNames.has(n))
+    const envSlugs = new Set(envProviders.map((p) => slugify(p.name)))
+    const clash = names.find((_, i) => envSlugs.has(slugs[i]))
     if (clash) {
         return `"${clash}" is already defined in AI_MODELS_CONFIG / ai-models.json. Use a different display name.`
     }
@@ -240,10 +244,14 @@ export function deriveEnvUpdates(
         indexByProvider.set(p.provider, index + 1)
 
         if (p.provider === "bedrock") {
-            if (p.awsAccessKeyId) updates.AWS_ACCESS_KEY_ID = p.awsAccessKeyId
+            // ADMIN_ names keep the standard AWS_* vars untouched, so other
+            // AWS clients (e.g. the DynamoDB quota table) keep their own
+            // credentials instead of picking up the panel's Bedrock keys
+            if (p.awsAccessKeyId)
+                updates.ADMIN_AWS_ACCESS_KEY_ID = p.awsAccessKeyId
             if (p.awsSecretAccessKey)
-                updates.AWS_SECRET_ACCESS_KEY = p.awsSecretAccessKey
-            if (p.awsRegion) updates.AWS_REGION = p.awsRegion
+                updates.ADMIN_AWS_SECRET_ACCESS_KEY = p.awsSecretAccessKey
+            if (p.awsRegion) updates.ADMIN_AWS_REGION = p.awsRegion
         } else if (p.provider === "vertexai") {
             if (p.vertexApiKey) updates.GOOGLE_VERTEX_API_KEY = p.vertexApiKey
             if (p.baseUrl) updates.GOOGLE_VERTEX_BASE_URL = p.baseUrl
@@ -284,6 +292,10 @@ function derivedEnvKeys(list: StoredAdminProvider[]): string[] {
         const index = indexByProvider.get(p.provider) ?? 0
         indexByProvider.set(p.provider, index + 1)
         if (p.provider === "bedrock") {
+            keys.add("ADMIN_AWS_ACCESS_KEY_ID")
+            keys.add("ADMIN_AWS_SECRET_ACCESS_KEY")
+            keys.add("ADMIN_AWS_REGION")
+            // Written by older versions; listed so the next save clears them
             keys.add("AWS_ACCESS_KEY_ID")
             keys.add("AWS_SECRET_ACCESS_KEY")
             keys.add("AWS_REGION")

lib/admin/settings.ts

@@ -10,13 +10,27 @@ interface SettingsFile {
     values: Record<string, string>
 }
 
-// Original env values snapshotted before the first overlay, so removing a
-// key from the settings file restores the env default. null = was unset.
-const originalEnv: Record<string, string | null> = {}
-// Keys currently overlaid, so we can restore ones removed from the file.
-let overlaidKeys = new Set<string>()
+interface SettingsState {
+    // Original env values snapshotted before the first overlay, so removing
+    // a key from the settings file restores the env default. null = was unset.
+    originalEnv: Record<string, string | null>
+    // Keys currently overlaid, so we can restore ones removed from the file.
+    overlaidKeys: Set<string>
+    cachedSettings: Record<string, string> | null
+}
 
-let cachedSettings: Record<string, string> | null = null
+// Kept on globalThis because the build can load this module more than once
+// (instrumentation.ts and the API routes get separate copies); per-module
+// state would make a route forget what instrumentation overlaid at startup.
+const globalState = globalThis as typeof globalThis & {
+    __adminSettingsState?: SettingsState
+}
+globalState.__adminSettingsState ??= {
+    originalEnv: {},
+    overlaidKeys: new Set(),
+    cachedSettings: null,
+}
+const state = globalState.__adminSettingsState
 
 export function getSettingsPath(): string {
     const custom = process.env.SETTINGS_FILE
@@ -25,7 +39,7 @@ export function getSettingsPath(): string {
 }
 
 export function loadSettings(): Record<string, string> {
-    if (cachedSettings) return cachedSettings
+    if (state.cachedSettings) return state.cachedSettings
     try {
         const raw = fs.readFileSync(getSettingsPath(), "utf8")
         const parsed = JSON.parse(raw) as SettingsFile
@@ -43,21 +57,22 @@ export function loadSettings(): Record<string, string> {
         for (const [key, value] of Object.entries(rawValues)) {
             if (typeof value === "string") values[key] = value
         }
-        cachedSettings = values
+        state.cachedSettings = values
     } catch (err: any) {
         if (err?.code !== "ENOENT") {
             console.error("[admin-settings] Failed to read settings file:", err)
         }
-        cachedSettings = {}
+        state.cachedSettings = {}
     }
-    return cachedSettings
+    return state.cachedSettings
 }
 
 export function applyToEnv(): void {
     const values = loadSettings()
+    const { originalEnv } = state
 
     // Restore env for keys that were overlaid before but are now gone
-    for (const key of overlaidKeys) {
+    for (const key of state.overlaidKeys) {
         if (!(key in values)) {
             const original = originalEnv[key]
             if (original === null) delete process.env[key]
@@ -72,12 +87,12 @@ export function applyToEnv(): void {
         process.env[key] = value
     }
 
-    overlaidKeys = new Set(Object.keys(values))
+    state.overlaidKeys = new Set(Object.keys(values))
 }
 
 // The effective env value if the file entry were removed (for fallback display)
 export function getEnvFallback(key: string): string | null {
-    if (overlaidKeys.has(key)) return originalEnv[key] ?? null
+    if (state.overlaidKeys.has(key)) return state.originalEnv[key] ?? null
     return process.env[key] ?? null
 }
 
@@ -101,7 +116,7 @@ export function saveSettings(updates: Record<string, string | null>): void {
     fs.writeFileSync(tmpPath, JSON.stringify(data, null, 2), { mode: 0o600 })
     fs.renameSync(tmpPath, filePath)
 
-    cachedSettings = current
+    state.cachedSettings = current
     applyToEnv()
 }
 
@@ -122,13 +137,13 @@ export function isSettingsWritable(): boolean {
 
 // Test-only: reset module state
 export function _resetForTests(): void {
-    cachedSettings = null
+    state.cachedSettings = null
     writableCache = null
-    for (const key of overlaidKeys) {
-        const original = originalEnv[key]
+    for (const key of state.overlaidKeys) {
+        const original = state.originalEnv[key]
         if (original === null) delete process.env[key]
         else if (original !== undefined) process.env[key] = original
     }
-    overlaidKeys = new Set()
-    for (const key of Object.keys(originalEnv)) delete originalEnv[key]
+    state.overlaidKeys = new Set()
+    state.originalEnv = {}
 }