i/OrbbecSDK_ROS2
1
0
Fork 0
mirror of https://github.com/orbbec/OrbbecSDK_ROS2.git synced 2026-10-10 22:49:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove redundant diagnostic cleanup from stopStreams()

Browse Source 
Diagnostic timer/updater lifecycle is now managed exclusively by clean(),
This commit is contained in:
slz
2026-07-02 11:06:07 +08:00
parent fdc0d1fe9c
commit 47f9d87b4d
2 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
orbbec_camera/include/orbbec_camera/ob_camera_node.h
+1 -1
View File
@@ -910,7 +910,7 @@ class OBCameraNode {
nlohmann::json filter_status_; nlohmann::json filter_status_;
std::string align_mode_ = "HW"; std::string align_mode_ = "HW";
std::unique_ptr<diagnostic_updater::Updater> diagnostic_updater_ = nullptr; std::unique_ptr<diagnostic_updater::Updater> diagnostic_updater_ = nullptr;
double diagnostic_period_ = 1.0; double diagnostic_period_ = 0.0;
bool enable_laser_ = false; bool enable_laser_ = false;
std::unique_ptr<ob::Align> align_filter_ = nullptr; std::unique_ptr<ob::Align> align_filter_ = nullptr;
OBStreamType align_target_stream_ = OB_STREAM_COLOR; OBStreamType align_target_stream_ = OB_STREAM_COLOR;
orbbec_camera/src/ob_camera_node.cpp
+1 -14
View File
@@ -3774,19 +3774,6 @@ void OBCameraNode::stopStreams() {
return; return;
} }
// Stop diagnostic timer first to prevent crashes during shutdown
try {
if (diagnostic_timer_) {
diagnostic_timer_->cancel();
diagnostic_timer_.reset();
}
if (diagnostic_updater_) {
diagnostic_updater_.reset();
}
} catch (...) {
// Ignore exceptions during diagnostic cleanup
}
// Mark pipeline as stopping to prevent new operations // Mark pipeline as stopping to prevent new operations
pipeline_started_.store(false); pipeline_started_.store(false);
@@ -4207,7 +4194,7 @@ void OBCameraNode::getParameters() {
setAndGetNodeParameter<std::string>(align_mode_, "align_mode", "HW"); setAndGetNodeParameter<std::string>(align_mode_, "align_mode", "HW");
align_mode_ = align_mode_ =
normalizeClosedSetParameterValue(logger_, "align_mode", align_mode_, {"HW", "SW"}, "HW"); normalizeClosedSetParameterValue(logger_, "align_mode", align_mode_, {"HW", "SW"}, "HW");
setAndGetNodeParameter<double>(diagnostic_period_, "diagnostic_period", 1.0); setAndGetNodeParameter<double>(diagnostic_period_, "diagnostic_period", 0.0);
setAndGetNodeParameter<bool>(enable_laser_, "enable_laser", true); setAndGetNodeParameter<bool>(enable_laser_, "enable_laser", true);
std::string align_target_stream_str_; std::string align_target_stream_str_;
setAndGetNodeParameter<std::string>(align_target_stream_str_, "align_target_stream", "COLOR"); setAndGetNodeParameter<std::string>(align_target_stream_str_, "align_target_stream", "COLOR");