From 288b9598383afb2d5af75b72191608fdd6e19fbd Mon Sep 17 00:00:00 2001 From: ob-yalian Date: Tue, 29 Sep 2026 21:06:10 +0800 Subject: [PATCH] fix: log current effective color MJPEG quality when out of range --- orbbec_camera/src/ob_camera_node.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/orbbec_camera/src/ob_camera_node.cpp b/orbbec_camera/src/ob_camera_node.cpp index 5ae61ac3..fadf639c 100644 --- a/orbbec_camera/src/ob_camera_node.cpp +++ b/orbbec_camera/src/ob_camera_node.cpp @@ -1495,6 +1495,9 @@ void OBCameraNode::setupDevices() { RCLCPP_ERROR(logger_, "color MJPEG quality value %d is out of range[%d,%d], please check the value", color_mjpeg_quality_, range.min, range.max); + TRY_EXECUTE_BLOCK(RCLCPP_INFO_STREAM( + logger_, + "Current color MJPEG quality: " << device_->getIntProperty(OB_PROP_MJPEG_QUALITY_INT))); } else { TRY_TO_SET_PROPERTY(setIntProperty, OB_PROP_MJPEG_QUALITY_INT, color_mjpeg_quality_); TRY_EXECUTE_BLOCK(RCLCPP_INFO_STREAM( @@ -7245,7 +7248,7 @@ bool OBCameraNode::decodeColorFrameToBuffer(const std::shared_ptr &fr target_buffer_size = &rgb_buffer_size_; } if (video_frame->getDataSize() > *target_buffer_size) { - delete[] (*target_buffer); + delete[](*target_buffer); *target_buffer_size = video_frame->getDataSize(); *target_buffer = new uint8_t[*target_buffer_size]; buffer = *target_buffer; @@ -8928,9 +8931,9 @@ void OBCameraNode::setFilterCallback(const std::shared_ptr if (request->filter_param.size() > 1) { temporal_filter->setDiffScale(request->filter_param[0]); temporal_filter->setWeight(request->filter_param[1]); - RCLCPP_INFO_STREAM( - logger_, "Set TemporalFilter params: " << "\ndiff_scale:" << request->filter_param[0] - << "\nweight:" << request->filter_param[1]); + RCLCPP_INFO_STREAM(logger_, "Set TemporalFilter params: " + << "\ndiff_scale:" << request->filter_param[0] + << "\nweight:" << request->filter_param[1]); temporal_filter_diff_threshold_ = request->filter_param[0]; temporal_filter_weight_ = request->filter_param[1]; } else {