mirror of
https://github.com/fawney19/Aether.git
synced 2026-10-10 03:09:50 +08:00
Restore authorized rule reveal, explicit full HTTP capture and retention, video task business fields, and valid payment URLs. Add opt-in credential preservation for trusted recovery, fix frontend type contracts and async races, and eliminate PostgreSQL test fixture resource leaks. Document audit coverage and successful fmt and CI-scoped Clippy checks.
152 lines
5.4 KiB
Rust
152 lines
5.4 KiB
Rust
use std::sync::Arc;
|
|
|
|
use aether_data::repository::provider_catalog::InMemoryProviderCatalogReadRepository;
|
|
use axum::body::Body;
|
|
use http::{HeaderMap, HeaderValue, Method, Request, StatusCode};
|
|
use http_body_util::BodyExt;
|
|
use serde_json::{json, Value};
|
|
|
|
use super::super::super::{build_router_with_state, sample_endpoint, sample_provider, AppState};
|
|
use crate::admin_api::{maybe_build_local_admin_response, AdminRouteRequest};
|
|
use crate::audit::AdminAuditEvent;
|
|
use crate::constants::{
|
|
GATEWAY_HEADER, TRUSTED_ADMIN_SESSION_ID_HEADER, TRUSTED_ADMIN_USER_ID_HEADER,
|
|
TRUSTED_ADMIN_USER_ROLE_HEADER,
|
|
};
|
|
use crate::control::resolve_public_request_context;
|
|
use crate::data::GatewayDataState;
|
|
use crate::tests::send_request;
|
|
|
|
fn seeded_state() -> AppState {
|
|
let mut endpoint = sample_endpoint(
|
|
"endpoint-rules",
|
|
"provider-rules",
|
|
"openai:chat",
|
|
"https://example.test",
|
|
);
|
|
endpoint.header_rules =
|
|
Some(json!([{"action": "set", "key": "x-auth", "value": "request-secret"}]));
|
|
endpoint.body_rules =
|
|
Some(json!([{"action": "set", "path": "auth.token", "value": "body-secret"}]));
|
|
endpoint.config = Some(json!({
|
|
"private_token": "unrelated-secret",
|
|
"response_header_rules": [{"action": "set", "key": "x-auth", "value": "response-secret"}]
|
|
}));
|
|
let repository = Arc::new(InMemoryProviderCatalogReadRepository::seed(
|
|
vec![sample_provider("provider-rules", "custom", 10)],
|
|
vec![endpoint],
|
|
vec![],
|
|
));
|
|
AppState::new().unwrap().with_data_state_for_tests(
|
|
GatewayDataState::with_provider_catalog_reader_for_tests(repository),
|
|
)
|
|
}
|
|
|
|
fn admin_headers() -> HeaderMap {
|
|
let mut headers = HeaderMap::new();
|
|
for (name, value) in [
|
|
(GATEWAY_HEADER, "rust-phase3b"),
|
|
(TRUSTED_ADMIN_USER_ID_HEADER, "admin-user"),
|
|
(TRUSTED_ADMIN_USER_ROLE_HEADER, "admin"),
|
|
(TRUSTED_ADMIN_SESSION_ID_HEADER, "admin-session"),
|
|
] {
|
|
headers.insert(name, HeaderValue::from_static(value));
|
|
}
|
|
headers
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn endpoint_rules_reveal_is_scoped_audited_and_not_cached() {
|
|
let state = seeded_state();
|
|
let context = resolve_public_request_context(
|
|
&state,
|
|
&Method::GET,
|
|
&"/api/admin/endpoints/endpoint-rules/rules/reveal"
|
|
.parse()
|
|
.unwrap(),
|
|
&admin_headers(),
|
|
"reveal-test",
|
|
)
|
|
.await
|
|
.unwrap();
|
|
let response = maybe_build_local_admin_response(AdminRouteRequest::new(
|
|
&state,
|
|
&context,
|
|
&"127.0.0.1:12345".parse().unwrap(),
|
|
&admin_headers(),
|
|
None,
|
|
))
|
|
.await
|
|
.unwrap()
|
|
.unwrap();
|
|
assert_eq!(response.status(), StatusCode::OK);
|
|
assert_eq!(response.headers()[http::header::CACHE_CONTROL], "no-store");
|
|
assert_eq!(response.headers()[http::header::PRAGMA], "no-cache");
|
|
let audit = response.extensions().get::<AdminAuditEvent>().unwrap();
|
|
assert_eq!(audit.event_name, "admin_endpoint_rules_revealed");
|
|
assert_eq!(audit.action, "reveal_endpoint_rules");
|
|
assert_eq!(audit.target_id, "endpoint-rules");
|
|
let body = response.into_body().collect().await.unwrap().to_bytes();
|
|
let payload: Value = serde_json::from_slice(&body).unwrap();
|
|
assert_eq!(payload["header_rules"][0]["value"], "request-secret");
|
|
assert_eq!(payload["body_rules"][0]["value"], "body-secret");
|
|
assert_eq!(
|
|
payload["response_header_rules"][0]["value"],
|
|
"response-secret"
|
|
);
|
|
assert_eq!(payload.as_object().unwrap().len(), 3);
|
|
assert!(!payload.to_string().contains("unrelated-secret"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn endpoint_rules_reveal_denies_anonymous_and_non_admin_requests() {
|
|
let router = build_router_with_state(seeded_state());
|
|
for role in [None, Some("user")] {
|
|
let mut request =
|
|
Request::builder().uri("/api/admin/endpoints/endpoint-rules/rules/reveal");
|
|
if let Some(role) = role {
|
|
request = request
|
|
.header(GATEWAY_HEADER, "rust-phase3b")
|
|
.header(TRUSTED_ADMIN_USER_ID_HEADER, "normal-user")
|
|
.header(TRUSTED_ADMIN_USER_ROLE_HEADER, role)
|
|
.header(TRUSTED_ADMIN_SESSION_ID_HEADER, "user-session");
|
|
}
|
|
let response = send_request(router.clone(), request.body(Body::empty()).unwrap()).await;
|
|
assert!(matches!(
|
|
response.status(),
|
|
StatusCode::UNAUTHORIZED | StatusCode::FORBIDDEN
|
|
));
|
|
let body = response.into_body().collect().await.unwrap().to_bytes();
|
|
assert!(!String::from_utf8_lossy(&body).contains("request-secret"));
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn endpoint_rules_reveal_returns_not_found_and_data_unavailable_without_fallback() {
|
|
for (state, expected) in [
|
|
(seeded_state(), StatusCode::NOT_FOUND),
|
|
(AppState::new().unwrap(), StatusCode::SERVICE_UNAVAILABLE),
|
|
] {
|
|
let context = resolve_public_request_context(
|
|
&state,
|
|
&Method::GET,
|
|
&"/api/admin/endpoints/missing/rules/reveal".parse().unwrap(),
|
|
&admin_headers(),
|
|
"reveal-missing-test",
|
|
)
|
|
.await
|
|
.unwrap();
|
|
let response = maybe_build_local_admin_response(AdminRouteRequest::new(
|
|
&state,
|
|
&context,
|
|
&"127.0.0.1:12345".parse().unwrap(),
|
|
&admin_headers(),
|
|
None,
|
|
))
|
|
.await
|
|
.unwrap()
|
|
.unwrap();
|
|
assert_eq!(response.status(), expected);
|
|
}
|
|
}
|