Files
Aether/crates/aether-data/adapters/postgres/src/candidates.rs
T

1703 lines
65 KiB
Rust

use std::sync::LazyLock;
use async_trait::async_trait;
use futures_util::{future::BoxFuture, stream::TryStream, TryStreamExt};
use sqlx::{postgres::PgRow, PgPool, Postgres, QueryBuilder, Row};
use uuid::Uuid;
use aether_data_contracts::repository::candidates::{
PublicHealthStatusCount, PublicHealthTimelineBucket, RequestCandidateReadRepository,
RequestCandidateStatus, RequestCandidateWriteRepository, StoredRequestCandidate,
UpsertRequestCandidateRecord, REQUEST_CANDIDATE_ERROR_TYPES,
REQUEST_CANDIDATE_ERROR_TYPE_ALIASES, REQUEST_CANDIDATE_SKIP_REASONS,
};
use aether_data_contracts::DataLayerError;
use aether_data_query::{push_eq, push_in, push_limit, WhereClause};
use crate::error::SqlxResultExt;
use crate::{PostgresTransaction, PostgresTransactionRunner};
const LIST_BY_REQUEST_ID_SQL: &str = r#"
SELECT
id,
request_id,
user_id,
api_key_id,
username,
api_key_name,
candidate_index,
retry_index,
provider_id,
endpoint_id,
key_id,
status,
skip_reason,
is_cached,
status_code,
error_type,
error_message,
latency_ms,
concurrent_requests,
extra_data,
required_capabilities,
CAST(EXTRACT(EPOCH FROM created_at) * 1000 AS BIGINT) AS created_at_unix_ms,
CAST(EXTRACT(EPOCH FROM started_at) * 1000 AS BIGINT) AS started_at_unix_ms,
CAST(EXTRACT(EPOCH FROM finished_at) * 1000 AS BIGINT) AS finished_at_unix_ms
FROM request_candidates
WHERE request_id = $1
ORDER BY candidate_index ASC, retry_index ASC, created_at ASC
"#;
const AGGREGATE_FINALIZED_TIMELINE_BY_ENDPOINT_IDS_SINCE_SQL: &str = r#"
SELECT
endpoint_id,
FLOOR(EXTRACT(EPOCH FROM (created_at - TO_TIMESTAMP($2))) / $4)::BIGINT AS segment_idx,
COUNT(id) AS total_count,
SUM(CASE WHEN status = 'success' THEN 1 ELSE 0 END) AS success_count,
SUM(CASE WHEN status = 'failed' THEN 1 ELSE 0 END) AS failed_count,
CAST(EXTRACT(EPOCH FROM MIN(created_at)) * 1000 AS BIGINT) AS min_created_at_unix_ms,
CAST(EXTRACT(EPOCH FROM MAX(created_at)) * 1000 AS BIGINT) AS max_created_at_unix_ms
FROM request_candidates
WHERE endpoint_id = ANY($1)
AND created_at >= TO_TIMESTAMP($2)
AND created_at <= TO_TIMESTAMP($3)
AND status IN ('success', 'failed', 'skipped')
GROUP BY
endpoint_id,
FLOOR(EXTRACT(EPOCH FROM (created_at - TO_TIMESTAMP($2))) / $4)::BIGINT
"#;
const UPSERT_SQL_TEMPLATE: &str = r#"
INSERT INTO request_candidates (
id,
request_id,
user_id,
api_key_id,
username,
api_key_name,
candidate_index,
retry_index,
provider_id,
endpoint_id,
key_id,
status,
skip_reason,
is_cached,
status_code,
error_type,
error_message,
latency_ms,
concurrent_requests,
extra_data,
required_capabilities,
created_at,
started_at,
finished_at
)
VALUES (
$1,
$2,
$3,
$4,
$5,
$6,
$7,
$8,
$9,
$10,
$11,
$12,
$13,
COALESCE($14, false),
$15,
$16,
$17,
$18,
$19,
$20,
$21,
COALESCE(
CASE
WHEN $22 IS NOT NULL AND $22 > 1000.0 THEN TO_TIMESTAMP($22 / 1000.0)
END,
TO_TIMESTAMP($23 / 1000.0),
TO_TIMESTAMP($24 / 1000.0),
NOW()
),
TO_TIMESTAMP($23 / 1000.0),
TO_TIMESTAMP($24 / 1000.0)
)
ON CONFLICT (request_id, candidate_index, retry_index)
DO UPDATE SET
user_id = COALESCE(request_candidates.user_id, EXCLUDED.user_id),
api_key_id = COALESCE(request_candidates.api_key_id, EXCLUDED.api_key_id),
username = COALESCE(request_candidates.username, EXCLUDED.username),
api_key_name = COALESCE(request_candidates.api_key_name, EXCLUDED.api_key_name),
provider_id = COALESCE(request_candidates.provider_id, EXCLUDED.provider_id),
endpoint_id = COALESCE(request_candidates.endpoint_id, EXCLUDED.endpoint_id),
key_id = COALESCE(request_candidates.key_id, EXCLUDED.key_id),
status = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.status
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.status
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.status
ELSE EXCLUDED.status
END,
skip_reason = COALESCE(EXCLUDED.skip_reason, __AETHER_SANITIZED_LEGACY_SKIP_REASON__),
is_cached = COALESCE($14, request_candidates.is_cached),
status_code = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.status_code
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.status_code
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.status_code
ELSE COALESCE(EXCLUDED.status_code, request_candidates.status_code)
END,
error_type = CASE
WHEN (
request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
) OR (
request_candidates.status = 'pending'
AND EXCLUDED.status IN ('available', 'unused')
) OR (
request_candidates.status = 'streaming'
AND EXCLUDED.status IN ('available', 'unused', 'pending')
) OR EXCLUDED.error_type IS NULL
THEN __AETHER_SANITIZED_LEGACY_ERROR_TYPE__
ELSE EXCLUDED.error_type
END,
error_message = __AETHER_CANDIDATE_ERROR_MESSAGE__,
latency_ms = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.latency_ms
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.latency_ms
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.latency_ms
ELSE COALESCE(EXCLUDED.latency_ms, request_candidates.latency_ms)
END,
concurrent_requests = COALESCE(EXCLUDED.concurrent_requests, request_candidates.concurrent_requests),
extra_data = __AETHER_CANDIDATE_EXTRA_DATA__,
required_capabilities = EXCLUDED.required_capabilities,
created_at = CASE
WHEN request_candidates.created_at <= TO_TIMESTAMP(1)
THEN EXCLUDED.created_at
ELSE request_candidates.created_at
END,
started_at = COALESCE(request_candidates.started_at, EXCLUDED.started_at),
finished_at = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.finished_at
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.finished_at
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.finished_at
ELSE COALESCE(EXCLUDED.finished_at, request_candidates.finished_at)
END
RETURNING
id,
request_id,
user_id,
api_key_id,
username,
api_key_name,
candidate_index,
retry_index,
provider_id,
endpoint_id,
key_id,
status,
skip_reason,
is_cached,
status_code,
error_type,
error_message,
latency_ms,
concurrent_requests,
extra_data,
required_capabilities,
CAST(EXTRACT(EPOCH FROM created_at) * 1000 AS BIGINT) AS created_at_unix_ms,
CAST(EXTRACT(EPOCH FROM started_at) * 1000 AS BIGINT) AS started_at_unix_ms,
CAST(EXTRACT(EPOCH FROM finished_at) * 1000 AS BIGINT) AS finished_at_unix_ms
"#;
const UPSERT_CONFLICT_SQL_TEMPLATE: &str = r#"
ON CONFLICT (request_id, candidate_index, retry_index)
DO UPDATE SET
user_id = COALESCE(request_candidates.user_id, EXCLUDED.user_id),
api_key_id = COALESCE(request_candidates.api_key_id, EXCLUDED.api_key_id),
username = COALESCE(request_candidates.username, EXCLUDED.username),
api_key_name = COALESCE(request_candidates.api_key_name, EXCLUDED.api_key_name),
provider_id = COALESCE(request_candidates.provider_id, EXCLUDED.provider_id),
endpoint_id = COALESCE(request_candidates.endpoint_id, EXCLUDED.endpoint_id),
key_id = COALESCE(request_candidates.key_id, EXCLUDED.key_id),
status = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.status
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.status
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.status
ELSE EXCLUDED.status
END,
skip_reason = COALESCE(EXCLUDED.skip_reason, __AETHER_SANITIZED_LEGACY_SKIP_REASON__),
is_cached = COALESCE(EXCLUDED.is_cached, request_candidates.is_cached),
status_code = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.status_code
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.status_code
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.status_code
ELSE COALESCE(EXCLUDED.status_code, request_candidates.status_code)
END,
error_type = CASE
WHEN (
request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
) OR (
request_candidates.status = 'pending'
AND EXCLUDED.status IN ('available', 'unused')
) OR (
request_candidates.status = 'streaming'
AND EXCLUDED.status IN ('available', 'unused', 'pending')
) OR EXCLUDED.error_type IS NULL
THEN __AETHER_SANITIZED_LEGACY_ERROR_TYPE__
ELSE EXCLUDED.error_type
END,
error_message = __AETHER_CANDIDATE_ERROR_MESSAGE__,
latency_ms = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.latency_ms
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.latency_ms
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.latency_ms
ELSE COALESCE(EXCLUDED.latency_ms, request_candidates.latency_ms)
END,
concurrent_requests = COALESCE(EXCLUDED.concurrent_requests, request_candidates.concurrent_requests),
extra_data = __AETHER_CANDIDATE_EXTRA_DATA__,
required_capabilities = EXCLUDED.required_capabilities,
created_at = CASE
WHEN request_candidates.created_at <= TO_TIMESTAMP(1)
THEN EXCLUDED.created_at
ELSE request_candidates.created_at
END,
started_at = COALESCE(request_candidates.started_at, EXCLUDED.started_at),
finished_at = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.finished_at
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.finished_at
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.finished_at
ELSE COALESCE(EXCLUDED.finished_at, request_candidates.finished_at)
END
"#;
const UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL_TEMPLATE: &str = r#"
ON CONFLICT (request_id, candidate_index, retry_index)
DO UPDATE SET
user_id = COALESCE(request_candidates.user_id, EXCLUDED.user_id),
api_key_id = COALESCE(request_candidates.api_key_id, EXCLUDED.api_key_id),
username = COALESCE(request_candidates.username, EXCLUDED.username),
api_key_name = COALESCE(request_candidates.api_key_name, EXCLUDED.api_key_name),
provider_id = COALESCE(request_candidates.provider_id, EXCLUDED.provider_id),
endpoint_id = COALESCE(request_candidates.endpoint_id, EXCLUDED.endpoint_id),
key_id = COALESCE(request_candidates.key_id, EXCLUDED.key_id),
status = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.status
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.status
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.status
ELSE EXCLUDED.status
END,
skip_reason = COALESCE(EXCLUDED.skip_reason, __AETHER_SANITIZED_LEGACY_SKIP_REASON__),
is_cached = request_candidates.is_cached,
status_code = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.status_code
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.status_code
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.status_code
ELSE COALESCE(EXCLUDED.status_code, request_candidates.status_code)
END,
error_type = CASE
WHEN (
request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
) OR (
request_candidates.status = 'pending'
AND EXCLUDED.status IN ('available', 'unused')
) OR (
request_candidates.status = 'streaming'
AND EXCLUDED.status IN ('available', 'unused', 'pending')
) OR EXCLUDED.error_type IS NULL
THEN __AETHER_SANITIZED_LEGACY_ERROR_TYPE__
ELSE EXCLUDED.error_type
END,
error_message = __AETHER_CANDIDATE_ERROR_MESSAGE__,
latency_ms = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.latency_ms
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.latency_ms
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.latency_ms
ELSE COALESCE(EXCLUDED.latency_ms, request_candidates.latency_ms)
END,
concurrent_requests = COALESCE(EXCLUDED.concurrent_requests, request_candidates.concurrent_requests),
extra_data = __AETHER_CANDIDATE_EXTRA_DATA__,
required_capabilities = EXCLUDED.required_capabilities,
created_at = CASE
WHEN request_candidates.created_at <= TO_TIMESTAMP(1)
THEN EXCLUDED.created_at
ELSE request_candidates.created_at
END,
started_at = COALESCE(request_candidates.started_at, EXCLUDED.started_at),
finished_at = CASE
WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')
AND EXCLUDED.status <> request_candidates.status
THEN request_candidates.finished_at
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')
THEN request_candidates.finished_at
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')
THEN request_candidates.finished_at
ELSE COALESCE(EXCLUDED.finished_at, request_candidates.finished_at)
END
"#;
const UPSERT_MANY_PREFIX_SQL: &str = r#"
INSERT INTO request_candidates (
id,
request_id,
user_id,
api_key_id,
username,
api_key_name,
candidate_index,
retry_index,
provider_id,
endpoint_id,
key_id,
status,
skip_reason,
is_cached,
status_code,
error_type,
error_message,
latency_ms,
concurrent_requests,
extra_data,
required_capabilities,
created_at,
started_at,
finished_at
)
"#;
const LEGACY_SKIP_REASON_PLACEHOLDER: &str = "__AETHER_SANITIZED_LEGACY_SKIP_REASON__";
const LEGACY_ERROR_TYPE_PLACEHOLDER: &str = "__AETHER_SANITIZED_LEGACY_ERROR_TYPE__";
static UPSERT_SQL: LazyLock<String> =
LazyLock::new(|| postgres_candidate_upsert_sql(UPSERT_SQL_TEMPLATE));
static UPSERT_CONFLICT_SQL: LazyLock<String> =
LazyLock::new(|| postgres_candidate_upsert_sql(UPSERT_CONFLICT_SQL_TEMPLATE));
static UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL: LazyLock<String> =
LazyLock::new(|| postgres_candidate_upsert_sql(UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL_TEMPLATE));
fn postgres_candidate_upsert_sql(template: &str) -> String {
template
.replace(
LEGACY_SKIP_REASON_PLACEHOLDER,
postgres_sanitized_legacy_diagnostic_sql(
"request_candidates.skip_reason",
REQUEST_CANDIDATE_SKIP_REASONS,
&[],
"unclassified_skip",
)
.as_str(),
)
.replace(
LEGACY_ERROR_TYPE_PLACEHOLDER,
postgres_sanitized_legacy_diagnostic_sql(
"request_candidates.error_type",
REQUEST_CANDIDATE_ERROR_TYPES,
REQUEST_CANDIDATE_ERROR_TYPE_ALIASES,
"unclassified_error",
)
.as_str(),
)
.replace(
"__AETHER_CANDIDATE_ERROR_MESSAGE__",
"CASE WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped') \
AND EXCLUDED.status <> request_candidates.status \
THEN request_candidates.error_message \
WHEN request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused') \
THEN request_candidates.error_message \
WHEN request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending') \
THEN request_candidates.error_message \
ELSE COALESCE(EXCLUDED.error_message, request_candidates.error_message) END",
)
.replace(
"__AETHER_CANDIDATE_EXTRA_DATA__",
"CASE WHEN request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped') \
AND (EXCLUDED.status <> request_candidates.status OR EXCLUDED.extra_data IS NULL) \
THEN request_candidates.extra_data ELSE EXCLUDED.extra_data END",
)
}
fn postgres_sanitized_legacy_diagnostic_sql(
column: &str,
allowed: &[&str],
aliases: &[(&str, &str)],
fallback: &str,
) -> String {
let normalized = format!("LOWER(BTRIM({column}))");
let mut sql = format!("(CASE WHEN {column} IS NULL THEN NULL");
for (alias, canonical) in aliases {
sql.push_str(format!(" WHEN {normalized} = '{alias}' THEN '{canonical}'").as_str());
}
sql.push_str(format!(" WHEN {normalized} IN (").as_str());
for (index, value) in allowed.iter().enumerate() {
if index > 0 {
sql.push_str(", ");
}
sql.push('\'');
sql.push_str(value);
sql.push('\'');
}
sql.push_str(format!(") THEN {normalized} ELSE '{fallback}' END)").as_str());
sql
}
const MAX_POSTGRES_REQUEST_CANDIDATE_UPSERT_ROWS: usize = 1_000;
const DELETE_CREATED_BEFORE_SQL: &str = r#"
DELETE FROM request_candidates
WHERE id IN (
SELECT id
FROM request_candidates
WHERE created_at < TO_TIMESTAMP($1)
ORDER BY created_at ASC, id ASC
LIMIT $2
)
"#;
#[derive(Debug, Clone)]
pub struct SqlxRequestCandidateReadRepository {
pool: PgPool,
tx_runner: PostgresTransactionRunner,
}
impl SqlxRequestCandidateReadRepository {
pub fn new(pool: PgPool) -> Self {
let tx_runner = PostgresTransactionRunner::new(pool.clone());
Self { pool, tx_runner }
}
pub fn pool(&self) -> &PgPool {
&self.pool
}
pub fn transaction_runner(&self) -> &PostgresTransactionRunner {
&self.tx_runner
}
pub async fn list_by_request_id(
&self,
request_id: &str,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
let mut builder = QueryBuilder::<Postgres>::new(candidate_columns());
let mut where_clause = WhereClause::new();
push_eq(
&mut builder,
&mut where_clause,
"request_id",
request_id.to_string(),
);
builder.push(" ORDER BY candidate_index ASC, retry_index ASC, created_at ASC");
collect_query_rows(builder.build().fetch(&self.pool), map_request_candidate_row).await
}
pub async fn list_attempted_by_request_id(
&self,
request_id: &str,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
let mut builder = QueryBuilder::<Postgres>::new(candidate_columns());
let mut where_clause = WhereClause::new();
push_eq(
&mut builder,
&mut where_clause,
"request_id",
request_id.to_string(),
);
builder.push(
" AND (status IN ('streaming', 'success', 'failed', 'cancelled') \
OR (status = 'pending' AND started_at IS NOT NULL)) \
ORDER BY candidate_index ASC, retry_index ASC, created_at ASC",
);
collect_query_rows(builder.build().fetch(&self.pool), map_request_candidate_row).await
}
pub async fn list_recent(
&self,
limit: usize,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
if limit == 0 {
return Ok(Vec::new());
}
let mut builder = QueryBuilder::<Postgres>::new(candidate_columns());
builder.push(" ORDER BY created_at DESC");
push_limit(
&mut builder,
i64::try_from(limit).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"invalid recent request candidate limit: {limit}"
))
})?,
);
collect_query_rows(builder.build().fetch(&self.pool), map_request_candidate_row).await
}
pub async fn list_by_provider_id(
&self,
provider_id: &str,
limit: usize,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
if limit == 0 {
return Ok(Vec::new());
}
let mut builder = QueryBuilder::<Postgres>::new(candidate_columns());
let mut where_clause = WhereClause::new();
push_eq(
&mut builder,
&mut where_clause,
"provider_id",
provider_id.to_string(),
);
builder.push(" ORDER BY created_at DESC");
push_limit(
&mut builder,
i64::try_from(limit).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"invalid provider request candidate limit: {limit}"
))
})?,
);
collect_query_rows(builder.build().fetch(&self.pool), map_request_candidate_row).await
}
pub async fn list_finalized_by_endpoint_ids_since(
&self,
endpoint_ids: &[String],
since_unix_secs: u64,
limit: usize,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
if endpoint_ids.is_empty() || limit == 0 {
return Ok(Vec::new());
}
let mut builder = QueryBuilder::<Postgres>::new(candidate_columns());
let mut where_clause = WhereClause::new();
push_in(&mut builder, &mut where_clause, "endpoint_id", endpoint_ids);
builder
.push(" AND created_at >= TO_TIMESTAMP(")
.push_bind(since_unix_secs as f64)
.push(") AND status IN ('success', 'failed', 'skipped') ORDER BY created_at DESC");
push_limit(
&mut builder,
i64::try_from(limit).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"invalid finalized request candidate limit: {limit}"
))
})?,
);
collect_query_rows(builder.build().fetch(&self.pool), map_request_candidate_row).await
}
pub async fn count_finalized_statuses_by_endpoint_ids_since(
&self,
endpoint_ids: &[String],
since_unix_secs: u64,
) -> Result<Vec<PublicHealthStatusCount>, DataLayerError> {
if endpoint_ids.is_empty() {
return Ok(Vec::new());
}
let mut builder = QueryBuilder::<Postgres>::new(
"SELECT endpoint_id, status, COUNT(id) AS count FROM request_candidates",
);
let mut where_clause = WhereClause::new();
push_in(&mut builder, &mut where_clause, "endpoint_id", endpoint_ids);
builder
.push(" AND created_at >= TO_TIMESTAMP(")
.push_bind(since_unix_secs as f64)
.push(") AND status IN ('success', 'failed', 'skipped') GROUP BY endpoint_id, status");
let rows = builder
.build()
.fetch_all(&self.pool)
.await
.map_postgres_err()?;
rows.iter()
.map(|row| {
Ok(PublicHealthStatusCount {
endpoint_id: row_get(row, "endpoint_id")?,
status: RequestCandidateStatus::from_database(
row_get::<String>(row, "status")?.as_str(),
)?,
count: u64::try_from(row_get::<i64>(row, "count")?).map_err(|_| {
DataLayerError::UnexpectedValue(
"public health status count out of range".to_string(),
)
})?,
})
})
.collect()
}
pub async fn aggregate_finalized_timeline_by_endpoint_ids_since(
&self,
endpoint_ids: &[String],
since_unix_secs: u64,
until_unix_secs: u64,
segments: u32,
) -> Result<Vec<PublicHealthTimelineBucket>, DataLayerError> {
if endpoint_ids.is_empty() || segments == 0 || until_unix_secs < since_unix_secs {
return Ok(Vec::new());
}
let span_seconds = until_unix_secs.saturating_sub(since_unix_secs);
let segment_seconds = if span_seconds == 0 {
1.0
} else {
(span_seconds as f64) / (segments as f64)
};
let mut rows = sqlx::query(AGGREGATE_FINALIZED_TIMELINE_BY_ENDPOINT_IDS_SINCE_SQL)
.bind(endpoint_ids)
.bind(since_unix_secs as f64)
.bind(until_unix_secs as f64)
.bind(segment_seconds)
.fetch(&self.pool);
let mut buckets = Vec::new();
while let Some(row) = rows.try_next().await.map_postgres_err()? {
let bucket = {
let raw_segment_idx = row_get::<i64>(&row, "segment_idx")?;
let segment_idx = if raw_segment_idx < 0 {
0
} else {
u32::try_from(raw_segment_idx).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"public health segment idx out of range: {raw_segment_idx}"
))
})?
}
.min(segments.saturating_sub(1));
PublicHealthTimelineBucket {
endpoint_id: row_get(&row, "endpoint_id")?,
segment_idx,
total_count: u64::try_from(row_get::<i64>(&row, "total_count")?).map_err(
|_| {
DataLayerError::UnexpectedValue(
"public health total_count out of range".to_string(),
)
},
)?,
success_count: u64::try_from(row_get::<i64>(&row, "success_count")?).map_err(
|_| {
DataLayerError::UnexpectedValue(
"public health success_count out of range".to_string(),
)
},
)?,
failed_count: u64::try_from(row_get::<i64>(&row, "failed_count")?).map_err(
|_| {
DataLayerError::UnexpectedValue(
"public health failed_count out of range".to_string(),
)
},
)?,
min_created_at_unix_ms: row_get::<Option<i64>>(&row, "min_created_at_unix_ms")?
.map(|value| {
u64::try_from(value).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"public health min_created_at_unix_ms out of range: {value}"
))
})
})
.transpose()?,
max_created_at_unix_ms: row_get::<Option<i64>>(&row, "max_created_at_unix_ms")?
.map(|value| {
u64::try_from(value).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"public health max_created_at_unix_ms out of range: {value}"
))
})
})
.transpose()?,
}
};
buckets.push(bucket);
}
Ok(buckets)
}
pub async fn upsert(
&self,
mut candidate: UpsertRequestCandidateRecord,
) -> Result<StoredRequestCandidate, DataLayerError> {
sanitize_request_candidate_for_postgres(&mut candidate);
candidate.validate()?;
self.tx_runner
.run_read_write(|tx| {
Box::pin(async move {
let row = sqlx::query(UPSERT_SQL.as_str())
.bind(if candidate.id.trim().is_empty() {
Uuid::new_v4().to_string()
} else {
candidate.id.clone()
})
.bind(&candidate.request_id)
.bind(&candidate.user_id)
.bind(&candidate.api_key_id)
.bind(&candidate.username)
.bind(&candidate.api_key_name)
.bind(to_i32(candidate.candidate_index)?)
.bind(to_i32(candidate.retry_index)?)
.bind(&candidate.provider_id)
.bind(&candidate.endpoint_id)
.bind(&candidate.key_id)
.bind(status_to_database(candidate.status))
.bind(&candidate.skip_reason)
.bind(candidate.is_cached)
.bind(candidate.status_code.map(i32::from))
.bind(&candidate.error_type)
.bind(&candidate.error_message)
.bind(candidate.latency_ms.map(to_i32_u64).transpose()?)
.bind(candidate.concurrent_requests.map(to_i32).transpose()?)
.bind(&candidate.extra_data)
.bind(&candidate.required_capabilities)
.bind(candidate.created_at_unix_ms.map(|value| value as f64))
.bind(candidate.started_at_unix_ms.map(|value| value as f64))
.bind(candidate.finished_at_unix_ms.map(|value| value as f64))
.fetch_one(&mut **tx)
.await
.map_postgres_err()?;
map_request_candidate_row(&row)
}) as BoxFuture<'_, Result<StoredRequestCandidate, DataLayerError>>
})
.await
}
pub async fn upsert_many(
&self,
candidates: Vec<UpsertRequestCandidateRecord>,
) -> Result<usize, DataLayerError> {
if candidates.is_empty() {
return Ok(0);
}
let rows = candidates
.into_iter()
.map(BatchUpsertRequestCandidateRow::try_from)
.collect::<Result<Vec<_>, _>>()?;
self.tx_runner
.run_read_write(|tx| {
Box::pin(async move {
let mut persisted = 0usize;
for ordered_batch in split_request_candidate_upsert_batches(rows) {
let (explicit_is_cached, inherited_is_cached): (Vec<_>, Vec<_>) =
ordered_batch
.into_iter()
.partition(|row| row.is_cached.is_some());
persisted = persisted.saturating_add(
execute_partitioned_upsert_many_batch(tx, &explicit_is_cached, true)
.await?,
);
persisted = persisted.saturating_add(
execute_partitioned_upsert_many_batch(tx, &inherited_is_cached, false)
.await?,
);
}
Ok(persisted)
}) as BoxFuture<'_, Result<usize, DataLayerError>>
})
.await
}
pub async fn delete_created_before(
&self,
created_before_unix_secs: u64,
limit: usize,
) -> Result<usize, DataLayerError> {
if limit == 0 {
return Ok(0);
}
let result = sqlx::query(DELETE_CREATED_BEFORE_SQL)
.bind(created_before_unix_secs as f64)
.bind(i64::try_from(limit).map_err(|_| {
DataLayerError::UnexpectedValue(format!(
"invalid request candidate delete limit: {limit}"
))
})?)
.execute(&self.pool)
.await
.map_postgres_err()?;
Ok(result.rows_affected() as usize)
}
}
async fn execute_partitioned_upsert_many_batch(
tx: &mut PostgresTransaction,
rows: &[BatchUpsertRequestCandidateRow],
overwrite_is_cached: bool,
) -> Result<usize, DataLayerError> {
let mut persisted = 0usize;
for chunk in rows.chunks(MAX_POSTGRES_REQUEST_CANDIDATE_UPSERT_ROWS) {
persisted = persisted
.saturating_add(execute_upsert_many_batch(tx, chunk, overwrite_is_cached).await?);
}
Ok(persisted)
}
#[derive(Debug)]
struct BatchUpsertRequestCandidateRow {
id: String,
request_id: String,
user_id: Option<String>,
api_key_id: Option<String>,
username: Option<String>,
api_key_name: Option<String>,
candidate_index: i32,
retry_index: i32,
provider_id: Option<String>,
endpoint_id: Option<String>,
key_id: Option<String>,
status: &'static str,
skip_reason: Option<String>,
is_cached: Option<bool>,
status_code: Option<i32>,
error_type: Option<String>,
error_message: Option<String>,
latency_ms: Option<i32>,
concurrent_requests: Option<i32>,
extra_data: Option<serde_json::Value>,
required_capabilities: Option<serde_json::Value>,
created_at_unix_ms: Option<f64>,
started_at_unix_ms: Option<f64>,
finished_at_unix_ms: Option<f64>,
}
impl TryFrom<UpsertRequestCandidateRecord> for BatchUpsertRequestCandidateRow {
type Error = DataLayerError;
fn try_from(mut candidate: UpsertRequestCandidateRecord) -> Result<Self, Self::Error> {
sanitize_request_candidate_for_postgres(&mut candidate);
candidate.validate()?;
Ok(Self {
id: if candidate.id.trim().is_empty() {
Uuid::new_v4().to_string()
} else {
candidate.id
},
request_id: candidate.request_id,
user_id: candidate.user_id,
api_key_id: candidate.api_key_id,
username: candidate.username,
api_key_name: candidate.api_key_name,
candidate_index: to_i32(candidate.candidate_index)?,
retry_index: to_i32(candidate.retry_index)?,
provider_id: candidate.provider_id,
endpoint_id: candidate.endpoint_id,
key_id: candidate.key_id,
status: status_to_database(candidate.status),
skip_reason: candidate.skip_reason,
is_cached: candidate.is_cached,
status_code: candidate.status_code.map(i32::from),
error_type: candidate.error_type,
error_message: candidate.error_message,
latency_ms: candidate.latency_ms.map(to_i32_u64).transpose()?,
concurrent_requests: candidate.concurrent_requests.map(to_i32).transpose()?,
extra_data: candidate.extra_data,
required_capabilities: candidate.required_capabilities,
created_at_unix_ms: candidate.created_at_unix_ms.map(|value| value as f64),
started_at_unix_ms: candidate.started_at_unix_ms.map(|value| value as f64),
finished_at_unix_ms: candidate.finished_at_unix_ms.map(|value| value as f64),
})
}
}
async fn execute_upsert_many_batch(
tx: &mut PostgresTransaction,
rows: &[BatchUpsertRequestCandidateRow],
overwrite_is_cached: bool,
) -> Result<usize, DataLayerError> {
if rows.is_empty() {
return Ok(0);
}
let mut builder = QueryBuilder::<Postgres>::new(UPSERT_MANY_PREFIX_SQL);
builder.push_values(rows, |mut values, row| {
values
.push_bind(row.id.as_str())
.push_bind(row.request_id.as_str())
.push_bind(row.user_id.as_deref())
.push_bind(row.api_key_id.as_deref())
.push_bind(row.username.as_deref())
.push_bind(row.api_key_name.as_deref())
.push_bind(row.candidate_index)
.push_bind(row.retry_index)
.push_bind(row.provider_id.as_deref())
.push_bind(row.endpoint_id.as_deref())
.push_bind(row.key_id.as_deref())
.push_bind(row.status)
.push_bind(row.skip_reason.as_deref())
.push_bind(row.is_cached.unwrap_or(false))
.push_bind(row.status_code)
.push_bind(row.error_type.as_deref())
.push_bind(row.error_message.as_deref())
.push_bind(row.latency_ms)
.push_bind(row.concurrent_requests)
.push_bind(row.extra_data.as_ref())
.push_bind(row.required_capabilities.as_ref())
.push("COALESCE(CASE WHEN ")
.push_bind_unseparated(row.created_at_unix_ms)
.push_unseparated(" IS NOT NULL AND ")
.push_bind_unseparated(row.created_at_unix_ms)
.push_unseparated(" > 1000.0 THEN TO_TIMESTAMP(")
.push_bind_unseparated(row.created_at_unix_ms)
.push_unseparated(" / 1000.0) END, TO_TIMESTAMP(")
.push_bind_unseparated(row.started_at_unix_ms)
.push_unseparated(" / 1000.0), TO_TIMESTAMP(")
.push_bind_unseparated(row.finished_at_unix_ms)
.push_unseparated(" / 1000.0), NOW())")
.push("TO_TIMESTAMP(")
.push_bind_unseparated(row.started_at_unix_ms)
.push_unseparated(" / 1000.0)")
.push("TO_TIMESTAMP(")
.push_bind_unseparated(row.finished_at_unix_ms)
.push_unseparated(" / 1000.0)");
});
builder.push(upsert_many_conflict_sql(overwrite_is_cached));
let result = builder
.build()
.execute(&mut **tx)
.await
.map_postgres_err()?;
Ok(usize::try_from(result.rows_affected()).unwrap_or(rows.len()))
}
fn split_request_candidate_upsert_batches(
rows: Vec<BatchUpsertRequestCandidateRow>,
) -> Vec<Vec<BatchUpsertRequestCandidateRow>> {
let mut batches = Vec::new();
let mut current = Vec::new();
let mut seen = std::collections::HashSet::<(String, i32, i32)>::new();
for row in rows {
let key = (row.request_id.clone(), row.candidate_index, row.retry_index);
if seen.contains(&key) && !current.is_empty() {
batches.push(current);
current = Vec::new();
seen.clear();
}
seen.insert(key);
current.push(row);
}
if !current.is_empty() {
batches.push(current);
}
batches
}
fn upsert_many_conflict_sql(overwrite_is_cached: bool) -> &'static str {
if overwrite_is_cached {
UPSERT_CONFLICT_SQL.as_str()
} else {
UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL.as_str()
}
}
#[async_trait]
impl RequestCandidateReadRepository for SqlxRequestCandidateReadRepository {
async fn list_by_request_id(
&self,
request_id: &str,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
Self::list_by_request_id(self, request_id).await
}
async fn list_attempted_by_request_id(
&self,
request_id: &str,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
Self::list_attempted_by_request_id(self, request_id).await
}
async fn list_recent(
&self,
limit: usize,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
Self::list_recent(self, limit).await
}
async fn list_finalized_by_endpoint_ids_since(
&self,
endpoint_ids: &[String],
since_unix_secs: u64,
limit: usize,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
Self::list_finalized_by_endpoint_ids_since(self, endpoint_ids, since_unix_secs, limit).await
}
async fn list_by_provider_id(
&self,
provider_id: &str,
limit: usize,
) -> Result<Vec<StoredRequestCandidate>, DataLayerError> {
Self::list_by_provider_id(self, provider_id, limit).await
}
async fn count_finalized_statuses_by_endpoint_ids_since(
&self,
endpoint_ids: &[String],
since_unix_secs: u64,
) -> Result<Vec<PublicHealthStatusCount>, DataLayerError> {
Self::count_finalized_statuses_by_endpoint_ids_since(self, endpoint_ids, since_unix_secs)
.await
}
async fn aggregate_finalized_timeline_by_endpoint_ids_since(
&self,
endpoint_ids: &[String],
since_unix_secs: u64,
until_unix_secs: u64,
segments: u32,
) -> Result<Vec<PublicHealthTimelineBucket>, DataLayerError> {
Self::aggregate_finalized_timeline_by_endpoint_ids_since(
self,
endpoint_ids,
since_unix_secs,
until_unix_secs,
segments,
)
.await
}
}
#[async_trait]
impl RequestCandidateWriteRepository for SqlxRequestCandidateReadRepository {
async fn upsert(
&self,
candidate: UpsertRequestCandidateRecord,
) -> Result<StoredRequestCandidate, DataLayerError> {
Self::upsert(self, candidate).await
}
async fn upsert_many(
&self,
candidates: Vec<UpsertRequestCandidateRecord>,
) -> Result<usize, DataLayerError> {
Self::upsert_many(self, candidates).await
}
async fn delete_created_before(
&self,
created_before_unix_secs: u64,
limit: usize,
) -> Result<usize, DataLayerError> {
Self::delete_created_before(self, created_before_unix_secs, limit).await
}
}
async fn collect_query_rows<T, S>(
mut rows: S,
map_row: fn(&PgRow) -> Result<T, DataLayerError>,
) -> Result<Vec<T>, DataLayerError>
where
S: TryStream<Ok = PgRow, Error = sqlx::Error> + Unpin,
{
let mut items = Vec::new();
while let Some(row) = rows.try_next().await.map_postgres_err()? {
items.push(map_row(&row)?);
}
Ok(items)
}
fn map_request_candidate_row(row: &PgRow) -> Result<StoredRequestCandidate, DataLayerError> {
let status = RequestCandidateStatus::from_database(row_get::<String>(row, "status")?.as_str())?;
StoredRequestCandidate::new(
row_get(row, "id")?,
row_get(row, "request_id")?,
row_get(row, "user_id")?,
row_get(row, "api_key_id")?,
row_get(row, "username")?,
row_get(row, "api_key_name")?,
row_get(row, "candidate_index")?,
row_get(row, "retry_index")?,
row_get(row, "provider_id")?,
row_get(row, "endpoint_id")?,
row_get(row, "key_id")?,
status,
row_get(row, "skip_reason")?,
row_get(row, "is_cached")?,
row_get(row, "status_code")?,
row_get(row, "error_type")?,
row_get(row, "error_message")?,
row_get(row, "latency_ms")?,
row_get(row, "concurrent_requests")?,
row_get(row, "extra_data")?,
row_get(row, "required_capabilities")?,
row_get(row, "created_at_unix_ms")?,
row_get(row, "started_at_unix_ms")?,
row_get(row, "finished_at_unix_ms")?,
)
}
fn row_get<T>(row: &PgRow, column: &str) -> Result<T, DataLayerError>
where
for<'r> T: sqlx::Decode<'r, sqlx::Postgres> + sqlx::Type<sqlx::Postgres>,
{
row.try_get(column).map_postgres_err()
}
fn candidate_columns() -> &'static str {
LIST_BY_REQUEST_ID_SQL
.split_once("WHERE request_id = $1")
.map(|(prefix, _)| prefix)
.unwrap_or(LIST_BY_REQUEST_ID_SQL)
}
fn status_to_database(status: RequestCandidateStatus) -> &'static str {
match status {
RequestCandidateStatus::Available => "available",
RequestCandidateStatus::Unused => "unused",
RequestCandidateStatus::Pending => "pending",
RequestCandidateStatus::Streaming => "streaming",
RequestCandidateStatus::Success => "success",
RequestCandidateStatus::Failed => "failed",
RequestCandidateStatus::Cancelled => "cancelled",
RequestCandidateStatus::Skipped => "skipped",
}
}
fn to_i32(value: u32) -> Result<i32, DataLayerError> {
i32::try_from(value).map_err(|_| {
DataLayerError::UnexpectedValue(format!("request candidate value out of range: {value}"))
})
}
fn to_i32_u64(value: u64) -> Result<i32, DataLayerError> {
i32::try_from(value).map_err(|_| {
DataLayerError::UnexpectedValue(format!("request candidate value out of range: {value}"))
})
}
fn sanitize_request_candidate_for_postgres(candidate: &mut UpsertRequestCandidateRecord) -> usize {
candidate.sanitize_for_persistence();
let mut replacements = 0usize;
for value in [
&mut candidate.username,
&mut candidate.api_key_name,
&mut candidate.skip_reason,
&mut candidate.error_type,
&mut candidate.error_message,
] {
if let Some(value) = value.as_mut() {
replacements = replacements.saturating_add(replace_nul_characters(value));
}
}
for value in [
&mut candidate.extra_data,
&mut candidate.required_capabilities,
] {
if let Some(value) = value.as_mut() {
replacements = replacements.saturating_add(sanitize_json_nul_characters(value));
}
}
if replacements > 0 {
tracing::warn!(
event_name = "request_candidate_postgres_nul_sanitized",
log_type = "event",
candidate_index = candidate.candidate_index,
retry_index = candidate.retry_index,
status = ?candidate.status,
replacements,
"postgres request candidate persistence replaced unsupported NUL characters"
);
}
replacements
}
fn sanitize_json_nul_characters(value: &mut serde_json::Value) -> usize {
match value {
serde_json::Value::String(value) => replace_nul_characters(value),
serde_json::Value::Array(values) => values.iter_mut().fold(0usize, |count, value| {
count.saturating_add(sanitize_json_nul_characters(value))
}),
serde_json::Value::Object(values) => {
let mut replacements = 0usize;
let original = std::mem::take(values);
for (mut key, mut value) in original {
replacements = replacements.saturating_add(replace_nul_characters(&mut key));
replacements =
replacements.saturating_add(sanitize_json_nul_characters(&mut value));
if values.contains_key(&key) {
let base = key.clone();
let mut suffix = 1usize;
loop {
let candidate = format!("{base}#{suffix}");
if !values.contains_key(&candidate) {
key = candidate;
break;
}
suffix = suffix.saturating_add(1);
}
}
values.insert(key, value);
}
replacements
}
serde_json::Value::Null | serde_json::Value::Bool(_) | serde_json::Value::Number(_) => 0,
}
}
fn replace_nul_characters(value: &mut String) -> usize {
let replacements = value.matches('\0').count();
if replacements > 0 {
*value = value.replace('\0', "\u{fffd}");
}
replacements
}
#[cfg(test)]
mod tests {
use super::{
sanitize_request_candidate_for_postgres, SqlxRequestCandidateReadRepository,
UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL, UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL_TEMPLATE,
UPSERT_CONFLICT_SQL, UPSERT_CONFLICT_SQL_TEMPLATE, UPSERT_SQL, UPSERT_SQL_TEMPLATE,
};
use crate::error::SqlxResultExt;
use crate::{PostgresPoolConfig, PostgresPoolFactory};
use aether_data_contracts::repository::candidates::{
RequestCandidateStatus, UpsertRequestCandidateRecord,
};
use serde_json::{json, Map, Value};
#[test]
fn upsert_sql_does_not_default_missing_or_epoch_created_at_to_epoch() {
assert!(!UPSERT_SQL_TEMPLATE.contains("COALESCE($22, 0)"));
assert!(UPSERT_SQL_TEMPLATE.contains("WHEN $22 IS NOT NULL AND $22 > 1000.0"));
assert!(UPSERT_SQL_TEMPLATE.contains("TO_TIMESTAMP($22 / 1000.0)"));
assert!(UPSERT_SQL_TEMPLATE.contains("TO_TIMESTAMP($23 / 1000.0)"));
assert!(UPSERT_SQL_TEMPLATE.contains("TO_TIMESTAMP($24 / 1000.0)"));
assert!(UPSERT_SQL_TEMPLATE.contains("NOW()"));
assert!(UPSERT_SQL_TEMPLATE.contains("request_candidates.created_at <= TO_TIMESTAMP(1)"));
assert!(UPSERT_SQL_TEMPLATE.contains("THEN EXCLUDED.created_at"));
}
#[test]
fn upsert_sql_preserves_first_identity_and_terminal_fact_when_events_arrive_late() {
for sql in [
UPSERT_SQL_TEMPLATE,
UPSERT_CONFLICT_SQL_TEMPLATE,
UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL_TEMPLATE,
] {
for column in [
"user_id",
"api_key_id",
"username",
"api_key_name",
"provider_id",
"endpoint_id",
"key_id",
] {
let expected =
format!("{column} = COALESCE(request_candidates.{column}, EXCLUDED.{column})");
assert!(
sql.contains(&expected),
"missing immutable identity merge: {expected}"
);
}
assert!(sql.contains(
"request_candidates.status IN ('success', 'failed', 'cancelled', 'skipped')"
));
assert!(sql.contains("EXCLUDED.status <> request_candidates.status"));
assert!(sql.contains(
"request_candidates.status = 'streaming' AND EXCLUDED.status IN ('available', 'unused', 'pending')"
));
assert!(sql.contains(
"request_candidates.status = 'pending' AND EXCLUDED.status IN ('available', 'unused')"
));
assert!(sql.contains("THEN request_candidates.status"));
assert!(sql.contains("THEN request_candidates.latency_ms"));
}
}
#[test]
fn postgres_candidate_sanitizer_discards_unapproved_diagnostics_before_nul_repair() {
let mut extra_data = Map::new();
extra_data.insert(
"bad\0key".to_string(),
json!({"nested": ["bad\0value", {"literal": "\\u0000"}]}),
);
let mut required_capabilities = Map::new();
required_capabilities.insert("cap\0key".to_string(), Value::String("cap\0value".into()));
let mut candidate = UpsertRequestCandidateRecord {
id: "candidate-1".to_string(),
request_id: "request-1".to_string(),
user_id: None,
api_key_id: None,
username: Some("user\0name".to_string()),
api_key_name: Some("key\0name".to_string()),
candidate_index: 0,
retry_index: 0,
provider_id: None,
endpoint_id: None,
key_id: None,
status: RequestCandidateStatus::Failed,
skip_reason: Some("skip\0reason".to_string()),
is_cached: None,
status_code: Some(500),
error_type: Some("upstream\0error".to_string()),
error_message: Some("bad\0message".to_string()),
latency_ms: None,
concurrent_requests: None,
extra_data: Some(Value::Object(extra_data)),
required_capabilities: Some(Value::Object(required_capabilities)),
created_at_unix_ms: Some(1),
started_at_unix_ms: None,
finished_at_unix_ms: Some(2),
};
assert_eq!(sanitize_request_candidate_for_postgres(&mut candidate), 1);
assert!(candidate.username.is_none());
assert!(candidate.api_key_name.is_none());
assert_eq!(candidate.skip_reason.as_deref(), Some("unclassified_skip"));
assert_eq!(candidate.error_type.as_deref(), Some("unclassified_error"));
assert_eq!(candidate.error_message.as_deref(), Some("bad�message"));
assert!(candidate.extra_data.is_none());
assert!(candidate.required_capabilities.is_none());
}
#[test]
fn every_postgres_candidate_conflict_path_preserves_errors_without_unrelated_legacy_data() {
for sql in [
UPSERT_SQL.as_str(),
UPSERT_CONFLICT_SQL.as_str(),
UPSERT_CONFLICT_INHERIT_IS_CACHED_SQL.as_str(),
] {
assert!(
sql.contains("COALESCE(EXCLUDED.error_message, request_candidates.error_message)")
);
assert!(sql.contains("THEN request_candidates.extra_data ELSE EXCLUDED.extra_data END"));
assert!(sql.contains("required_capabilities = EXCLUDED.required_capabilities"));
assert!(!sql.contains("COALESCE(request_candidates.extra_data"));
assert!(!sql.contains("request_candidates.required_capabilities"));
assert!(sql.contains("ELSE 'unclassified_skip' END"));
assert!(sql.contains("ELSE 'unclassified_error' END"));
assert!(sql.contains("THEN 'first_byte_timeout'"));
assert!(!sql.contains("__AETHER_SANITIZED_LEGACY_"));
assert!(!sql.contains("__AETHER_CANDIDATE_"));
}
}
#[tokio::test]
async fn repository_constructs_from_lazy_pool() {
let factory = PostgresPoolFactory::new(PostgresPoolConfig {
database_url: "postgres://localhost/aether".to_string(),
min_connections: 1,
max_connections: 4,
acquire_timeout_ms: 1_000,
idle_timeout_ms: 5_000,
max_lifetime_ms: 30_000,
statement_cache_capacity: 64,
require_ssl: false,
})
.expect("factory should build");
let pool = factory.connect_lazy().expect("pool should build");
let repository = SqlxRequestCandidateReadRepository::new(pool);
let _ = repository.pool();
let _ = repository.transaction_runner();
}
#[tokio::test]
#[ignore = "requires AETHER_TEST_DATABASE_URL and PostgreSQL migrations"]
async fn live_postgres_candidate_nul_is_sanitized_and_legacy_json_is_discarded() {
let database_url = std::env::var("AETHER_TEST_DATABASE_URL")
.expect("AETHER_TEST_DATABASE_URL must point at the test database");
let factory = PostgresPoolFactory::new(PostgresPoolConfig {
database_url,
min_connections: 1,
max_connections: 2,
acquire_timeout_ms: 10_000,
idle_timeout_ms: 30_000,
max_lifetime_ms: 60_000,
statement_cache_capacity: 64,
require_ssl: false,
})
.expect("factory should build");
let repository = SqlxRequestCandidateReadRepository::new(
factory.connect_lazy().expect("lazy pool should build"),
);
crate::run_migrations(repository.pool())
.await
.expect("test database migrations should succeed");
let mapped_error = sqlx::query("SELECT $1::jsonb")
.bind(json!("bad\0value"))
.execute(repository.pool())
.await
.map_postgres_err()
.expect_err("PostgreSQL jsonb should reject a NUL string");
assert!(mapped_error.to_string().contains("SQLSTATE 22P05"));
let suffix = uuid::Uuid::new_v4().simple().to_string();
let single_request_id = format!("candidate-nul-single-{suffix}");
let batch_request_id = format!("candidate-nul-batch-{suffix}");
let healthy_request_id = format!("candidate-nul-healthy-{suffix}");
let legacy_extra =
r#"{"old\u0000key":"old\u0000value","literal":"\\u0000","adjacent":"\u0000\u0000"}"#;
let legacy_capabilities = r#"{"cap\u0000key":"cap\u0000value"}"#;
for request_id in [&single_request_id, &batch_request_id] {
sqlx::query(
r#"
INSERT INTO request_candidates (
id, request_id, candidate_index, retry_index, status,
skip_reason, error_type, extra_data, required_capabilities, error_message, created_at
)
VALUES ($1, $2, 0, 0, 'pending', $3, $4, $5::json, $6::json, $7, NOW())
"#,
)
.bind(uuid::Uuid::new_v4().to_string())
.bind(request_id)
.bind("legacy skip reason with tenant-secret")
.bind("legacy_error_type_with_token")
.bind(legacy_extra)
.bind(legacy_capabilities)
.bind("Bearer legacy-secret")
.execute(repository.pool())
.await
.expect("legacy JSON poison seed should persist in the json column");
}
let candidate = |request_id: &str, id: String| UpsertRequestCandidateRecord {
id,
request_id: request_id.to_string(),
user_id: None,
api_key_id: None,
username: None,
api_key_name: None,
candidate_index: 0,
retry_index: 0,
provider_id: None,
endpoint_id: None,
key_id: None,
status: RequestCandidateStatus::Success,
skip_reason: None,
is_cached: Some(false),
status_code: Some(200),
error_type: None,
error_message: Some("bad\0message".to_string()),
latency_ms: Some(1),
concurrent_requests: None,
extra_data: Some(json!({"new": true, "nested": "new\0value"})),
required_capabilities: None,
created_at_unix_ms: Some(1_700_000_000_000),
started_at_unix_ms: Some(1_700_000_000_000),
finished_at_unix_ms: Some(1_700_000_000_001),
};
repository
.upsert(candidate(
&single_request_id,
uuid::Uuid::new_v4().to_string(),
))
.await
.expect("single conflict should discard legacy diagnostics");
repository
.upsert_many(vec![
candidate(&batch_request_id, uuid::Uuid::new_v4().to_string()),
candidate(&healthy_request_id, uuid::Uuid::new_v4().to_string()),
])
.await
.expect("batch conflict should discard legacy diagnostics without blocking a peer");
for request_id in [&single_request_id, &batch_request_id] {
let raw = sqlx::query(
"SELECT skip_reason, error_type, error_message, extra_data, required_capabilities FROM request_candidates WHERE request_id = $1",
)
.bind(request_id)
.fetch_one(repository.pool())
.await
.expect("raw candidate diagnostics should load");
assert_eq!(
sqlx::Row::try_get::<Option<String>, _>(&raw, "error_message")
.expect("error_message should decode")
.as_deref(),
Some("bad�message")
);
assert_eq!(
sqlx::Row::try_get::<Option<String>, _>(&raw, "skip_reason")
.expect("skip_reason should decode")
.as_deref(),
Some("unclassified_skip")
);
assert_eq!(
sqlx::Row::try_get::<Option<String>, _>(&raw, "error_type")
.expect("error_type should decode")
.as_deref(),
Some("unclassified_error")
);
assert!(
sqlx::Row::try_get::<Option<serde_json::Value>, _>(&raw, "extra_data")
.expect("extra_data should decode")
.is_none()
);
assert!(sqlx::Row::try_get::<Option<serde_json::Value>, _>(
&raw,
"required_capabilities"
)
.expect("required_capabilities should decode")
.is_none());
let rows = repository
.list_by_request_id(request_id)
.await
.expect("sanitized candidate should be readable");
assert_eq!(rows.len(), 1);
assert_eq!(rows[0].status, RequestCandidateStatus::Success);
assert_eq!(rows[0].error_message.as_deref(), Some("bad�message"));
assert!(rows[0].extra_data.is_none());
assert!(rows[0].required_capabilities.is_none());
}
assert_eq!(
repository
.list_by_request_id(&healthy_request_id)
.await
.expect("healthy batch peer should be readable")
.len(),
1
);
let mut cleanup_request_ids = vec![single_request_id, batch_request_id, healthy_request_id];
for write_path in 0..3 {
let request_id = uuid::Uuid::new_v4().to_string();
cleanup_request_ids.push(request_id.clone());
let mut failed = candidate(&request_id, uuid::Uuid::new_v4().to_string());
failed.status = RequestCandidateStatus::Failed;
failed.status_code = Some(400);
failed.error_message = Some("original upstream failure".to_string());
failed.is_cached = (write_path != 2).then_some(false);
failed.extra_data = Some(json!({
"upstream_response": {
"status_code": 400,
"headers": {"x-request-id": "original-upstream-id"},
"body": {"error": {"message": "original upstream failure", "param": "model"}}
},
"error_flow": {"status_code": 400, "message": "original upstream failure"}
}));
let mut pending = failed.clone();
pending.status = RequestCandidateStatus::Pending;
pending.status_code = None;
pending.error_message = None;
pending.extra_data = None;
repository
.upsert(pending.clone())
.await
.expect("pending seed should persist");
if write_path == 0 {
repository
.upsert(failed)
.await
.expect("single failure should persist");
} else {
repository
.upsert_many(vec![failed])
.await
.expect("batch failure should persist");
}
pending.status_code = Some(200);
pending.error_message = Some("late unrelated error".to_string());
pending.extra_data = Some(json!({
"upstream_response": {"status_code": 200, "body": "late unrelated response"}
}));
if write_path == 0 {
repository
.upsert(pending)
.await
.expect("late update should persist");
} else {
repository
.upsert_many(vec![pending])
.await
.expect("late batch should persist");
}
let stored = repository
.list_by_request_id(&request_id)
.await
.expect("failure should read");
assert_eq!(stored[0].status, RequestCandidateStatus::Failed);
assert_eq!(stored[0].status_code, Some(400));
assert_eq!(
stored[0].error_message.as_deref(),
Some("original upstream failure")
);
let extra = stored[0]
.extra_data
.as_ref()
.expect("failure details should remain");
assert_eq!(extra["upstream_response"]["status_code"], 400);
assert_eq!(
extra["upstream_response"]["headers"]["x-request-id"],
"original-upstream-id"
);
assert_eq!(
extra["upstream_response"]["body"]["error"]["param"],
"model"
);
assert_eq!(extra["error_flow"]["message"], "original upstream failure");
let mut public = stored[0].clone();
public.sanitize_sensitive_diagnostics();
assert!(!serde_json::to_string(&public)
.expect("public record should serialize")
.contains("original upstream failure"));
}
sqlx::query("DELETE FROM request_candidates WHERE request_id = ANY($1)")
.bind(cleanup_request_ids)
.execute(repository.pool())
.await
.expect("candidate NUL test rows should clean up");
}
}