i/Aether
1
0
Fork 0
mirror of https://github.com/fawney19/Aether.git synced 2026-09-02 17:30:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(gateway): report terminal stream failure errors consistently

Browse Source
This commit is contained in:
zhefox
2026-05-21 16:15:03 +08:00
parent 12abde2aeb
commit b7b7b4f718
1 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
apps/aether-gateway/src/execution_runtime/stream/execution.rs
View File

@@ -3365,6 +3365,14 @@ async fn execute_stream_from_frame_stream(
)); ));
let stream_failed = let stream_failed =
stream_terminal_summary_represents_failure(stream_terminal_summary.as_ref()); stream_terminal_summary_represents_failure(stream_terminal_summary.as_ref());
let stream_terminal_error_message = stream_terminal_summary
.as_ref()
.and_then(|summary| summary.parser_error.clone())
.or_else(|| {
missing_observed_finish.then(|| {
"execution runtime stream ended before provider terminal event".to_string()
})
});
let usage_payload = build_stream_usage_payload( let usage_payload = build_stream_usage_payload(
trace_id_owned.clone(), trace_id_owned.clone(),
report_kind_owned.unwrap_or_default(), report_kind_owned.unwrap_or_default(),
@@ -3378,7 +3386,7 @@ async fn execute_stream_from_frame_stream(
stream_terminal_summary, stream_terminal_summary,
terminal_telemetry, terminal_telemetry,
); );
if missing_observed_finish { if stream_failed {
warn!( warn!(
event_name = "execution_runtime_stream_missing_terminal_event", event_name = "execution_runtime_stream_missing_terminal_event",
log_type = "ops", log_type = "ops",
@@ -3386,7 +3394,8 @@ async fn execute_stream_from_frame_stream(
request_id = %request_id_for_report_log, request_id = %request_id_for_report_log,
candidate_id = ?candidate_id_for_report.as_deref(), candidate_id = ?candidate_id_for_report.as_deref(),
status_code, status_code,
"gateway stream ended before provider terminal event" error_message = stream_terminal_error_message.as_deref().unwrap_or_default(),
"gateway stream ended with a failed terminal state"
); );
} else { } else {
apply_local_execution_effect( apply_local_execution_effect(
@@ -3446,19 +3455,9 @@ async fn execute_stream_from_frame_stream(
} else { } else {
None None
}, },
error_message: if stream_failed { error_message: stream_failed
stream_terminal_summary .then(|| stream_terminal_error_message)
.as_ref() .flatten(),
.and_then(|summary| summary.parser_error.clone())
.or_else(|| {
missing_observed_finish.then(|| {
"execution runtime stream ended before provider terminal event"
.to_string()
})
})
} else {
None
},
latency_ms: usage_payload latency_ms: usage_payload
.telemetry .telemetry
.as_ref() .as_ref()