i/Aether
1
0
Fork 0
mirror of https://github.com/fawney19/Aether.git synced 2026-10-09 18:59:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: audit strict format conversion contracts

Browse Source
This commit is contained in:
elky
2026-06-03 20:27:15 +08:00
parent 5ac153a0bb
commit 7507af5829
28 changed files with 12206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/aether-provider-transport/src/same_format_provider/mod.rs
+57 -2
View File
@@ -188,13 +188,13 @@ pub fn build_same_format_provider_request_body(
.map(|(key, value)| (key.clone(), value.clone())),
)
} else {
aether_ai_formats::convert_request(
aether_ai_formats::convert_request_pure(
input.client_api_format,
input.provider_api_format,
input.body_json,
&aether_ai_formats::FormatContext::default().with_mapped_model(input.mapped_model),
)
.ok()?
.value
.as_object()?
.clone()
};
@@ -882,6 +882,61 @@ mod tests {
assert_eq!(body.get("stream"), Some(&json!(true)));
}
#[test]
fn same_format_standard_body_preserves_fields_that_cross_format_would_block() {
let body = build_same_format_provider_request_body(SameFormatProviderRequestBodyInput {
body_json: &json!({
"model": "client-model",
"messages": [{"role": "user", "content": "hello"}],
"n": 2,
"reasoning_effort": "max",
"unknown_vendor_field": {"keep": true}
}),
mapped_model: "client-model",
client_api_format: "openai:chat",
provider_api_format: "/v1/chat/completions",
source_model: Some("client-model"),
family: SameFormatProviderFamily::Standard,
body_rules: None,
request_headers: None,
upstream_is_stream: false,
force_body_stream_field: false,
kiro_auth_config: None,
is_claude_code: false,
enable_model_directives: false,
})
.expect("same-format body should bypass canonical conversion");
assert_eq!(body["n"], 2);
assert_eq!(body["reasoning_effort"], "max");
assert_eq!(body["unknown_vendor_field"]["keep"], true);
}
#[test]
fn cross_format_standard_body_fails_closed_for_lossy_chat_fields() {
let body = build_same_format_provider_request_body(SameFormatProviderRequestBodyInput {
body_json: &json!({
"model": "client-model",
"messages": [{"role": "user", "content": "hello"}],
"n": 2
}),
mapped_model: "upstream-model",
client_api_format: "openai:chat",
provider_api_format: "openai:responses",
source_model: Some("client-model"),
family: SameFormatProviderFamily::Standard,
body_rules: None,
request_headers: None,
upstream_is_stream: false,
force_body_stream_field: false,
kiro_auth_config: None,
is_claude_code: false,
enable_model_directives: false,
});
assert!(body.is_none());
}
#[test]
fn same_format_embedding_body_rejects_multimodal_for_openai_like_provider() {
let body = build_same_format_provider_request_body(SameFormatProviderRequestBodyInput {