i/Aether
1
0
Fork 0
mirror of https://github.com/fawney19/Aether.git synced 2026-09-12 14:10:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #772 from zhefox/main

Browse Source 
fix(gateway): handle pool saturation and malformed Gemini calls
This commit is contained in:
ZheFox
2026-09-01 19:31:44 +08:00
committed by GitHub
parent 715f2773c3 3d87bbf230
commit 5a69cfe40d
15 changed files with 702 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/aether-ai/formats/src/formats/shared/stream_core/format_matrix.rs
+49
View File
@@ -376,6 +376,13 @@ impl StreamingStandardTerminalObserver {
finish_reason,
usage,
} => {
if let Some(parser_error) = finish_reason
.as_deref()
.filter(|reason| !canonical_stream_finish_reason_is_supported(reason))
.map(|reason| format!("unsupported provider stream finish reason: {reason}"))
{
summary.parser_error.get_or_insert(parser_error);
}
summary.finish_reason = finish_reason;
summary.standardized_usage = usage.map(standardized_usage_from_canonical);
summary.observed_finish = true;
@@ -785,6 +792,48 @@ mod tests {
format!("event: {event}\n").into_bytes()
}
#[test]
fn terminal_observer_marks_malformed_gemini_function_call_as_failure() {
let context = report_context("gemini:generate_content", "openai:responses");
let mut observer = StreamingStandardTerminalObserver::default();
observer
.push_line(
&context,
data_line(json!({
"response": {
"responseId": "resp_malformed_tool_call",
"modelVersion": "gemini-3.7-flash-tiered",
"candidates": [{
"index": 0,
"content": {
"role": "model",
"parts": [{"thoughtSignature": "signature", "text": ""}]
},
"finishReason": "MALFORMED_FUNCTION_CALL",
"finishMessage": "Malformed function call: Function call is empty - no input to parse."
}]
},
"responseId": "resp_malformed_tool_call"
})),
)
.expect("Gemini terminal frame should parse");
let summary = observer
.finish(&context)
.expect("terminal observation should finish")
.expect("Gemini terminal frame should produce a summary");
assert!(summary.observed_finish);
assert_eq!(
summary.finish_reason.as_deref(),
Some("MALFORMED_FUNCTION_CALL")
);
assert_eq!(
summary.parser_error.as_deref(),
Some("unsupported provider stream finish reason: MALFORMED_FUNCTION_CALL")
);
}
#[test]
fn event_only_stream_types_convert_across_standard_formats() {
let responses_payload = json!({